Releasenote en waarschuwing: de variabele heet MasterModule__MasterUrl (niet Master__MasterUrl)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-09 23:15:23 +01:00
co-authored by Claude Sonnet 5.5
parent 195443d9a9
commit 893c40c46d
2 changed files with 3 additions and 3 deletions
@@ -20,8 +20,8 @@ The code ships through the existing Gitea Actions pipeline (`deploy_asf_test`, `
Common: `Email__Smtp__Username`, `Email__Smtp__Password`, `App__PublicBaseUrl` (https, no path, per environment), optional `Email__Smtp__TimeoutSeconds` (default 10 per step), `Email__FromName`. Full list: `construction/mail-foundation/infrastructure-design/infrastructure-design.md`.
## Master host: `Master__MasterUrl` is required (test and production)
On every host that runs the master module (SlpSoftware test, SlpSoftware production), set `Master__MasterUrl` to the public address of that master: **https, no path**, e.g. `https://master.example.com`. The shipped `appsettings.json` carries only a placeholder (`<public-url-of-this-master-instance>`).
## Master host: `MasterModule__MasterUrl` is required (test and production)
On every host that runs the master module (SlpSoftware test, SlpSoftware production), set `MasterModule__MasterUrl` to the public address of that master: **https, no path**, e.g. `https://master.example.com`. The shipped `appsettings.json` carries only a placeholder (`<public-url-of-this-master-instance>`).
- **Why:** the hourly integrity check (and the one at start-up) runs without a request, so it cannot derive the address from the request and uses this setting. With the placeholder it used to re-register the slaves with the placeholder, after which a slave could not poll the master any more (`master_poll_failed`). Now a missing or unusable value makes the master log `MasterModule:MasterUrl is not an absolute http(s) address` and skip those background checks; nothing is overwritten.
- **Slaves** (ASF test, later ASF production) need no such variable: they store the address the master registers. A slave refuses an unusable address (`400 invalid_master_url`) and the poller logs `invalid_master_url`.
- **Recovery** of a slave that holds a bad address: set the variable on the master and restart it; the start-up check re-registers the slave. A changed variable needs a restart.
@@ -264,7 +264,7 @@ public class CmsInstanceService(MasterServiceDependencies deps) : ICmsInstanceSe
// The shipped appsettings carry a placeholder here. Using it would overwrite a slave's good master
// address with garbage (the slave then fails every poll), so it counts as "not configured".
deps.Logger.LogWarning(
"MasterModule:MasterUrl is not an absolute http(s) address (set Master__MasterUrl, e.g. https://master.example.com); background checks are skipped.");
"MasterModule:MasterUrl is not an absolute http(s) address (set MasterModule__MasterUrl, e.g. https://master.example.com); background checks are skipped.");
return null;
}