From 893c40c46d3f59e94d9dba1b4915224af86b976a Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Mon, 9 Nov 2026 23:15:23 +0100 Subject: [PATCH] Releasenote en waarschuwing: de variabele heet MasterModule__MasterUrl (niet Master__MasterUrl) Co-Authored-By: Claude Sonnet 5.5 --- .../operations/deployment/deployment-plan.md | 4 ++-- .../Services/CmsInstanceService.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/aidlc-docs/features/identity-email-notifications/operations/deployment/deployment-plan.md b/aidlc-docs/features/identity-email-notifications/operations/deployment/deployment-plan.md index 4bb6ad0..34a1ffe 100644 --- a/aidlc-docs/features/identity-email-notifications/operations/deployment/deployment-plan.md +++ b/aidlc-docs/features/identity-email-notifications/operations/deployment/deployment-plan.md @@ -20,8 +20,8 @@ The code ships through the existing Gitea Actions pipeline (`deploy_asf_test`, ` Common: `Email__Smtp__Username`, `Email__Smtp__Password`, `App__PublicBaseUrl` (https, no path, per environment), optional `Email__Smtp__TimeoutSeconds` (default 10 per step), `Email__FromName`. Full list: `construction/mail-foundation/infrastructure-design/infrastructure-design.md`. -## Master host: `Master__MasterUrl` is required (test and production) -On every host that runs the master module (SlpSoftware test, SlpSoftware production), set `Master__MasterUrl` to the public address of that master: **https, no path**, e.g. `https://master.example.com`. The shipped `appsettings.json` carries only a placeholder (``). +## Master host: `MasterModule__MasterUrl` is required (test and production) +On every host that runs the master module (SlpSoftware test, SlpSoftware production), set `MasterModule__MasterUrl` to the public address of that master: **https, no path**, e.g. `https://master.example.com`. The shipped `appsettings.json` carries only a placeholder (``). - **Why:** the hourly integrity check (and the one at start-up) runs without a request, so it cannot derive the address from the request and uses this setting. With the placeholder it used to re-register the slaves with the placeholder, after which a slave could not poll the master any more (`master_poll_failed`). Now a missing or unusable value makes the master log `MasterModule:MasterUrl is not an absolute http(s) address` and skip those background checks; nothing is overwritten. - **Slaves** (ASF test, later ASF production) need no such variable: they store the address the master registers. A slave refuses an unusable address (`400 invalid_master_url`) and the poller logs `invalid_master_url`. - **Recovery** of a slave that holds a bad address: set the variable on the master and restart it; the start-up check re-registers the slave. A changed variable needs a restart. diff --git a/src/SlpModularCms.Modules.Master/Services/CmsInstanceService.cs b/src/SlpModularCms.Modules.Master/Services/CmsInstanceService.cs index 4e5e3e7..178c2ea 100644 --- a/src/SlpModularCms.Modules.Master/Services/CmsInstanceService.cs +++ b/src/SlpModularCms.Modules.Master/Services/CmsInstanceService.cs @@ -264,7 +264,7 @@ public class CmsInstanceService(MasterServiceDependencies deps) : ICmsInstanceSe // The shipped appsettings carry a placeholder here. Using it would overwrite a slave's good master // address with garbage (the slave then fails every poll), so it counts as "not configured". deps.Logger.LogWarning( - "MasterModule:MasterUrl is not an absolute http(s) address (set Master__MasterUrl, e.g. https://master.example.com); background checks are skipped."); + "MasterModule:MasterUrl is not an absolute http(s) address (set MasterModule__MasterUrl, e.g. https://master.example.com); background checks are skipped."); return null; }