Marks the shoot-type pages feature as complete
The final texts and extra photos follow in a separate feature; content-pending.md is its input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -9,4 +9,4 @@
|
||||
| Feature | soorten-fotoshoots-page | ✅ Complete | feature/soorten-fotoshoots-page | web/src/routes/soorten-fotoshoots.tsx, new web/src/content/shootTypes.ts, new web/src/assets/shoots/, new shared CallToAction, MediaText (reverse prop), Pricing (id="prijzen" only), siteContent (service area), own entries in sitePages.ts / lighthouserc.cjs, JSON-LD via the shared webPage() helper in seo.ts | 2026-10-24 |
|
||||
| Feature | contact-page | ✅ Complete | feature/contact-page | web/src/routes/contact.tsx, web/src/content, possibly ContactForm/ContactSection, PageIntro, MediaText/FramedImage, web/src/seo.ts, sitePages/sitemap | 2026-10-24 |
|
||||
| Feature | portfolio-page | ✅ Complete | feature/portfolio-page (based on master after over-mij merge; worktree ../AndreaSlopFotografie-portfolio) | web/src/routes/portfolio.tsx, web/src/content, new PortfolioGrid + Lightbox, InstagramGrid (moved to shared), own entries in sitePages.ts / lighthouserc.cjs, ImageGallery JSON-LD via the shared webPage() helper | 2026-10-24 |
|
||||
| Feature | [shoot-type-pages](features/shoot-type-pages/content-pending.md) | ⏸️ Waiting for content | feature/shoot-type-pages (worktree ../AndreaSlopFotografie-shoot-type-pages) | new route(s) per shoot type under web/src/routes, web/src/content (shootTypes.ts extension, timeline content), shared Timeline component, links from soorten-fotoshoots, seo.ts (webPage helper), sitePages.ts / sitemap, lighthouserc.cjs | 2026-10-29 |
|
||||
| Feature | shoot-type-pages | ✅ Complete (content follow-up: [content-pending.md](features/shoot-type-pages/content-pending.md)) | feature/shoot-type-pages (worktree ../AndreaSlopFotografie-shoot-type-pages) | new route(s) per shoot type under web/src/routes, web/src/content (shootTypes.ts extension, timeline content), shared Timeline component, links from soorten-fotoshoots, seo.ts (webPage helper), sitePages.ts / sitemap, lighthouserc.cjs | 2026-10-29 |
|
||||
|
||||
@@ -5,7 +5,7 @@
|
||||
- **Feature Slug**: shoot-type-pages
|
||||
- **Project Type**: Brownfield
|
||||
- **Start Date**: 2026-10-29T17:19:19Z
|
||||
- **Current Stage**: CONSTRUCTION - Build and Test complete; ⏸️ waiting for content (Andrea) before merge — see content-pending.md
|
||||
- **Current Stage**: Complete (merged to master via PR #13; content follow-up as a separate feature, see content-pending.md)
|
||||
- **Branch**: feature/shoot-type-pages (from master 18e81d0)
|
||||
- **Worktree**: K:\Development\SlpSoftware\Projects\AndreaSlopFotografie-shoot-type-pages
|
||||
|
||||
|
||||
@@ -428,3 +428,12 @@
|
||||
**Context**: CONSTRUCTION - Build and Test complete, waiting for content
|
||||
|
||||
---
|
||||
|
||||
## Build and Test — Approved; workflow complete
|
||||
**Timestamp**: 2026-10-30T23:40:07Z
|
||||
**User Input**: "ga verder. de content moet later in een aparte feature worden opgepakt. Dan kunnen we deze feature gewoon afronden"
|
||||
**AI Response**: Asked what to do with PR #13; the user chose "Nu mergen". Content (98 DRAFT, 7 OPEN, 25 photos) moves to a separate future feature; content-pending.md is its input. The CON-ST-03 gate becomes: no DRAFT/OPEN marker in production (release/* branch). active-features status ✅ Complete with a link to the follow-up; state Complete. Next: commit, push, remove WIP from the PR #13 title, merge after green CI.
|
||||
**Operations Phase Decision**: No (Decided At: Requirements Analysis)
|
||||
**Context**: Workflow Complete
|
||||
|
||||
---
|
||||
|
||||
@@ -1,7 +1,8 @@
|
||||
# Shoot-type pages: content still pending
|
||||
|
||||
Date: 2026-10-31
|
||||
Branch: `feature/shoot-type-pages` (commits `e5f4348`, `7af2069`, `d3bc1d7`). **Do not merge to master until everything below is done.**
|
||||
|
||||
The feature shoot-type-pages is **complete and merged to master** (PR #13) with draft texts. On 2026-10-31 the owner decided that the final texts, the open questions and the extra photos are handled in a **separate, later feature** (for example `shoot-type-pages-content`). That feature starts from master and uses this document as its input. **Gate:** no `DRAFT(CON-ST-03)` or `OPEN(CON-ST-04)` marker may reach production. Production deploys only from a `release/*` branch, so check the markers before the first release that contains these pages.
|
||||
|
||||
## 1. Status and blocker
|
||||
|
||||
@@ -13,7 +14,7 @@ Branch: `feature/shoot-type-pages` (commits `e5f4348`, `7af2069`, `d3bc1d7`). **
|
||||
| Answers to the open questions (7 `OPEN(CON-ST-04)` markers) | **Waiting**: Andrea |
|
||||
| Extra photos (25 in total) | **Waiting**: Andrea. The pages work without them, but look emptier |
|
||||
|
||||
Blocker: Andrea has not returned approved texts, answers or photos ("they come later, they are not ready yet"). She delivers via Bryan (the owner). Nothing in the code blocks the merge; only content does (CON-ST-03 in `requirements.md`; NFR-ST-05 SECURITY-09: no draft markers in production).
|
||||
Blocker: Andrea has not returned approved texts, answers or photos ("they come later, they are not ready yet"). She delivers via Bryan (the owner). Nothing in the code is open; only content is (CON-ST-03 in `requirements.md`; NFR-ST-05 SECURITY-09: no draft markers in production).
|
||||
|
||||
## 2. Where things are
|
||||
|
||||
@@ -111,12 +112,12 @@ Dutch; describe what is in the photo (who, what, setting), not the shoot or keyw
|
||||
|
||||
The five `web/public/og-<shoot>.jpg` files (1200x630) were approved by the owner on 2026-10-30. New photos do not change them. **Changing any OG image needs the owner's approval.** Loveshoot and Portret are upscaled about 1.42x from the shoot photo because no landscape photo existed, so better sources may be wanted later. Method: take the largest source, crop to 1200:630 with a vertical offset chosen by eye (faces and hands inside the crop), scale with .NET `System.Drawing` (`HighQualityBicubic`) onto a fresh bitmap (this strips EXIF and ICC; sRGB), encode as JPEG, file at most 100 KB. The earlier script was a temporary scratchpad script and is gone. Show the result to the owner before committing, and check the `ogImage` alt in `web/src/sitePages.ts` still matches the photo.
|
||||
|
||||
## 5. Definition of done before merge
|
||||
## 5. Definition of done for the content feature (before its merge and before a production release)
|
||||
|
||||
- [ ] `rg -n "DRAFT\(CON-ST-03\)" web/src` returns nothing (from the repo root; from `web/` use `src`).
|
||||
- [ ] `rg -n "OPEN\(CON-ST-04\)" web/src` returns nothing.
|
||||
- [ ] Andrea's approval is logged in `audit.md` (what, when, via Bryan).
|
||||
- [ ] The branch is up to date with master. On 2026-10-31 it already contained master `1416497`, including the seroval patch from PR #12, so `audit:deps` passes. Merge master again if it has moved since.
|
||||
- [ ] The content branch starts from (and is up to date with) master, which contains this feature since PR #13.
|
||||
- [ ] `pnpm check` from `web/` is green (lint, format, `tsc`, tests with 100 % coverage on `src/lib/**`, build, audits, Lighthouse).
|
||||
- [ ] Known Lighthouse items, judged in context:
|
||||
- mobile `/` (0.75, budget 0.8) and `/contact` (0.87, budget 0.9) are below budget on master as well, so not caused by this feature;
|
||||
|
||||
Reference in New Issue
Block a user