Eerder gemeld als byte-identiek: dat klopte niet, de projectreferentie was bij B2a niet aangepast. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
34 lines
3.6 KiB
Markdown
34 lines
3.6 KiB
Markdown
# CI builds and tests the master CMS only (ci-master-pipeline)
|
|
|
|
- **Slug**: ci-master-pipeline
|
|
- **Type**: Feature (small, infrastructure), built outside the AI-DLC flow and documented afterwards
|
|
- **Status**: Pushed on `feature/contact-forms-module` (commits 24168c6, ca46ce2, 612263e, ad8841a); first CI run with the new workflow pending
|
|
- **Affected components**: `.gitea/workflows/continuous_integration.yaml`, `SlpModularCms.Ci.slnf`, `scripts/smoke-site.sh`, `SlpModularCms.Api` (+ Tests), `SlpModularCms.Core` (`CmsHost`, `CmsHostOptions`), site projects, `SlpModularCms.Modules.Contact.Tests`
|
|
- **Documented**: 2026-11-15
|
|
- **Documentation Language**: English
|
|
- **Conversation Language**: Dutch (user language)
|
|
|
|
> Not run through the AI-DLC stages; this file records what the code does. Decision by Bryan (relayed by SLS-Main): the CI builds and tests the master CMS only; sites are thin compositions.
|
|
|
|
## Idea
|
|
|
|
`SlpModularCms.Api` is the master CMS: Core plus **every** module (Availability, Contact, Identity, Master, Offerings). The site projects (`Api.SlpSoftware`, `Api.AndreaSlopFotografie`, `Api.Slave`) only compose: a `Program.cs`, a list of module references and an `appsettings.json`. All behaviour lives in Core and the modules and is tested once, on the master host.
|
|
|
|
## What changed
|
|
|
|
| Area | Change |
|
|
|---|---|
|
|
| Website mode | `Website:Mode` (`SpaFallback` default, `PrerenderedPages`) from configuration (`CmsHostOptions.ResolveWebsiteMode`, decided once as `WebsiteModeSelection`). An unknown value stops the host. ASF sets `PrerenderedPages` in its own `appsettings.json`; no site chooses a mode in code. |
|
|
| Master host | `SlpModularCms.Api` references all modules and has generic defaults for Website, Email, App, Contact and RateLimiting. |
|
|
| Tests | The ASF test project is gone (18 tests moved, none lost). Site composition and committed defaults: `Api.Tests/SiteContractTests` (reads each site's csproj and appsettings.json, no build of the site). Site behaviour: the master host run with a site's committed settings on top (`AsfVariantPipelineTests`, `SiteVariantContactTests`). Contact pipeline tests and the OpenAPI snapshot run on the master `Api` (`Contact.Tests` references `SlpModularCms.Api`, not a site project). The snapshot changed in exactly three lines: the document title and two tag/assembly names went from `SlpModularCms.Api.SlpSoftware` to `SlpModularCms.Api` (the names come from the host assembly); no path or schema changed. |
|
|
| CI | `backend-build`/`backend-test` use `SlpModularCms.Ci.slnf` (no site projects). `publish-sls-test` no longer runs on pull requests. `compile-sites` (not required) compiles the three site projects. After each test deploy `smoke-sls-test` / `smoke-asf-test` run `scripts/smoke-site.sh`. |
|
|
| Branch protection | Required checks on `master`: `backend-test (pull_request)` and `frontend-test (pull_request)` only; the old `publish-test (pull_request)` requirement must be removed before the merge (see `docs/deploy-en-testomgevingen.md`). |
|
|
|
|
## Smoke test (`scripts/smoke-site.sh <url> <sls-test|asf-test>`)
|
|
|
|
Anonymous requests only: `/health`, public offerings, public banner (200 or 204), `/offerings/all` is 401, `X-Robots-Tag: noindex` and `robots.txt` disallow on a test host, the module list from `/api/v1/System/capabilities` (SLS: all five; ASF: without Master), SLS `/sitemap.xml` 404, ASF unknown path 404 (prerendered mode). A failing check fails the run.
|
|
|
|
## Safety net for composition errors
|
|
|
|
1. `SiteContractTests`: module references and committed defaults per site. 2. `compile-sites` on pull requests. 3. The smoke test after every test deploy. 4. Policy: production only for a commit that was green on that site's test host.
|