Werk kwetsbare dependencies bij (Cryptography.Xml, zod, react-router)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -410,3 +410,8 @@
|
||||
**Timestamp**: 2026-11-07
|
||||
**User Input**: "Ga verder" (approved U2 code)
|
||||
**AI Response**: handback-u2.md written (incl. U1 Location-encoding correction, below-AA pairs as information, dependency advisory finding). Build and Test documents generated under construction/build-and-test/. Finding: pre-existing vulnerable packages will fail the CI vulnerability-scan gate; decision requested. Awaiting approval.
|
||||
|
||||
## Build and Test approval + dependency bump
|
||||
**Timestamp**: 2026-11-07
|
||||
**User Input**: "Goedkeuren en doe maar optie A"
|
||||
**AI Response**: Build and Test approved. Option A done: Cryptography.Xml 10.0.14 (Core + 3 test projects), zod ^4.6.6, @tanstack/react-router 1.170.46; vulnerability scans clean, all suites green. Proceeding to Operations.
|
||||
|
||||
+2
-2
@@ -13,8 +13,8 @@
|
||||
### Performance
|
||||
- Local 0.72 ms/request (in-memory). Pi measurement pending the first test deploy.
|
||||
### Additional
|
||||
- **Security / dependency scan: FAIL (pre-existing).** `dotnet list package --vulnerable` reports `System.Security.Cryptography.Xml 10.0.10` and transitive `Pkcs 10.0.10` (high; patched in 10.0.12+, 10.0.14 available) in `Core` and four test projects; `pnpm audit --prod` reports 6 findings (seroval, zod; patched versions exist). Not caused by this feature, but the CI `vulnerability-scan` gate will fail and block publishing. Decision needed.
|
||||
- **Security / dependency scan: was FAIL (pre-existing), FIXED with option A (Xml 10.0.14, zod ^4.6.6, react-router 1.170.46): now clean for NuGet and `pnpm audit --prod`; suites rerun green. Original finding:** `dotnet list package --vulnerable` reports `System.Security.Cryptography.Xml 10.0.10` and transitive `Pkcs 10.0.10` (high; patched in 10.0.12+, 10.0.14 available) in `Core` and four test projects; `pnpm audit --prod` reports 6 findings (seroval, zod; patched versions exist). Not caused by this feature, but the CI `vulnerability-scan` gate will fail and block publishing. Decision needed.
|
||||
- Contract/E2E: the curl checks in manual-steps 14-18 act as the E2E check on the test host after the first deploy.
|
||||
|
||||
## Overall Status
|
||||
- **Build**: Success. **All locally runnable tests**: Pass. **Ready for Operations**: Yes for the code; CI is blocked by the dependency advisories until resolved or overridden, and the database-backed tests are unproven until CI runs.
|
||||
- **Build**: Success. **All locally runnable tests**: Pass. **Ready for Operations**: Yes; the database-backed tests are unproven until CI runs.
|
||||
|
||||
@@ -27,7 +27,7 @@ The 301 `Location` was built from the decoded path without re-encoding: `/a%3Fb/
|
||||
- The admin favicon is `themes/asf/favicon.png` (copied read-only from the website; the website repo was not touched).
|
||||
|
||||
## 6. Open items and risks
|
||||
1. **Vulnerability-scan gate will fail in CI** (pre-existing, not caused by U2): `System.Security.Cryptography.Xml 10.0.10` and transitive `System.Security.Cryptography.Pkcs 10.0.10` now have high advisories (patched at 10.0.12+; 10.0.14 exists), pinned in `Core` and four test projects; plus `pnpm audit` reports 6 findings (seroval, zod). This blocks publish for SlpSoftware and ASF alike. Needs a decision (small dependency bump, separate from this feature, or accept and override).
|
||||
1. **Vulnerability gate (pre-existing advisories) - resolved with Bryan's go (option A)**: `System.Security.Cryptography.Xml` pin 10.0.10 -> 10.0.14 in `Core` and the Availability/Master/Offerings test projects (transitive `Pkcs` follows); frontend `zod` ^4.6.6 and `@tanstack/react-router` 1.170.46 (pulls `seroval` 1.7.9). `dotnet list package --vulnerable` is clean and `pnpm audit --prod` finds nothing; all suites rerun green. Shared packages changed: SlpSoftware and the other hosts get these patched versions too (DataProtection uses the Xml package), so watch the first SlpSoftware test deploy after merge.
|
||||
2. Setup token must be removed from `shared/env` after the first administrator exists (step 17).
|
||||
3. The proxy block change is only the `proxy_pass` target (port 5200); the website repo generator is updated in U3.
|
||||
4. Production for ASF is out of scope.
|
||||
|
||||
Reference in New Issue
Block a user