From e37b8f3cf974dd7fb1cce73b2dcda42d9f744551 Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Sat, 7 Nov 2026 23:48:34 +0100 Subject: [PATCH] Werk kwetsbare dependencies bij (Cryptography.Xml, zod, react-router) Co-Authored-By: Claude Sonnet 5.5 --- .../features/andreaslop-site-hosting/audit.md | 5 ++ .../build-and-test/build-and-test-summary.md | 4 +- .../andreaslop-site-hosting/handback-u2.md | 2 +- frontend/package.json | 4 +- frontend/pnpm-lock.yaml | 84 +++++++++---------- .../SlpModularCms.Core.csproj | 2 +- ...dularCms.Modules.Availability.Tests.csproj | 2 +- .../SlpModularCms.Modules.Master.Tests.csproj | 2 +- ...pModularCms.Modules.Offerings.Tests.csproj | 2 +- 9 files changed, 56 insertions(+), 51 deletions(-) diff --git a/aidlc-docs/features/andreaslop-site-hosting/audit.md b/aidlc-docs/features/andreaslop-site-hosting/audit.md index 8b416c7..9f06e7b 100644 --- a/aidlc-docs/features/andreaslop-site-hosting/audit.md +++ b/aidlc-docs/features/andreaslop-site-hosting/audit.md @@ -410,3 +410,8 @@ **Timestamp**: 2026-11-07 **User Input**: "Ga verder" (approved U2 code) **AI Response**: handback-u2.md written (incl. U1 Location-encoding correction, below-AA pairs as information, dependency advisory finding). Build and Test documents generated under construction/build-and-test/. Finding: pre-existing vulnerable packages will fail the CI vulnerability-scan gate; decision requested. Awaiting approval. + +## Build and Test approval + dependency bump +**Timestamp**: 2026-11-07 +**User Input**: "Goedkeuren en doe maar optie A" +**AI Response**: Build and Test approved. Option A done: Cryptography.Xml 10.0.14 (Core + 3 test projects), zod ^4.6.6, @tanstack/react-router 1.170.46; vulnerability scans clean, all suites green. Proceeding to Operations. diff --git a/aidlc-docs/features/andreaslop-site-hosting/construction/build-and-test/build-and-test-summary.md b/aidlc-docs/features/andreaslop-site-hosting/construction/build-and-test/build-and-test-summary.md index cba5105..540a08e 100644 --- a/aidlc-docs/features/andreaslop-site-hosting/construction/build-and-test/build-and-test-summary.md +++ b/aidlc-docs/features/andreaslop-site-hosting/construction/build-and-test/build-and-test-summary.md @@ -13,8 +13,8 @@ ### Performance - Local 0.72 ms/request (in-memory). Pi measurement pending the first test deploy. ### Additional -- **Security / dependency scan: FAIL (pre-existing).** `dotnet list package --vulnerable` reports `System.Security.Cryptography.Xml 10.0.10` and transitive `Pkcs 10.0.10` (high; patched in 10.0.12+, 10.0.14 available) in `Core` and four test projects; `pnpm audit --prod` reports 6 findings (seroval, zod; patched versions exist). Not caused by this feature, but the CI `vulnerability-scan` gate will fail and block publishing. Decision needed. +- **Security / dependency scan: was FAIL (pre-existing), FIXED with option A (Xml 10.0.14, zod ^4.6.6, react-router 1.170.46): now clean for NuGet and `pnpm audit --prod`; suites rerun green. Original finding:** `dotnet list package --vulnerable` reports `System.Security.Cryptography.Xml 10.0.10` and transitive `Pkcs 10.0.10` (high; patched in 10.0.12+, 10.0.14 available) in `Core` and four test projects; `pnpm audit --prod` reports 6 findings (seroval, zod; patched versions exist). Not caused by this feature, but the CI `vulnerability-scan` gate will fail and block publishing. Decision needed. - Contract/E2E: the curl checks in manual-steps 14-18 act as the E2E check on the test host after the first deploy. ## Overall Status -- **Build**: Success. **All locally runnable tests**: Pass. **Ready for Operations**: Yes for the code; CI is blocked by the dependency advisories until resolved or overridden, and the database-backed tests are unproven until CI runs. +- **Build**: Success. **All locally runnable tests**: Pass. **Ready for Operations**: Yes; the database-backed tests are unproven until CI runs. diff --git a/aidlc-docs/features/andreaslop-site-hosting/handback-u2.md b/aidlc-docs/features/andreaslop-site-hosting/handback-u2.md index 649c197..d53147d 100644 --- a/aidlc-docs/features/andreaslop-site-hosting/handback-u2.md +++ b/aidlc-docs/features/andreaslop-site-hosting/handback-u2.md @@ -27,7 +27,7 @@ The 301 `Location` was built from the decoded path without re-encoding: `/a%3Fb/ - The admin favicon is `themes/asf/favicon.png` (copied read-only from the website; the website repo was not touched). ## 6. Open items and risks -1. **Vulnerability-scan gate will fail in CI** (pre-existing, not caused by U2): `System.Security.Cryptography.Xml 10.0.10` and transitive `System.Security.Cryptography.Pkcs 10.0.10` now have high advisories (patched at 10.0.12+; 10.0.14 exists), pinned in `Core` and four test projects; plus `pnpm audit` reports 6 findings (seroval, zod). This blocks publish for SlpSoftware and ASF alike. Needs a decision (small dependency bump, separate from this feature, or accept and override). +1. **Vulnerability gate (pre-existing advisories) - resolved with Bryan's go (option A)**: `System.Security.Cryptography.Xml` pin 10.0.10 -> 10.0.14 in `Core` and the Availability/Master/Offerings test projects (transitive `Pkcs` follows); frontend `zod` ^4.6.6 and `@tanstack/react-router` 1.170.46 (pulls `seroval` 1.7.9). `dotnet list package --vulnerable` is clean and `pnpm audit --prod` finds nothing; all suites rerun green. Shared packages changed: SlpSoftware and the other hosts get these patched versions too (DataProtection uses the Xml package), so watch the first SlpSoftware test deploy after merge. 2. Setup token must be removed from `shared/env` after the first administrator exists (step 17). 3. The proxy block change is only the `proxy_pass` target (port 5200); the website repo generator is updated in U3. 4. Production for ASF is out of scope. diff --git a/frontend/package.json b/frontend/package.json index b0f4b4e..2741cfb 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -32,7 +32,7 @@ "@radix-ui/react-slot": "^1.3.0", "@sentry/react": "^10.68.0", "@tanstack/react-query": "^5.101.0", - "@tanstack/react-router": "^1.170.16", + "@tanstack/react-router": "^1.170.46", "class-variance-authority": "^0.7.1", "clsx": "^2.1.1", "i18next": "^26.3.1", @@ -44,7 +44,7 @@ "react-i18next": "^17.0.8", "sonner": "^2.0.7", "tailwind-merge": "^3.6.0", - "zod": "^4.4.3" + "zod": "^4.6.6" }, "devDependencies": { "@eslint/js": "^10.0.1", diff --git a/frontend/pnpm-lock.yaml b/frontend/pnpm-lock.yaml index 5c80a73..bcae947 100644 --- a/frontend/pnpm-lock.yaml +++ b/frontend/pnpm-lock.yaml @@ -48,8 +48,8 @@ importers: specifier: ^5.101.0 version: 5.101.0(react@19.2.7) '@tanstack/react-router': - specifier: ^1.170.16 - version: 1.170.16(react-dom@19.2.7(react@19.2.7))(react@19.2.7) + specifier: ^1.170.46 + version: 1.170.46(react-dom@19.2.7(react@19.2.7))(react@19.2.7) class-variance-authority: specifier: ^0.7.1 version: 0.7.1 @@ -84,8 +84,8 @@ importers: specifier: ^3.6.0 version: 3.6.0 zod: - specifier: ^4.4.3 - version: 4.4.3 + specifier: ^4.6.6 + version: 4.6.7 devDependencies: '@eslint/js': specifier: ^10.0.1 @@ -1055,8 +1055,8 @@ packages: peerDependencies: vite: ^5.2.0 || ^6 || ^7 || ^8 - '@tanstack/history@1.162.0': - resolution: {integrity: sha512-79pf/RkhteYZTRgcR4F9kbk84P2N8rugQJswxfIqovlbRiT3yI7eBE+5QorIrZaOKktsgzRlXh1l/du/xpl4iA==} + '@tanstack/history@1.162.5': + resolution: {integrity: sha512-w1+YvwmTkwt5n8yUqEH3IWZ9DsmorCZW/EQ3KYHnqEgIkOZpH54NvW6/Epq3Dzb8H0ifIeYX8PExvrNLIH5FIA==} engines: {node: '>=20.19'} '@tanstack/query-core@5.101.0': @@ -1067,25 +1067,25 @@ packages: peerDependencies: react: ^18 || ^19 - '@tanstack/react-router@1.170.16': - resolution: {integrity: sha512-w6eq1IJklujs1tESazaK/FxH0+H2l8vm/QPuu1cD3oRW/ubgKneQpd7b64ti/8gUyEimzimJQZDmJr6YHfP5+g==} + '@tanstack/react-router@1.170.46': + resolution: {integrity: sha512-ez1iNIhsPjGlaDHg3BXWs67EWVIYzB2tbopEHYDESdkO7owgkGb5de52+5Kv2v1fxdkggcNzo35bdk4arTVGQw==} engines: {node: '>=20.19'} peerDependencies: react: '>=18.0.0 || >=19.0.0' react-dom: '>=18.0.0 || >=19.0.0' - '@tanstack/react-store@0.9.3': - resolution: {integrity: sha512-y2iHd/N9OkoQbFJLUX1T9vbc2O9tjH0pQRgTcx1/Nz4IlwLvkgpuglXUx+mXt0g5ZDFrEeDnONPqkbfxXJKwRg==} + '@tanstack/react-store@0.11.2': + resolution: {integrity: sha512-oj5O5DmiMWE+ih+SioX2ayC1kbK7d3fpLx0B75fPJr9nY3zU+hoW010yr64qXsY/9fyiLVE2bn5mGNV3owm8RQ==} peerDependencies: react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 - '@tanstack/router-core@1.171.13': - resolution: {integrity: sha512-+NOwEj1kO/6IGmpHRIZHasYxYWpyBQGNIZAST9aNrk9Q3YlU9SgqVnl1pbLa9qAKfeNdXQIRve0RQb/0kyDeDA==} + '@tanstack/router-core@1.171.39': + resolution: {integrity: sha512-qUhoJ0meuSUqGYQbHbcJYdASr06YtK+bulbj6vtrhKYFkLgkSsZ6tXmMyym7sFxiSJSPYgasgozrL01LyyR/6A==} engines: {node: '>=20.19'} - '@tanstack/store@0.9.3': - resolution: {integrity: sha512-8reSzl/qGWGGVKhBoxXPMWzATSbZLZFWhwBAFO9NAyp0TxzfBP0mIrGb8CP8KrQTmvzXlR/vFPPUrHTLBGyFyw==} + '@tanstack/store@0.11.2': + resolution: {integrity: sha512-sJ4mjol8uQsHV0gOJzzjwXfh2Fwm+Sz0+8deqiTm4jGbMdjzNSW+xZCFm0kUa870uhd8yi+DpKnZb5Kc4apa0Q==} '@testing-library/dom@10.4.1': resolution: {integrity: sha512-o4PXJQidqJl82ckFaXUeoAW+XysPLauYI43Abki5hABd853iMhitooc6znOnczgbTYmEP6U6/y1ZyKAIsvMKGg==} @@ -2028,15 +2028,15 @@ packages: engines: {node: '>=10'} hasBin: true - seroval-plugins@1.5.4: - resolution: {integrity: sha512-S0xQPhUTefAhNvNWFg0c1J8qJArHt5KdtJ/cFAofo06KD1MVSeFWyl4iiu+ApDIuw0WhjpOfCdgConOfAnLgkw==} - engines: {node: '>=10'} + seroval-plugins@1.7.8: + resolution: {integrity: sha512-SCfCNzJ8CEz3spf1jNd6XE7mrtrKMchVRMGLFNUEXjY0wIUhKl1bXhkNG3/i0X8uLCWLOhUdMjcM286JZqnCbg==} + engines: {node: '>=20'} peerDependencies: seroval: ^1.0 - seroval@1.5.4: - resolution: {integrity: sha512-46uFvgrXTVxZcUorgSSRZ4y+ieqLLQRMlG4bnCZKW3qI6BZm7Rg4ntMW4p1mILEEBZWrFlcpp0AyIIlM6jD9iw==} - engines: {node: '>=10'} + seroval@1.7.9: + resolution: {integrity: sha512-ocL7l8aqYWy/dXDHQF3Z8bt5R4Z9IBB4hASCkBDQhl3ZUclxVEzRMQNmRNshiEEIPF1g7uz+2nENDqg+9TU86A==} + engines: {node: '>=20'} set-cookie-parser@3.1.0: resolution: {integrity: sha512-kjnC1DXBHcxaOaOXBHBeRtltsDG2nUiUni+jP92M9gYdW12rsmx92UsfpH7o5tDRs7I1ZZPSQJQGv3UaRfCiuw==} @@ -2385,8 +2385,8 @@ packages: peerDependencies: zod: ^3.25.0 || ^4.0.0 - zod@4.4.3: - resolution: {integrity: sha512-ytENFjIJFl2UwYglde2jchW2Hwm4GJFLDiSXWdTrJQBIN9Fcyp7n4DhxJEiWNAJMV1/BqWfW/kkg71UDcHJyTQ==} + zod@4.6.7: + resolution: {integrity: sha512-g8W2D2kU6a8untc053fX1uVBKzM7yqAxW/3zwk83+6RyF2+SKOuV+c0wBDhUwzV1PaGapmZH+rmcUzPf+3CGwg==} snapshots: @@ -3219,7 +3219,7 @@ snapshots: tailwindcss: 4.3.1 vite: 8.0.16(@types/node@24.13.2)(jiti@2.7.0) - '@tanstack/history@1.162.0': {} + '@tanstack/history@1.162.5': {} '@tanstack/query-core@5.101.0': {} @@ -3228,30 +3228,30 @@ snapshots: '@tanstack/query-core': 5.101.0 react: 19.2.7 - '@tanstack/react-router@1.170.16(react-dom@19.2.7(react@19.2.7))(react@19.2.7)': + '@tanstack/react-router@1.170.46(react-dom@19.2.7(react@19.2.7))(react@19.2.7)': dependencies: - '@tanstack/history': 1.162.0 - '@tanstack/react-store': 0.9.3(react-dom@19.2.7(react@19.2.7))(react@19.2.7) - '@tanstack/router-core': 1.171.13 + '@tanstack/history': 1.162.5 + '@tanstack/react-store': 0.11.2(react-dom@19.2.7(react@19.2.7))(react@19.2.7) + '@tanstack/router-core': 1.171.39 isbot: 5.1.43 react: 19.2.7 react-dom: 19.2.7(react@19.2.7) - '@tanstack/react-store@0.9.3(react-dom@19.2.7(react@19.2.7))(react@19.2.7)': + '@tanstack/react-store@0.11.2(react-dom@19.2.7(react@19.2.7))(react@19.2.7)': dependencies: - '@tanstack/store': 0.9.3 + '@tanstack/store': 0.11.2 react: 19.2.7 react-dom: 19.2.7(react@19.2.7) use-sync-external-store: 1.6.0(react@19.2.7) - '@tanstack/router-core@1.171.13': + '@tanstack/router-core@1.171.39': dependencies: - '@tanstack/history': 1.162.0 + '@tanstack/history': 1.162.5 cookie-es: 3.1.1 - seroval: 1.5.4 - seroval-plugins: 1.5.4(seroval@1.5.4) + seroval: 1.7.9 + seroval-plugins: 1.7.8(seroval@1.7.9) - '@tanstack/store@0.9.3': {} + '@tanstack/store@0.11.2': {} '@testing-library/dom@10.4.1': dependencies: @@ -3645,8 +3645,8 @@ snapshots: '@babel/parser': 7.29.7 eslint: 10.5.0(jiti@2.7.0)(supports-color@8.1.1) hermes-parser: 0.25.1 - zod: 4.4.3 - zod-validation-error: 4.0.2(zod@4.4.3) + zod: 4.6.7 + zod-validation-error: 4.0.2(zod@4.6.7) transitivePeerDependencies: - supports-color @@ -4176,11 +4176,11 @@ snapshots: semver@7.8.4: {} - seroval-plugins@1.5.4(seroval@1.5.4): + seroval-plugins@1.7.8(seroval@1.7.9): dependencies: - seroval: 1.5.4 + seroval: 1.7.9 - seroval@1.5.4: {} + seroval@1.7.9: {} set-cookie-parser@3.1.0: {} @@ -4440,8 +4440,8 @@ snapshots: yocto-queue@0.1.0: {} - zod-validation-error@4.0.2(zod@4.4.3): + zod-validation-error@4.0.2(zod@4.6.7): dependencies: - zod: 4.4.3 + zod: 4.6.7 - zod@4.4.3: {} + zod@4.6.7: {} diff --git a/src/SlpModularCms.Core/SlpModularCms.Core.csproj b/src/SlpModularCms.Core/SlpModularCms.Core.csproj index b414c65..91bff4c 100644 --- a/src/SlpModularCms.Core/SlpModularCms.Core.csproj +++ b/src/SlpModularCms.Core/SlpModularCms.Core.csproj @@ -52,7 +52,7 @@ chains pass through. --> - + diff --git a/src/SlpModularCms.Modules.Availability.Tests/SlpModularCms.Modules.Availability.Tests.csproj b/src/SlpModularCms.Modules.Availability.Tests/SlpModularCms.Modules.Availability.Tests.csproj index b80f6ad..9767b63 100644 --- a/src/SlpModularCms.Modules.Availability.Tests/SlpModularCms.Modules.Availability.Tests.csproj +++ b/src/SlpModularCms.Modules.Availability.Tests/SlpModularCms.Modules.Availability.Tests.csproj @@ -12,7 +12,7 @@ - + diff --git a/src/SlpModularCms.Modules.Master.Tests/SlpModularCms.Modules.Master.Tests.csproj b/src/SlpModularCms.Modules.Master.Tests/SlpModularCms.Modules.Master.Tests.csproj index 6dcb747..2d167b1 100644 --- a/src/SlpModularCms.Modules.Master.Tests/SlpModularCms.Modules.Master.Tests.csproj +++ b/src/SlpModularCms.Modules.Master.Tests/SlpModularCms.Modules.Master.Tests.csproj @@ -12,7 +12,7 @@ - + diff --git a/src/SlpModularCms.Modules.Offerings.Tests/SlpModularCms.Modules.Offerings.Tests.csproj b/src/SlpModularCms.Modules.Offerings.Tests/SlpModularCms.Modules.Offerings.Tests.csproj index 869ebc3..83473b2 100644 --- a/src/SlpModularCms.Modules.Offerings.Tests/SlpModularCms.Modules.Offerings.Tests.csproj +++ b/src/SlpModularCms.Modules.Offerings.Tests/SlpModularCms.Modules.Offerings.Tests.csproj @@ -12,7 +12,7 @@ - +