Documenteer CI-proef run 606/607 en gevolgen van ASF_TEST_DEPLOY_ENABLED

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-08 01:20:58 +01:00
co-authored by Claude Sonnet 5.5
parent b60b3138ab
commit 91f14d5a52
4 changed files with 12 additions and 1 deletions
@@ -443,3 +443,8 @@
**Timestamp**: 2026-11-08
**User Input (via CMS & API)**: Monitoring Setup approved; go to Production Readiness (test only; list production items); do not push doc commits now; Sentry alert rules after the first successful deploy; Bryan starts the CI workflow_dispatch himself.
**AI Response**: No gaps requiring questions. Checklist generated; appsettings compliance passed. Overall Readiness (test): Yes with caveats; 8 open follow-ups. Feature remains open until CI proof and the first test deploy are reported.
## CI proof on the pushed branch
**Timestamp**: 2026-11-08
**Source**: Gitea API (runs 606, 607; dispatched by the CMS & API session on Bryan's behalf, deploy inputs false)
**AI Response**: Run 606 red on one SetupPage test (cold-start timing), run 607 on the same commit green: backend-test with MariaDB incl. Api.Tests and ASF HostPipelineTests, vulnerability-scan, frontend. No deploy job ran. `vars` in job-level `if:` confirmed working. Docs updated (handback-u2, deployment-instructions, production-readiness-checklist). Nothing pushed besides the branch earlier.
@@ -18,6 +18,7 @@ The 301 `Location` was built from the decoded path without re-encoding: `/a%3Fb/
## 4. Test results
- Green locally: Core 351, Identity 57, Availability 82, Master 57, Offerings 57, ASF host configuration 5, frontend 293 (Vitest), ESLint and `tsc -b` clean, frontend builds for default and `asf` verified.
- **Not run here (no MariaDB on this machine): `Api.Tests` and `Api.AndreaSlopFotografie.Tests/HostPipelineTests`.** The CI job `backend-test` starts MariaDB and runs them; the result will be reported after the first push and CI run.
- **CI proof (branch `feature/andreaslop-site-hosting`, head e37b8f3, `workflow_dispatch`, all deploy inputs false)**: run 606 failed on one frontend test (first test of `SetupPage.test`, lazy-route spinner still shown after 8 s on the slow runner; CI frontend-test takes ~290 s, also on master); run 607 on the same commit is **fully green**: backend-test with MariaDB (Api.Tests 4/4, ASF host tests 10/10 incl. HostPipelineTests, Core 351, Identity 57, Availability 82, Master 57, Offerings 57), vulnerability-scan, frontend build/test/lint. Conclusion: cold-start timing flake of the first lazy-loaded test, not a defect; hardening is optional. No deploy job ran (all publish/deploy jobs skipped). `config-asf` ran because `ASF_TEST_DEPLOY_ENABLED=true` was set, which shows that `vars` in a job-level `if:` works on this Gitea.
- Not yet observed, only possible on the first test deploy: forwarded headers and HTTP/1.0 behind the proxy Pi, `vars` in a job-level `if:` on this Gitea, per-request file lookup timing on the Pi.
## 5. Information, no action needed
@@ -12,6 +12,11 @@ Verify prerequisites, create database/user, directories + symlink `shared/wwwroo
## 2. Cut over (phase B, accepted short test downtime)
Save the current proxy block; verify the three forwarded headers are present; change only `proxy_pass` to `http://192.168.1.103:5200`; test config; reload. Set `ASF_TEST_DEPLOY_ENABLED=true`; push to master or run the workflow manually with "Deploy ASF test".
## 2b. Consequences of the switch being `true` (verified on Gitea, run 606/607)
- `vars.ASF_TEST_DEPLOY_ENABLED == 'true'` in a job-level `if:` works on this Gitea (`config-asf` ran with the variable set).
- With the variable `true`, **a push or merge to master now deploys ASF test** (besides SlpSoftware test).
- The first ASF deploy does **not** need a merge: run "Continuous Integration" manually on the branch `feature/andreaslop-site-hosting` with only "Deploy ASF test" ticked (`deploy-asf-test` accepts any ref on dispatch). A dispatch with all boxes unticked builds and tests only (runs 606/607) and deploys nothing.
## 3. What a deploy does (every time)
Build admin (`VITE_THEME=asf`, Dutch default) -> publish linux-arm64 -> upload to `releases/<timestamp>` -> link `wwwroot/web` to `shared/wwwroot-web` -> atomic switch of `current` -> `systemctl --user restart` -> `/health` on the public URL (10 tries) -> prune to current + previous.
@@ -26,7 +26,7 @@ Scope: the TEST environment `test.andreaslop.nl`. Production is out of scope; it
## Overall Readiness
- **Ready for Production**: Not applicable to production. For TEST: Yes with caveats (below).
- **Open Follow-ups**:
1. CI proof pending: Bryan starts `workflow_dispatch` on the branch (deploy boxes unticked); `backend-test` (MariaDB: `Api.Tests`, ASF `HostPipelineTests`), frontend and vulnerability scan must be green.
1. CI proof: DONE. Run 607 (branch, head e37b8f3, dispatch, no deploy) is fully green incl. backend-test with MariaDB (`Api.Tests`, ASF `HostPipelineTests`), frontend and vulnerability scan. Run 606 had one cold-start timing failure in the first `SetupPage` test (flake, same commit passed in 607). Optional: harden that test.
2. First test deploy not done (needs the explicit go from CMS & API/Bryan; Pi preparation reported done, proxy route already switched, `ASF_TEST_DEPLOY_ENABLED` unset).
3. After the first deploy: verification list (manual steps 14-18), forwarded-header observation, optional Pi timing, remove the setup token, report in the hand-back.
4. Sentry alert rules to be created after the first successful deploy (by the CMS & API session, with Bryan's go).