B-secties: nav, hero, Over, Werkwijze, contactblok en footer volgens ontwerp B
Nieuwe tokens (brand, inv, panel, field, prog, body), Archivo als lettertype (Sora en Instrument Sans verwijderd), witte toggles op het rode kopblok, en tests voor structuur, landmarks en contrast in alle vier de thema's. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -5,7 +5,7 @@
|
||||
- **Feature Slug**: redesign-modern-timetravel
|
||||
- **Project Type**: Brownfield
|
||||
- **Start Date**: 2026-11-09T13:00:00Z
|
||||
- **Current Stage**: CONSTRUCTION - U1 theme-foundation Code Generation (in progress)
|
||||
- **Current Stage**: CONSTRUCTION - U2 b-modern-sections Code Generation (in progress)
|
||||
- **Branch**: feature/redesign-modern-timetravel
|
||||
|
||||
## Workspace State
|
||||
|
||||
@@ -514,3 +514,75 @@
|
||||
**Context**: Leading the builder. Summary file to be read when preparing the frontend handoff (U4).
|
||||
|
||||
---
|
||||
|
||||
## U1 Code Generation Complete
|
||||
|
||||
**Timestamp**: 2026-11-10T06:30:00Z
|
||||
|
||||
**User Input**: "Akkoord op jouw bouwplan"
|
||||
|
||||
**AI Response**: "Executed all 13 steps of theme-foundation-code-generation-plan.md. Baseline 6 files / 24 tests; after: 10 files / 56 tests passed, lint 0 errors (2 pre-existing warnings), pnpm build OK, E as separate lazy chunk. Docs commit 1047c73 and code commit made on feature/redesign-modern-timetravel; no push. Prettier run on touched folders reformatted two unrelated files (Footer.tsx, routes/index.tsx), reverted. Summary at construction/theme-foundation/code/summary.md. Completion message presented; awaiting approval."
|
||||
|
||||
**Context**: Code Generation U1 complete (Step 13.5 verified).
|
||||
|
||||
---
|
||||
|
||||
## Builder CMS-U3b Accepted
|
||||
|
||||
**Timestamp**: 2026-11-10T06:50:00Z
|
||||
|
||||
**User Input**: "(cross-session message from SLS Software - CMS: CMS-U3b openapi-export done, commit 0813656)"
|
||||
|
||||
**AI Response**: "Accepted on the builder's report: committed openapi/slpsoftware.v1.json (no hosts/addresses/secrets), snapshot test with UPDATE_OPENAPI=1 regeneration and drift detection verified by changing one value, contact contract details in the document (reusable Validation/TooLarge/RateLimited, Idempotency-Key header, required fields and maxLength, 404 form closed). Findings: controller without [ApiController] needs ApiExplorerSettings(IgnoreApi=false); class-wide Produces overwrote problem+json (caught by own test, removed). Contact.Tests 117, Core 205, Availability 95, Offerings 86, Identity 37, Master 57, Api 4 passed. Contract status line updated. Builder continues with CMS-U4."
|
||||
|
||||
**Context**: Leading the builder.
|
||||
|
||||
---
|
||||
|
||||
## Resume After Credits Top-up
|
||||
|
||||
**Timestamp**: 2026-11-10T07:30:00Z
|
||||
|
||||
**User Input**: "Credits zijn aangevuld kan je kijken of de andere sessie of jij iets moeten hervatten"
|
||||
|
||||
**AI Response**: "Checked sessions and worktree. SLS Software - CMS [9d882f] is idle with unfinished CMS-U4 work in its worktree (uncommitted admin API, settings, gates, migration AddContactSettings, tests, plus a stray Scratch.cs); sent a resume instruction (verify state, remove Scratch.cs, finish per plan, report). CMS & API [df4818] is busy with its own work. This session: U1 code committed (0854e3a), waiting for the user's approval before U2; no unfinished work on this side."
|
||||
|
||||
**Context**: Coordination.
|
||||
|
||||
---
|
||||
|
||||
## Builder CMS-U4 Accepted; Phase 1 Complete
|
||||
|
||||
**Timestamp**: 2026-11-10T08:10:00Z
|
||||
|
||||
**User Input**: "(cross-session message from SLS Software - CMS: CMS-U4 contact-admin-api done, commit 44f161a)"
|
||||
|
||||
**AI Response**: "Accepted on the builder's report: seven AdminOnly routes (list, detail, patch, delete, resend, GET/PUT contact-settings), two-layer gate (host flag first, CMS switch cached 5 s, default off), migration AddContactSettings, OpenAPI snapshot regenerated. Real bug caught by the pipeline test (statuses.Contains query -> 500) fixed. Tests: Contact 223, Core 205, Availability 95, Offerings 86, Identity 37, Master 57, Api 4 passed. Deviation from plan accepted: with the CMS disabled (availability) a verified Owner/Administrator still passes the gate (existing gate design); others get 503. No data lost by the interruption; container removed. CMS phase 1 (U0, U1, U1b, U2, U3, U3b, U4) done; phase 2 (U5 mail+retry, U6 admin UI, U7 availability PUT) waits for Bryan's decision on merging feature/identity-email-notifications. Builder on stand-by; asked for a consolidated phase-1 handoff file."
|
||||
|
||||
**Context**: Leading the builder. Open for Bryan: merge decision of the ASF branch; whether the CMS branch feature/contact-forms-module is pushed for a test deploy.
|
||||
|
||||
---
|
||||
|
||||
## U1 Approved; U2 Code Generation Plan Ready
|
||||
|
||||
**Timestamp**: 2026-11-10T09:00:00Z
|
||||
|
||||
**User Input**: "Jij kan verder naar u2. De cms moet nog even wachten"
|
||||
|
||||
**AI Response**: "U1 treated as approved (user said to continue to U2); CMS phase 2 stays on hold. U2 (b-modern-sections) skips Functional Design/NFR/Infrastructure per the execution plan because the design exists in the canvas. Read the canvas file Modern.dc.html and created construction/plans/b-modern-sections-code-generation-plan.md (9 steps). Key points: new brand/inv/panel/field/prog/body tokens, Archivo for all text (Sora and Instrument Sans removed), text stays from content.ts with only structural content additions, display headline from the design flagged, mobile menu kept, contact panel shows mailto until U4, packages untouched until U3. Plan approval prompt presented."
|
||||
|
||||
**Context**: Code Generation Part 1 (planning) for U2.
|
||||
|
||||
---
|
||||
|
||||
## U2 Plan Approved; ASF Branch Merge Authorized
|
||||
|
||||
**Timestamp**: 2026-11-10T09:30:00Z
|
||||
|
||||
**User Input**: "Approve plan. K denk dat de cms sessie ook wel kan mergen. De grootste changes zijn al gedaan en de rest kan wel later worden gemerged vanaf master"
|
||||
|
||||
**AI Response**: "U2 Code Generation plan approved; starting Part 2. Interpreted 'de cms sessie kan mergen' as: the ASF CMS session (AndreaSlopFotografie, owner of feature/identity-email-notifications) may merge that branch into SlpModularCms master; relayed as Bryan's decision, asked it to merge by its normal process, report the merge commit and expected conflicts to this session and to the builder, and to flag any concrete risk first. Builder (SLS Software - CMS) told to wait for the merge message, then rebase feature/contact-forms-module on master (no push), switch ContactRateLimitPartition to ClientPartitionKey if present, run all tests, and send the rebase result plus plans for CMS-U5, U6, U7 for approval. Contact:Enabled stays off; nothing deployed or pushed."
|
||||
|
||||
**Context**: CMS phase 2 unblocked pending the merge; U2 Code Generation starts.
|
||||
|
||||
---
|
||||
|
||||
+28
@@ -0,0 +1,28 @@
|
||||
# Code Summary — b-modern-sections (U2)
|
||||
|
||||
## What was built (design B, light and dark)
|
||||
- **Tokens**: seven new semantic tokens in all four variant×mode sets (`brand`, `on-brand`, `body`, `inv`, `panel`, `field`, `prog`) plus Tailwind names; the constant brand red `#7A1414` (E: `#AC0000`) is used for hero, contact and featured elements in both modes, as in the canvas. Archivo Variable is now the face for `sans` and `display`; Sora and Instrument Sans (fonts and npm packages) are removed; JetBrains Mono stays for the code strip.
|
||||
- **Header/nav** (`Nav.tsx`): brand block, not sticky, white text, white CTA block "Start project", both round toggles in the white `onBrand` tone (`toggleTone.ts`), mobile hamburger menu kept; `<nav aria-label="Hoofdnavigatie">` inside a `<header>`; no years in the menu.
|
||||
- **Hero** (`Hero.tsx`): display headline "Websites, / apps / & meer." (`heroContent.displayHeading`, screen readers read the live heading via `aria-label`), lead from `content.ts`, buttons to `#pakketten` and `#contact`, black code strip with blinking caret and the eyebrow "Web & .NET development".
|
||||
- **Over** (`AboutSection.tsx`): offset brand block behind a 3:4 photo (existing WebP/JPG variants), heading "Eén ontwikkelaar, korte lijnen", paragraphs from `content.ts`, three facts (`aboutFacts`).
|
||||
- **Werkwijze** (`ProcessSection.tsx`, `ProcessStep.tsx`): black section, ordered list of three steps with progress bar (33/66/100 %), outlined numbers (decorative), phase, title and text from `content.ts` (`phase` added).
|
||||
- **Contact frame** (`ContactSection.tsx`): brand block, display heading "Klaar om / te bouwen?", intro, mail link and a panel that holds the mailto call-to-action until the form (U4).
|
||||
- **Footer**: black strip. **Layout**: `<header><Nav/></header>`, `<main id="main">`, footer; base text 17px/1.55.
|
||||
- **Content additions** (`content.ts`): `heroContent.displayHeading`, `processSteps[].phase`, `aboutFacts`, `contactInfo.displayHeading`. Existing copy unchanged.
|
||||
|
||||
## Verification (Step 13.5, real output)
|
||||
- Baseline of this unit (after U1): 10 files / 56 tests. After: **13 files / 122 tests passed**, `pnpm lint` 0 errors (same 2 existing warnings), `pnpm build` OK (main bundle 447 kB JS, 57 kB CSS; E chunk 0.9 kB; no Sora/Instrument files in `dist`; the new utilities `font-stretch`, `bg-brand`, `bg-inv`, `text-on-brand`, `bg-panel`, text-stroke are generated).
|
||||
- New tests: WCAG contrast (text/body/muted/accent/on-brand/panel/field pairs ≥ 4.5:1) for all four token sets, parsed from `index.css`; section tests (headline parts, content text, links, anchors, facts, progress bars, panel button, footer); layout landmark test (banner with named navigation, one `main#main`, contentinfo, order, onBrand toggles, live region); updated nav tests.
|
||||
|
||||
## Deviations and notes for review
|
||||
- **Hero headline**: the design's display headline replaces the visible "SLP software: websites, apps & meer"; the accessible name is still the live headline. To revert: render `heroContent.heading` instead of `displayHeading` in `Hero.tsx`.
|
||||
- **Texts**: the live copy (`content.ts`, "wij bouwen ...") wins over the canvas wording ("ik bouw ..."). The contact panel intro sentence ("Stuur een bericht met je idee of vraag...") is new filler text for the panel until U4 replaces it with the form.
|
||||
- **Packages block** (U3) is untouched and keeps the old card styling for now; it inherits the new tokens and the Archivo font.
|
||||
- **Nav** is not sticky (as in the design); the old `scroll-mt-16` offsets on the packages eyebrow are harmless.
|
||||
- **No browser screenshots** were possible here; visual fidelity (spacing, photo crop at 3:4 with `object-position 50% 30%`, dark mode look) needs a review in the browser.
|
||||
- Lockfile contains the same peer-suffix churn as in U1 plus the removal of the two font packages.
|
||||
|
||||
## Hand-offs
|
||||
- U3: replace `PackagesSection` (B styling, filter chips, swipe row); the section anchor `#pakketten` currently sits on its eyebrow `span`.
|
||||
- U4: replace the panel content in `ContactSection` with the form; keep `data-testid="contact-panel"` and the `#contact` anchor.
|
||||
- U5: reuse `toggleTone` for E where needed.
|
||||
+44
@@ -0,0 +1,44 @@
|
||||
# Code Generation Plan — b-modern-sections (U2)
|
||||
|
||||
Single source of truth for U2 Code Generation. Inputs: `unit-of-work.md` (U2), requirements FR-1, NFR-1, NFR-2, execution plan (Functional Design, NFR and Infrastructure skipped for U2: the design exists in the Claude Design canvas, `Modern.dc.html` = B), U1 summary (`construction/theme-foundation/code/summary.md`).
|
||||
|
||||
## Unit context
|
||||
- **Scope**: nav, hero, Over, Werkwijze, footer and the frame of the contact block in design B, light and dark, responsive 360px–1440px+. **Not in U2**: the packages block (U3: the existing `PackagesSection` stays as is, only inheriting tokens and font) and the contact form (U4: the panel inside the contact block shows the existing mailto call-to-action until then).
|
||||
- **Workspace root**: `K:\Development\SlpSoftware\Projects\SlpSoftware`; modify in place. Branch `feature/redesign-modern-timetravel`; one commit for U2; no push.
|
||||
- **Dependencies**: U1 (variant × mode tokens, toggles). **Blocks**: U3, U4 (frames).
|
||||
- **Requirement mapping**: FR-1 (design B), NFR-1 (WCAG AA, landmarks, focus, reduced motion), NFR-2 (responsive), NFR-7.
|
||||
|
||||
## Design decisions taken from the canvas (and where content stays leading)
|
||||
- **Layout/typography** as in `Modern.dc.html`: Archivo Variable with width axis (`font-stretch` 112–125%, weights 800–900), max width 1280px, section paddings 128–152px (smaller on mobile), square corners (no rounded cards), flat colour blocks.
|
||||
- **Colour blocks**: hero and contact sit on the constant brand red `#7A1414` in light *and* dark mode (as in the canvas), black strips (`inv`) for the code line, Werkwijze and footer. New semantic tokens (all four variant×mode sets): `--color-brand`, `--color-on-brand`, `--color-body`, `--color-inv`, `--color-panel`, `--color-field`, `--color-prog`; Tailwind names `brand`, `on-brand`, `body`, `inv`, `panel`, `field`, `prog`. E gets matching values (`brand #AC0000`).
|
||||
- **Text stays leading** (decision in requirements): body texts come from `content.ts` (the November text update). Where the design shows a different wording ("Maatwerk van SLP Software ... ik bouw het allemaal" vs the live "wij bouwen"), the live copy wins. Only structural additions are new content fields: `heroContent.displayHeading = ['Websites,', 'apps', '& meer.']` (display headline from the design; the live eyebrow "Web & .NET development" moves to the code strip), `aboutFacts` (3 facts: Direct contact / Eén werkdag / Vaste prijs, from the design), `processSteps[].phase` (Intake / Bouwen / Live), `contactInfo.displayHeading = ['Klaar om', 'te bouwen?']`.
|
||||
- **Nav**: part of the hero header (not sticky, as in the design), white text on brand; the CTA "Start project" as white block; both toggles as white outlined circles (`tone="onBrand"` prop). The existing mobile menu (hamburger) is kept for small screens (better than wrapping links); years are not in the menu.
|
||||
- **Over**: rectangular 3:4 photo with the offset brand block (real photo with the existing WebP/JPG variants), h2, two paragraphs, three-fact list.
|
||||
- **Werkwijze**: black section, three steps with progress bar (33/66/100%), large outlined numbers (`-webkit-text-stroke`), phase, title, text; fixed `<ol>`.
|
||||
- **Contact frame**: brand block, display heading, intro, mailto link, and a panel (`panel` colour) that contains the mailto button for now; U4 replaces the panel content with the form.
|
||||
- **Reduced motion**: caret animation off (existing rule), no hover motion that moves layout.
|
||||
|
||||
## Steps
|
||||
- [x] **Step 1 — Tokens**: extend `src/index.css` (four sets) and `tailwind.config.ts` (colors, `fontFamily.sans`/`display` → Archivo Variable, keep `mono`); remove the Sora and Instrument Sans imports from `src/fonts.ts` and the two packages from `package.json` (`pnpm remove`), keep JetBrains Mono and Archivo. Check contrast pairs in a small test (ratios computed from the token values: text/bg, muted/bg, on-brand/brand, accent/bg in both modes ≥ 4.5:1; large text ≥ 3:1).
|
||||
- [x] **Step 2 — Content**: add the structural fields to `src/features/landing/data/content.ts` (types + values), without changing existing copy.
|
||||
- [x] **Step 3 — Toggles**: add a `tone?: 'default' | 'onBrand'` prop to `ModeToggle` and `VariantToggle` (white outline/text variant for use on the brand block); defaults unchanged.
|
||||
- [x] **Step 4 — Shell**: rewrite `Nav.tsx` (header band with nav; mobile menu kept; anchors without years), `Hero.tsx` (display headline, lead, two buttons, black code strip with caret), `Footer.tsx` (black strip); `RootLayout.tsx` places the hero header (nav + hero) inside the B shell as designed (Nav is rendered by `Hero`'s header wrapper or as sibling with the same brand background: decided in code, tested by landmarks).
|
||||
- [x] **Step 5 — Sections**: rewrite `AboutSection.tsx`, `ProcessSection.tsx`, `ProcessStep.tsx`, `ContactSection.tsx` as described; `PackagesSection.tsx` untouched except removing classes that no longer exist if any (verify visually via tests only).
|
||||
- [x] **Step 6 — Tests**: Vitest + Testing Library: nav (links without years, CTA, both toggles with onBrand styling, mobile menu), hero (headline parts, lead from content, code line, buttons link to `#pakketten` and `#contact`), about (heading, paragraphs from content, three facts, photo alt), process (ordered list of three steps, progress bars, numbers aria-hidden, phase/title/text), contact frame (heading parts, mailto link, panel with the mailto button), footer; landmarks (`header`, `nav aria-label`, `main`, `footer`, one `h1`, heading order), contrast test from Step 1. Update `Nav.test.tsx`.
|
||||
- [x] **Step 7 — Build and test (automatic, Step 13.5)**: `pnpm lint`, `pnpm test`, `pnpm build`; fix and retry until green; report real counts. No manual browser check can be done by the AI in this environment; screenshots/visual check by the user at review time.
|
||||
- [x] **Step 8 — Docs**: `construction/b-modern-sections/code/summary.md` (files, decisions, copy deviations from the canvas, hand-offs for U3/U4/U5).
|
||||
- [x] **Step 9 — Commit**: one commit (Dutch message, `Co-Authored-By`), no push.
|
||||
|
||||
## Files (M modify, C create, D delete)
|
||||
M `src/index.css`, `tailwind.config.ts`, `src/fonts.ts`, `package.json`, `pnpm-lock.yaml`, `src/features/landing/data/content.ts`, `src/components/ui/{ModeToggle,VariantToggle}.tsx`, `src/components/layout/{Nav,Footer,RootLayout}.tsx`, `src/features/landing/components/{Hero,AboutSection,ProcessSection,ProcessStep,ContactSection}.tsx`, tests; C `src/test/contrast.ts` (helper) and new test files under the touched folders; D none.
|
||||
|
||||
## Explicitly NOT touched in U2
|
||||
`PackagesSection`, `PackageCard`, `PackageCardSkeleton`, `usePackagesQuery` (U3); the contact form and `cms-client` (U4); anything in `src/variants/e` beyond using the toggles (U5); router, Sentry, Umami.
|
||||
|
||||
## Risks
|
||||
- The canvas hero headline ("Websites, apps & meer.") differs from the live H1 ("SLP software: websites, apps & meer"); treated as a display headline decision of the design, flagged in the summary so the user can revert it in one line.
|
||||
- The package block keeps its old look until U3 and may look out of place between the new sections; accepted because units are not deployed separately.
|
||||
- Visual fidelity cannot be screenshot-verified by the AI here; tests cover structure, text, links, landmarks and contrast.
|
||||
|
||||
## Traceability
|
||||
FR-1, NFR-1, NFR-2, NFR-7; canvas `Modern.dc.html` (+ `ModernDark`); U1 token model; Security Baseline: no new external requests (fonts self-hosted), no inline scripts.
|
||||
+1
-1
@@ -2,7 +2,7 @@
|
||||
|
||||
**Version**: 0.3.1-draft (2026-11-09) — incorporates the reviews of `SLS Software - CMS` (API side), `CMS & API` (ASF website) and `AndreaSlopFotografie` (ASF CMS/hosting) and the product decisions of Bryan (admin view in scope, spam stored as `spam`, captcha fail-open).
|
||||
**Status**: DRAFT for confirmation by the builders. Product decisions still open are marked **[Bryan]** (see § 10).
|
||||
**Source of truth** once agreed: the OpenAPI document generated by the CMS (`AddOpenApi`/`MapOpenApi`), exported as a **committed artifact** in SlpModularCms so `cms-client` can generate types from it. This file carries the behaviour agreements and the intended shape.
|
||||
**Source of truth** once agreed: the OpenAPI document generated by the CMS (`AddOpenApi`/`MapOpenApi`), exported as a **committed artifact** in SlpModularCms so `cms-client` can generate types from it. **Status (CMS-U3b, commit 0813656):** the file for the SlpSoftware host is `openapi/slpsoftware.v1.json` (the Andrea host later gets `openapi/andreaslopfotografie.v1.json`); regenerate with `UPDATE_OPENAPI=1 dotnet test --filter OpenApiSnapshot` (needs the test database); without that variable the same test fails when the document served by the real host differs from the file. The document has no hosts, addresses or secrets and documents `404` as "form closed" on both public contact routes. This file carries the behaviour agreements and the intended shape.
|
||||
**Compatibility**: breaking changes → `/api/v2`; additive changes allowed within `/api/v1`. The frontend package `cms-client` follows semver.
|
||||
|
||||
## 1. Scope
|
||||
|
||||
Reference in New Issue
Block a user