Continuous Integration / check (pull_request) Successful in 2m20s
Continuous Integration / build-test (pull_request) Skipped
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / lighthouse (pull_request) Successful in 8m55s
Continuous Integration / deploy-production (pull_request) Skipped
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
23 lines
1.9 KiB
Markdown
23 lines
1.9 KiB
Markdown
# Build and Test summary: hero-module (ASF side)
|
|
|
|
## What was built
|
|
|
|
- `src/lib/hero.ts` (mapping and validation of `/api/v1/hero`), `src/lib/heroHtml.ts` (HTML between the markers and the preload links), golden files shared with SMC in `web/contract/host-injection/hero/`.
|
|
- `config/heroPreload.ts` adds the HERO-PRELOAD region to the head of the finished HTML; `config/hostInjector.ts`, `normalizeInjected.ts` and `previewServer.ts` know the hero (stand-in host, `/api/v1/hero` answers 204).
|
|
- `src/components/Hero/`: `useHero` (host block, else `/api/v1/hero`, else baked), `Hero.tsx` (the region div is never replaced; the slider adds slides 2..n, scrim, arrows, pause, progress and announcement after hydration), `HeroButton`, `HeroArrows`, `HeroPauseButton`.
|
|
- Baked hero in `src/content/heroContent.ts` (8 photos, real sizes, focus estimates); texts in `nl.json` block `hero`.
|
|
|
|
## Verification
|
|
|
|
- Unit and property tests: 100% thresholds on `src/lib/**`, `src/i18n/**`, `seo.ts`, `sitemap.ts` hold; golden files match for all hero inputs.
|
|
- e2e (`pnpm e2e`): host injection with the hero (3 tests), no-JS, display HTML (priority image), reveal. The two frame-sampling reveal tests got retries (2 on CI, 1 locally) after a flaky failure in run #110 on a page without a hero.
|
|
- Lighthouse (local, noisy machine): the LCP element of the home page is the h1 on master and on this branch; master 0.71, branch 0.69-0.70. Keeping the region after hydration (commit 3d7bb2d) removed the late LCP the first design had.
|
|
- Visual check against the slider at 1280 and 390 px.
|
|
- Final run before merge: see the audit trail of the closing commit; lint, format, tests, build and e2e were run as CI runs them.
|
|
|
|
## Not verified here (needs the CMS or Bryan)
|
|
|
|
- The real host output on ASF-test after the seed (SMC verified it byte-equal to the golden files locally).
|
|
- LCP measurement on ASF-test (SMC, after the seed).
|
|
- IIS pass-through and a production CMS for ASF: later, separate feature.
|