Workspace detection, reverse engineering of web/, requirements with answered verification questions, the execution plan and the open application design questions for the frontend-shell feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
27 lines
1.7 KiB
Markdown
27 lines
1.7 KiB
Markdown
# Code Quality Assessment
|
|
|
|
## Test Coverage
|
|
- **Overall**: None
|
|
- **Unit Tests**: None (no test runner installed)
|
|
- **Integration Tests**: None
|
|
- Verification so far is `tsc` type-checking during `pnpm build` and manual browser checks
|
|
|
|
## Code Quality Indicators
|
|
- **Linting**: Not configured (TypeScript `noUnused*` flags only)
|
|
- **Code Style**: Mostly consistent (Prettier: 4 spaces, single quotes). Exception: `routes/over-mij.tsx` uses double quotes and 2-space indent
|
|
- **Documentation**: Good inline comments in Dutch explaining intent; README is a stub
|
|
|
|
## Technical Debt
|
|
- `theme.ts` `globalCss.body.height: '250vh'` — temporary scroll-testing hack; forces every page to be 2.5 screens tall
|
|
- `components/Footer.tsx` and `routes/over-mij.tsx` use Tailwind-style `className`s (`p-2`, `text-sm`, …) that do nothing — Tailwind is not installed
|
|
- `AppShell` has no `<main>` landmark; static design has a skip link targeting `#main`
|
|
- Header logo is not a link to the homepage (design: link with aria-label)
|
|
- Social links are defined inside `Hero/heroContent.ts`; the footer in the design needs the same links → candidate for shared site-level content
|
|
- `NavigationBar.tsx` uses `let [open, setOpen]` (should be `const`)
|
|
- Unused Vite starter assets: `assets/hero.png`, `assets/typescript.svg`, `assets/vite.svg`
|
|
- Design asset `footer-mark.png` (footer logo) not yet present in `web/src/assets`
|
|
|
|
## Patterns and Anti-patterns
|
|
- **Good Patterns**: design tokens as single source of truth; API-shaped static content; accessible interactions (aria labels, Escape to close, reduced motion, focus-visible handling); shared `navItems` for desktop and mobile
|
|
- **Anti-patterns**: no-op `className` usage (see above); global body height hack
|