Files
AndreaSlopFotografie/aidlc-docs/features/over-mij-page/construction/build-and-test/build-and-test-summary.md
T
SluijsensandClaude Opus 5.5 7a56a4783a
Continuous Integration / deploy-test (pull_request) Canceled after 0s
Continuous Integration / lighthouse (pull_request) Canceled after 0s
Continuous Integration / deploy-production (pull_request) Canceled after 0s
Continuous Integration / check (pull_request) Canceled after 5m57s
Records Build and Test of the Over mij page and completes the feature
Full pnpm check at ae769cb passed and 24 browser checks against the
production build passed. Adds the build and test instructions and
summary, marks the feature complete and logs the session in the audit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 21:50:59 +02:00

49 lines
3.0 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# Build and Test Summary — over-mij-page
Tested commit: `ae769cb` (unit 1 shared blocks + unit 2 Over mij page), locally on Windows, 2026-10-24.
## Build
- **Tool**: pnpm + Vite (`tsc && vite build`)
- **Status**: ✅ Success (3.5 s locally). CI run 564 on the same code (e152153): `check`, `deploy-test` and `lighthouse` ✅
- **Artifacts**: `web/dist/`
## Unit tests
- **Total**: 273 in 60 files. **Passed**: 273. **Failed**: 0.
- **Coverage**: thresholds met; overall 92% of statements
- **Status**: ✅ Pass
## Integration (browser, production build)
24 checks across the 8 scenarios in `integration-test-instructions.md`, all ✅:
| Scenario | Result |
|---|---|
| "neem contact op" / "Boek je shoot" → homepage Contact, 1440 and 390 px | ✅ Contact top = header bottom (68 / 66 px) |
| Homepage "Lees meer" / "Lees mijn verhaal" → `/over-mij` | ✅ top of page, h1 and title correct |
| Heading outline and section names | ✅ |
| JSON-LD AboutPage ↔ Person ↔ business, head tags | ✅ |
| No e-mail in served HTML or JSON-LD | ✅ |
| Layout shift while scrolling, photos loaded | ✅ CLS 0.0006 (1440) / 0 (390) |
| No horizontal overflow, 2 pages × 5 widths | ✅ |
| Keyboard focus on the links and the button | ✅ button 53 px high |
### Found in this stage
- **The e-mail scenario first failed, but the test was wrong, not the page.** The check scanned the rendered DOM and found `info@andreaslop.nl` in the footer. The footer assembles that address in the browser on purpose and has done so since frontend-shell. The real rule is that the address is not in the served HTML or in the structured data, and that check passes. NFR-OM-04 says "no e-mail address in markup". It means the served markup, not the footer that is rendered in the browser.
## Performance (Lighthouse CI, production build)
| Page | Mobile | Desktop |
|---|---|---|
| Homepage | 0.82 (budget 0.8) | 1.0 |
| Over mij | 0.90 (budget 0.9), LCP 3.2 s | 1.0 |
| Other pages | 0.94–0.95 (budget 0.9) | 1.0 |
Accessibility and best practices are 1.0 on every page. SEO is 1.0 on the indexed pages (`/`, `/over-mij`); the noindex pages only miss `is-crawlable`, as intended. The `/over-mij` mobile score is exactly at its budget; see `performance-test-instructions.md` for where the LCP goes.
## Additional
- **Security**: `pnpm audit --prod --audit-level high` clean. The full `pnpm audit` reports 17 issues (8 high), all in development tools (`@lhci/cli`, `vitest`'s own `vite`, `@chakra-ui/cli`). They do not reach the site and do not block (NFR-SEC-05). This feature adds no dependencies, so the list is the same as on master. No new external resources; CSP unchanged.
- **Contract / E2E suite**: N/A (static front end without an API). The browser checks above cover the user flows.
## Overall
- **Build**: ✅ **Tests**: ✅ **Performance budgets**: ✅
- **Test environment**: test.andreaslop.nl runs this code (run 564) and was reviewed and approved by the owner
- **Operations phase**: declined at Requirements Analysis. The next step is the PR to master.