Files
AndreaSlopFotografie/aidlc-docs/features/portfolio-page/aidlc-state.md
T
SluijsensandClaude Opus 5.5 18bf0311ef Adds the shared gallery building blocks
A masonry photo grid that keeps the reading order (pure CSS, no measuring
in the browser), an accessible lightbox on Chakra's Dialog with wrap-around
browsing, keys, swipe and preloading, and a filter bar of toggle buttons.
They work on generic gallery items, so other pages can use them. The swipe
logic moves out of the hero into a shared hook; the hero behaves as before.
The rules behind them live in pure helpers with property-based tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 23:22:43 +01:00

11 KiB
Raw Blame History

AI-DLC State Tracking

Project Information

  • Feature Name: Portfolio page (/portfolio)
  • Feature Slug: portfolio-page
  • Project Type: Brownfield
  • Start Date: 2026-10-24T19:30:00Z
  • Current Stage: CONSTRUCTION - Code Generation (Unit 2 Gallery building blocks, generated, awaiting approval)
  • Branch: feature/portfolio-page (rebased onto master 1bf28cb after contact-page PR #10)
  • Worktree: K:\Development\SlpSoftware\Projects\AndreaSlopFotografie-portfolio

Workspace State

  • Existing Code: Yes
  • Programming Languages: TypeScript (React/TSX)
  • Build System: pnpm + Vite (tsc && vite build), Gitea Actions CI
  • Project Structure: Single front-end SPA in web/; static HTML design reference in design/andreaslop-static/; api/ folder present but empty (.NET back-end planned)
  • Reverse Engineering Needed: No (artifacts current with the over-mij blocks; team agreement: no full refresh, each feature updates only its own lines)
  • Workspace Root: K:\Development\SlpSoftware\Projects\AndreaSlopFotografie

Code Location Rules

  • Application Code: Workspace root (NEVER in aidlc-docs/) — front-end lives in web/
  • Feature Documentation: aidlc-docs/features/portfolio-page/ only
  • Shared Artifacts: aidlc-docs/_shared/
  • Structure patterns: See code-generation.md Critical Rules

Language Configuration

  • Documentation Language: English
  • Conversation Language: User Language (Dutch)
  • Source: inherited from aidlc-docs/language-preference.md (answer A); user may override

Extension Configuration

Extension Enabled Decided At
Security Baseline Yes Requirements Analysis
Property-Based Testing Yes (full enforcement) Requirements Analysis

Operations Configuration

  • Include Operations Phase: No
  • Decided At: Requirements Analysis

Execution Plan Summary

  • Stages to Execute: Application Design (standard), Functional Design (units 2 and 3), Code Generation (3 units), Build and Test
  • Stages to Skip: Reverse Engineering (team agreement), User Stories (single persona, concrete FRs), Units Generation (split fixed in the execution plan), Functional Design for unit 1 (behaviour-preserving move), NFR Requirements and NFR Design (NFRs set at requirements level), Infrastructure Design (static assets only), Operations (decided No)
  • Units: 1 Shared Instagram block → 2 Gallery building blocks → 3 Portfolio page (needs the webPage() and shootTypes.ts peer commits)
  • Delivery: branch feature/portfolio-page, commits per unit, full pnpm check (incl. Lighthouse) per unit, one PR at the end

Parallel Work Agreements

Parallel features, each in its own worktree (originally stacked on feature/over-mij-page, merged to master as 11a5224): contact-page (✅ merged as 8b70f23, PR #9; session ended. Was: next: siteContent.socials reordered to Instagram, Facebook; new shared ContactDetails, PrivacyNote, ContactPanel; unit 2 on origin/feature/contact-page 26a8bd9, not on master yet. After the next rebase: SocialLink.label? and SiteContent.contactForm.replyTime — SiteContent fixtures in tests need replyTime), soorten-fotoshoots-page (✅ merged as a58bc1c; session ended); session names change on restart, check ListAgents. Over-mij session ("Over mij pagina") notifies when merged.

  • No full RE refresh; each feature only updates the RE lines about its own route/components
  • Hot files: own entry only in sitePages.ts, lighthouserc.cjs, active-features.md
  • Test environment (single, last deploy wins): send "claim test" with the reason (who reviews what) before a deploy_test dispatch, and "test free" once that review is done. A merge to master also deploys to test, so check that test is not claimed before merging
  • Lighthouse / pnpm check (port 4173): send "claim 4173" to the other two sessions before a run and "4173 free" after; avoid CPU-heavy work (full vitest with coverage, build) while another session runs Lighthouse
  • Peer commits to cherry-pick at the start of unit 3:
    • soorten-fotoshoots: on master since a58bc1c (PR #8) — no cherry-pick needed. Was eb23536 "Adds the shoot types and their photos" (content/types.ts ShootTypeId/FrameColor/ShootType, content/shootTypes.ts + test, assets/shoots/.jpg 960×1200, theme.ts frame. tokens, test/arbitraries.ts shootTypeId/shootType/uniqueShootTypes). Run pnpm typegen afterwards (theme change). Their Gezin photo is F41A7138 (also portfolio photo 9; overlap accepted by their user; different derivatives)
    • If soorten-fotoshoots PR #8 (or contact's PR) is merged to master before unit 3 starts: rebase onto master instead of cherry-picking that commit
    • contact-page: webPage() on master since a58bc1c (as 3c7d00e) — no cherry-pick needed; 790495d no longer exists after contact's rebase
  • seo.ts: contact-page builds generic webPage(type, path, extra) (aboutPage refactored onto it) in a separate commit; portfolio cherry-picks it and uses it for ImageGallery/CollectionPage JSON-LD. No own xxxPage() helper. Proposed signature: webPage(type: WebPageType, path: RoutePath, extra: Record<string, unknown> = {}) with WebPageType = 'WebPage' | 'AboutPage' | 'ContactPage' | 'ImageGallery' | 'CollectionPage' (add a type to the union in an own one-line commit if needed) → { @context, @type: type, @id + url: canonicalUrl(path), name/description from sitePages[path], inLanguage: 'nl-NL', ...extra } (extra last). Commit hash follows once contact's user approves; design against this signature until then
  • Claims: portfolio — PortfolioGrid, Lightbox, InstagramGrid moved from components/home/ to shared; contact — ContactForm generalisation, contact-details block; soorten-fotoshoots — content/shootTypes.ts, CallToAction band, optional MediaText reverse prop
  • PageIntro is used by all; announce before changing it
  • Photos: soorten-fotoshoots owns the shoot photos (newborn, zwangerschap, loveshoot, portret, gezin) in web/src/assets/shoots/, delivered as an assets-only commit; portfolio cherry-picks it if the user picks any of them. Portfolio-only photos go in web/src/assets/portfolio/. Photos already in web/src/assets/home/ (intro-2, intro-4) are imported from there. Send the final photo list to soorten-fotoshoots after Requirements Analysis. Update: user chose the 10 live photos (Q1 A), no overlap with the shoot photos; list sent
  • Shoot types: portfolio reuses soorten-fotoshoots' list for filters and captions. Proposed shape in content/types.ts: ShootTypeId = 'newborn' | 'zwangerschap' | 'gezin' | 'loveshoot' | 'portret'; ShootType { id; name ('Newborn', …, 'Portretten'); shootLabel ('Newbornshoot', …, 'Portretshoot'); paragraphs; image; packageId? }; order newborn, zwangerschap, gezin, loveshoot, portret. Delivered as a separate commit (types + shootTypes.ts + assets/shoots/) at the start of their unit 1; hash follows. Portfolio photo data references ShootTypeId only. ?shoot=<id> link from their page: confirmed by their user; shown only once /portfolio is indexed: true (no message needed at merge). Portfolio route: validateSearch returns typed { shoot?: ShootTypeId } so their search: { shoot } type-checks. Types without portfolio photos fall back to "Alles"; portfolio exports a pure helper (working name shootTypesWithPhotos) in unit 3 and sends its name. ShootType gains photosLabel and frameColor (theirs, additive). RichParagraph moves to components/ (theirs). Their shoot blocks render "Bekijk meer {photosLabel}" → /portfolio?shoot=<id> once sitePages['/portfolio'].indexed === true; their app.test.tsx expects 5 portfolio links when indexed, else 0 (check after rebase). Their session has ended: wiring the helper into their ShootList/ShootBlock (portfolioLive && hasPhotos) is now a follow-up for this feature (unit 3 or a small follow-up commit). ShootType.detailImage added (optional, theirs)

Known Risks

  • Lighthouse mobile performance ≈ 0.9 threshold (from soorten-fotoshoots, 2026-10-25): pages whose LCP is an image land at LCP ≈ 3.22 s ≈ score 0.895 in the simulated mobile run (over-mij and soorten-fotoshoots); fewer image bytes do not help, the cost is main bundle + route chunk. Relevant for NFR-PF-05 in unit 3: keep the route chunk small (Lightbox lazy, Q7), measure early, and align with soorten-fotoshoots' user decision on the budget before changing lighthouserc*.cjs

  • Soorten-fotoshoots' rule (their unit 2 commit, decided by their user): lighthouserc.cjs exports photoPagePaths = ['/over-mij', '/soorten-fotoshoots'] with photoPageMobilePerformance = 0.85 (mobile only); assertMatrix order home (0.8) → photo pages (0.85) → other indexed → noindex → 404; lighthouserc.desktop.cjs maps every entry to 0.9. Suggested for portfolio: add /portfolio to photoPagePaths once indexed. Open for this feature: that lowers NFR-PF-05 (≥ 0.9 mobile, approved) for /portfolio to 0.85 — needs this user's decision; decide in unit 3 after measuring (if /portfolio reaches 0.9 it stays in the default budget)

  • Accent button contrast (from contact-page, 2026-10-25): linkButton variant accent (white on accent #7f8b76) is 3.58:1 < 4.5:1; Lighthouse only flags it when visible on first load (Reveal hides it elsewhere). Decided by the user, on master since 8b70f23: accent button bg → accent.deep (#5f6a58), hover → new token accent.deeper (#475042); changes theme.ts and recipes/linkButton.ts — keep both on a rebase. Portfolio does not plan an accent button; the filter bar uses accent.deep for its active state (≥ 4.5:1) — verify contrast of every new colour pair in unit 2 anyway

  • Homepage mobile performance sits at 0.79–0.80 against its 0.8 threshold on current builds (contact, 3 runs). A failing / in a portfolio Lighthouse run is probably this, not a portfolio regression; compare against master before acting

Stage Progress

🔵 INCEPTION PHASE

  • Workspace Detection
  • Reverse Engineering - SKIP (artifacts current; team agreement)
  • Requirements Analysis (approved)
  • User Stories - SKIP
  • Workflow Planning (approved)
  • Application Design - EXECUTE (approved)
  • Units Generation - SKIP

🟢 CONSTRUCTION PHASE

  • [~] Functional Design - EXECUTE (units 2 and 3) / SKIP (unit 1) — Unit 2 ✅
  • NFR Requirements - SKIP
  • NFR Design - SKIP
  • Infrastructure Design - SKIP
  • [~] Code Generation - EXECUTE (per unit) — Unit 1 Shared Instagram block ✅ (e013f14 after rebases); Unit 2 Gallery building blocks: generated, awaiting approval
  • Build and Test - EXECUTE

🟡 OPERATIONS PHASE

  • Deployment Setup, Monitoring Setup, Production Readiness Validation - SKIP (Operations = No)

Current Status

  • Lifecycle Phase: CONSTRUCTION
  • Current Stage: Functional Design — Unit 2 Gallery building blocks
  • Next Stage: Code Generation — Unit 2