The content column now uses the design's gutter as side padding instead of Chakra's 16/24/32px. The Lifestyle fotografie row on phones bled out by the gutter, so the page was 4px too wide and Chrome zoomed out slightly. The header drops its extra padding and the to-top button follows the gutter, so logo, hero controls and content share one edge. Anchored sections now scroll to the height of the shrunken header, so Contact lands right below it instead of 24px lower. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
53 lines
3.1 KiB
Markdown
53 lines
3.1 KiB
Markdown
# Build and Test Summary — homepage-sections
|
||
|
||
## Build
|
||
- **Tool**: pnpm + Vite (`tsc && vite build`)
|
||
- **Status**: ✅ Success (built in ~2.5 s locally; CI `check` job green on the Pi and on the PC runner)
|
||
- **Artifacts**: `web/dist/`
|
||
|
||
## Unit tests
|
||
- **Total**: 244 in 53 files. **Passed**: 244. **Failed**: 0.
|
||
- **Coverage**: `src/lib/` 100%, overall ~92% of statements
|
||
- **Status**: ✅ Pass
|
||
|
||
## Integration (whole homepage)
|
||
- **Automated, in the suite**: section order with one h1 and axe clean; "Boek Newborn" scrolls to Contact and selects the package; `?pakket=` selects, tidies and focuses; Instagram absent without a valid https link. ✅
|
||
- **Browser, production build, 1440 px and 390 px phone** (scenarios in `integration-test-instructions.md`):
|
||
|
||
| Scenario | Result |
|
||
|---|---|
|
||
| Section order | ✅ |
|
||
| Layout shift while scrolling the whole page | ✅ 0.0008 / 0 |
|
||
| All three "Boek" buttons | ✅ after fixes 1 and 2 below |
|
||
| Keyboard focus on the Instagram tiles | ✅ |
|
||
| Horizontal overflow, 7 pages × 5 widths | ✅ after fix 1 below |
|
||
| No new image requests from Instagram | ✅ |
|
||
|
||
### Found and fixed in this stage
|
||
1. **Phones: the page was 4 px too wide.**
|
||
- Cause: Chakra's `Container` padded 16 / 24 / 32 px, while the design's `.container` uses `--gutter` (clamp(20 px, 4vw, 48 px)). The Lifestyle fotografie row bleeds out by the gutter, so it stuck out 4 px on both sides.
|
||
- Effect: Chrome widened the layout viewport to 394 px, and the page could be nudged sideways.
|
||
- Fix (the owner chose to follow the design everywhere): `Container` pads with `gutter`. The header loses its extra padding from the first hero commit, and the to-top button aligns with the gutter. The logo, hero controls and content now share one edge.
|
||
2. **Desktop: Contact landed 24 px below the header.**
|
||
- Cause: the scroll margin was the full header height (92 px), but the header has shrunk to 68 px by the time the page reaches Contact.
|
||
- Fix: anchored sections use the sticky header height (`spacing.header.sticky`).
|
||
|
||
## Performance (Lighthouse CI, production build)
|
||
| Page | Mobile | Desktop |
|
||
|---|---|---|
|
||
| Homepage | 0.83 (budget 0.8) | 1.0 |
|
||
| Other pages | 0.94–0.95 (budget 0.9) | 1.0 |
|
||
|
||
Accessibility and best practices are 1.0 on every page, and SEO passes everywhere. CI `lighthouse` job: ✅ (reporting only).
|
||
|
||
Two things disturb local measurements: a busy machine, and the CI Lighthouse job on the PC runner. That job uses `--network host`, so it occupies port 4173 and makes a local `pnpm check` fail with "port in use". See `performance-test-instructions.md`.
|
||
|
||
## Additional
|
||
- **Security**: `pnpm audit --prod` clean. The new section adds no new dependencies or external resources. External links use `noopener noreferrer`, and only https links are rendered.
|
||
- **Contract / E2E suite**: N/A (static front end without an API). The browser checks above cover the user flows.
|
||
|
||
## Overall
|
||
- **Build**: ✅ **Tests**: ✅ **Performance budgets**: ✅
|
||
- **Test environment**: test.andreaslop.nl was updated with unit 6 (run 557). The layout fixes are deployed in a follow-up run.
|
||
- **Ready for Operations**: yes, depending on the owner's decision about the Operations phase
|