Shares the Instagram block between pages
Moves InstagramGrid out of the homepage sections and gives it its own content module, so the portfolio can show the same block. The homepage renders exactly as before; the tiles keep reusing the intro and review photos, so each photo keeps one description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -39,7 +39,7 @@ None. There is no back-end yet (`api/` is empty). The static design README antic
|
||||
- `Eyebrow(TextProps & { as?: 'p' | 'span' | 'h2' | 'h3' | 'h4' })` — accent label, optionally a heading
|
||||
- `SectionHeading({ id, title, eyebrow?, lead?, align?: 'center' | 'start', spacing?: 'default' | 'compact', focusable? })` — renders an h2
|
||||
- `FramedImage({ image: ContentImage, aspectRatio })`, `DeferredImage(ImageProps & { image, near? })`, `Reveal(BoxProps & { delay? })`
|
||||
- `IntroGallery({ content })`, `AboutBlock({ content })`, `Pricing({ content, packages })`, `PriceCard(...)`, `Testimonials({ content, testimonials })`, `ContactSection({ content, packages, enabled, email, pakket? })`, `InstagramGrid({ content, profileUrl })`
|
||||
- `IntroGallery({ content })`, `AboutBlock({ content })`, `Pricing({ content, packages })`, `PriceCard(...)`, `Testimonials({ content, testimonials })`, `ContactSection({ content, packages, enabled, email, pakket? })`, `InstagramGrid({ content: InstagramContent, profileUrl })` (shared, `components/InstagramGrid/`)
|
||||
- `ContactForm(...)`, `ContactFormGate({ enabled, email, ... })`
|
||||
- `PhotoDuo({ photos: [ContentImage, ContentImage], label, 'data-testid'? })`
|
||||
- `about/AboutIntro({ content })`, `about/StorySection({ content, titleId, tone?, spacing?, children? })`, `shoots/ShootList({ shoots, packages, portfolioLive })`, `shoots/ShootBlock({ shoot, packages, reverse, priority, portfolioLive })`
|
||||
@@ -70,7 +70,9 @@ None. There is no back-end yet (`api/` is empty). The static design README antic
|
||||
### ContentImage
|
||||
- **Fields**: `src`, `alt`, `width`, `height` (intrinsic size, reserves space)
|
||||
### HomeContent
|
||||
- **Fields**: `intro`, `about` (`eyebrow`, `title`, `paragraphs[]`, `image`, `link: { label, to: RoutePath }`), `pricing`, `testimonials`, `contact`, `instagram`
|
||||
- **Fields**: `intro`, `about` (`eyebrow`, `title`, `paragraphs[]`, `image`, `link: { label, to: RoutePath }`), `pricing`, `testimonials`, `contact`
|
||||
### InstagramContent
|
||||
- **Fields**: `title`, `handle`, `photos: ContentImage[]` (the intro photos followed by the review photos, `instagramContent.ts`)
|
||||
### LinkTarget / InlineLink / RichText
|
||||
- **Fields**: `{ to: RoutePath; hash? }`; `InlineLink` adds `text`; `RichText = (string | InlineLink)[]`
|
||||
### AboutPageContent
|
||||
|
||||
@@ -19,7 +19,7 @@ graph TD
|
||||
Outlet --> About["routes/over-mij.tsx: about page"]
|
||||
Outlet --> Placeholders["portfolio, contact, privacyverklaring: PageIntro"]
|
||||
Home --> Hero["Hero (HeroArrows, HeroPauseButton, HeroSocials, useHeroSlider)"]
|
||||
Home --> Sections["components/home/: IntroGallery, AboutBlock, Pricing, Testimonials, ContactSection, InstagramGrid"]
|
||||
Home --> Sections["components/home/: IntroGallery, AboutBlock, Pricing, Testimonials, ContactSection; shared InstagramGrid"]
|
||||
Sections --> Blocks["Shared blocks: PageSection, MediaText, CallToAction, RichParagraph, Eyebrow, SectionHeading, FramedImage, DeferredImage, Reveal"]
|
||||
Sections --> Form["ContactForm + ContactFormGate (lazy), contact/"]
|
||||
Content["content/: siteContent, heroContent, homeContent, packages, testimonials, types"] -.-> Shell
|
||||
@@ -74,7 +74,7 @@ Text alternative: main.tsx starts Sentry and mounts the router; the root route r
|
||||
|
||||
### components/home/ (homepage sections)
|
||||
- **Purpose**: The six homepage blocks below the hero, in LAYOUT.md order
|
||||
- **Responsibilities**: `IntroGallery` (four photos, swipeable row on phones), `AboutBlock` (framed photo of Andrea + intro + link to `/over-mij`), `Pricing` + `PriceCard` (packages with "Boek" links → `/?pakket=…#contact`), `Testimonials` (+ `TestimonialCarousel`, `TestimonialSlide`), `ContactSection` (lazy `ContactForm` behind `ContactFormGate`, mailto fallback), `InstagramGrid` (fixed tiles linking to the profile)
|
||||
- **Responsibilities**: `IntroGallery` (four photos, swipeable row on phones), `AboutBlock` (framed photo of Andrea + intro + link to `/over-mij`), `Pricing` + `PriceCard` (packages with "Boek" links → `/?pakket=…#contact`), `Testimonials` (+ `TestimonialCarousel`, `TestimonialSlide`), `ContactSection` (lazy `ContactForm` behind `ContactFormGate`, mailto fallback); the Instagram block is the shared `components/InstagramGrid` (fixed tiles linking to the profile, content from `instagramContent.ts`), also used on the portfolio
|
||||
- **Type**: Application
|
||||
|
||||
### Shared section building blocks
|
||||
|
||||
@@ -31,7 +31,7 @@ graph TD
|
||||
Hero --> useHeroSlider["Hero/useHeroSlider.ts"]
|
||||
Hero --> LinkButton["components/LinkButton.tsx"]
|
||||
LinkButton --> RouterLink["components/RouterLink.tsx"]
|
||||
Index --> HomeParts["home/*: IntroGallery, AboutBlock, Pricing, Testimonials, ContactSection, InstagramGrid"]
|
||||
Index --> HomeParts["home/*: IntroGallery, AboutBlock, Pricing, Testimonials, ContactSection; shared InstagramGrid"]
|
||||
HomeParts --> PageSection["PageSection/PageSection.tsx"]
|
||||
HomeParts --> SectionHeading["SectionHeading/SectionHeading.tsx"]
|
||||
HomeParts --> Reveal["Reveal/Reveal.tsx"]
|
||||
@@ -70,7 +70,8 @@ Candidates for modification are marked with ★ for the over-mij-page feature.
|
||||
- `web/src/components/NavigationBar/*` — header, NavLink, MobileNav
|
||||
- `web/src/components/Footer/*` — footer, FooterColumn, FooterLink
|
||||
- `web/src/components/Hero/*` — hero slider, arrows, pause button, socials, slider hook
|
||||
- `web/src/components/home/*` — the six homepage sections (AboutBlock is the closest relative of the Over mij page's first block)
|
||||
- `web/src/components/home/*` — five homepage sections (AboutBlock is the closest relative of the Over mij page's first block)
|
||||
- `web/src/components/InstagramGrid/InstagramGrid.tsx` — Instagram block, shared by the homepage and the portfolio (moved from `home/` in portfolio-page)
|
||||
- ★ `web/src/components/PageSection/PageSection.tsx` — section frame for any page (was `HomeSection`)
|
||||
- ★ `web/src/components/MediaText/MediaText.tsx`, `Eyebrow/Eyebrow.tsx` — framed photo next to text; accent label
|
||||
- ★ `web/src/components/SectionHeading/SectionHeading.tsx` — eyebrow + h2 + lead
|
||||
@@ -82,7 +83,7 @@ Candidates for modification are marked with ★ for the over-mij-page feature.
|
||||
- `web/src/components/StatusPage/*` — StatusPage layout, NotFound, ErrorPage
|
||||
- ★ `web/src/components/LinkButton.tsx`, `RouterLink.tsx` — router links (button style / Chakra-wrapped)
|
||||
- ★ `web/src/content/types.ts` — content interfaces (API shape)
|
||||
- ★ `web/src/content/*.ts` — static content (`siteContent`, `heroContent`, `homeContent`, `packages`, `testimonials`, `socialPlatforms`)
|
||||
- ★ `web/src/content/*.ts` — static content (`siteContent`, `heroContent`, `homeContent` (exports `introPhotos`), `instagramContent`, `packages`, `testimonials`, `socialPlatforms`)
|
||||
- `web/src/contact/*` — contact form types and placeholder submit
|
||||
- `web/src/hooks/*` — `useRouteFocus`, `useScrolledPast`, `useInView`, `usePageLoaded`, `useReveal`
|
||||
- `web/src/lib/*.ts` — pure helpers with tests
|
||||
|
||||
@@ -0,0 +1,86 @@
|
||||
# AI-DLC State Tracking
|
||||
|
||||
## Project Information
|
||||
- **Feature Name**: Portfolio page (`/portfolio`)
|
||||
- **Feature Slug**: portfolio-page
|
||||
- **Project Type**: Brownfield
|
||||
- **Start Date**: 2026-10-24T19:30:00Z
|
||||
- **Current Stage**: CONSTRUCTION - Code Generation (Unit 1 Shared Instagram block, generated, awaiting approval)
|
||||
- **Branch**: feature/portfolio-page (fast-forwarded onto master 11a5224 after the over-mij-page merge, PR #7)
|
||||
- **Worktree**: K:\Development\SlpSoftware\Projects\AndreaSlopFotografie-portfolio
|
||||
|
||||
## Workspace State
|
||||
- **Existing Code**: Yes
|
||||
- **Programming Languages**: TypeScript (React/TSX)
|
||||
- **Build System**: pnpm + Vite (`tsc && vite build`), Gitea Actions CI
|
||||
- **Project Structure**: Single front-end SPA in `web/`; static HTML design reference in `design/andreaslop-static/`; `api/` folder present but empty (.NET back-end planned)
|
||||
- **Reverse Engineering Needed**: No (artifacts current with the over-mij blocks; team agreement: no full refresh, each feature updates only its own lines)
|
||||
- **Workspace Root**: K:\Development\SlpSoftware\Projects\AndreaSlopFotografie
|
||||
|
||||
## Code Location Rules
|
||||
- **Application Code**: Workspace root (NEVER in aidlc-docs/) — front-end lives in `web/`
|
||||
- **Feature Documentation**: aidlc-docs/features/portfolio-page/ only
|
||||
- **Shared Artifacts**: aidlc-docs/_shared/
|
||||
- **Structure patterns**: See code-generation.md Critical Rules
|
||||
|
||||
## Language Configuration
|
||||
- **Documentation Language**: English
|
||||
- **Conversation Language**: User Language (Dutch)
|
||||
- **Source**: inherited from aidlc-docs/language-preference.md (answer A); user may override
|
||||
|
||||
## Extension Configuration
|
||||
| Extension | Enabled | Decided At |
|
||||
|---|---|---|
|
||||
| Security Baseline | Yes | Requirements Analysis |
|
||||
| Property-Based Testing | Yes (full enforcement) | Requirements Analysis |
|
||||
|
||||
## Operations Configuration
|
||||
- **Include Operations Phase**: No
|
||||
- **Decided At**: Requirements Analysis
|
||||
|
||||
## Execution Plan Summary
|
||||
- **Stages to Execute**: Application Design (standard), Functional Design (units 2 and 3), Code Generation (3 units), Build and Test
|
||||
- **Stages to Skip**: Reverse Engineering (team agreement), User Stories (single persona, concrete FRs), Units Generation (split fixed in the execution plan), Functional Design for unit 1 (behaviour-preserving move), NFR Requirements and NFR Design (NFRs set at requirements level), Infrastructure Design (static assets only), Operations (decided No)
|
||||
- **Units**: 1 Shared Instagram block → 2 Gallery building blocks → 3 Portfolio page (needs the webPage() and shootTypes.ts peer commits)
|
||||
- **Delivery**: branch feature/portfolio-page, commits per unit, full `pnpm check` (incl. Lighthouse) per unit, one PR at the end
|
||||
|
||||
## Parallel Work Agreements
|
||||
Parallel features, each in its own worktree (originally stacked on feature/over-mij-page, merged to master as 11a5224): contact-page (session andreaslopfotografie-91), soorten-fotoshoots-page (session andreaslopfotografie-3f). Over-mij session ("Over mij pagina") notifies when merged.
|
||||
- No full RE refresh; each feature only updates the RE lines about its own route/components
|
||||
- Hot files: own entry only in sitePages.ts, lighthouserc.cjs, active-features.md
|
||||
- **Lighthouse / `pnpm check` (port 4173)**: send "claim 4173" to the other two sessions before a run and "4173 free" after; avoid CPU-heavy work (full vitest with coverage, build) while another session runs Lighthouse
|
||||
- **Peer commits to cherry-pick at the start of unit 3**:
|
||||
- soorten-fotoshoots: `eb23536` "Adds the shoot types and their photos" (content/types.ts ShootTypeId/FrameColor/ShootType, content/shootTypes.ts + test, assets/shoots/*.jpg 960×1200, theme.ts frame.* tokens, test/arbitraries.ts shootTypeId/shootType/uniqueShootTypes). Run `pnpm typegen` afterwards (theme change). Their Gezin photo is F41A7138 (also portfolio photo 9; overlap accepted by their user; different derivatives)
|
||||
- contact-page: `webPage()` — hash pending
|
||||
- seo.ts: contact-page builds generic `webPage(type, path, extra)` (aboutPage refactored onto it) in a separate commit; portfolio cherry-picks it and uses it for ImageGallery/CollectionPage JSON-LD. No own xxxPage() helper. Proposed signature: `webPage(type: WebPageType, path: RoutePath, extra: Record<string, unknown> = {})` with `WebPageType = 'WebPage' | 'AboutPage' | 'ContactPage' | 'ImageGallery' | 'CollectionPage'` (add a type to the union in an own one-line commit if needed) → `{ @context, @type: type, @id + url: canonicalUrl(path), name/description from sitePages[path], inLanguage: 'nl-NL', ...extra }` (extra last). Commit hash follows once contact's user approves; design against this signature until then
|
||||
- Claims: portfolio — PortfolioGrid, Lightbox, InstagramGrid moved from components/home/ to shared; contact — ContactForm generalisation, contact-details block; soorten-fotoshoots — content/shootTypes.ts, CallToAction band, optional MediaText `reverse` prop
|
||||
- PageIntro is used by all; announce before changing it
|
||||
- Photos: soorten-fotoshoots owns the shoot photos (newborn, zwangerschap, loveshoot, portret, gezin) in `web/src/assets/shoots/`, delivered as an assets-only commit; portfolio cherry-picks it if the user picks any of them. Portfolio-only photos go in `web/src/assets/portfolio/`. Photos already in `web/src/assets/home/` (intro-2, intro-4) are imported from there. Send the final photo list to soorten-fotoshoots after Requirements Analysis. **Update**: user chose the 10 live photos (Q1 A), no overlap with the shoot photos; list sent
|
||||
- Shoot types: portfolio reuses soorten-fotoshoots' list for filters and captions. Proposed shape in `content/types.ts`: `ShootTypeId = 'newborn' | 'zwangerschap' | 'gezin' | 'loveshoot' | 'portret'`; `ShootType { id; name ('Newborn', …, 'Portretten'); shootLabel ('Newbornshoot', …, 'Portretshoot'); paragraphs; image; packageId? }`; order newborn, zwangerschap, gezin, loveshoot, portret. Delivered as a separate commit (types + shootTypes.ts + assets/shoots/) at the start of their unit 1; hash follows. Portfolio photo data references `ShootTypeId` only. `?shoot=<id>` link from their page: confirmed by their user; shown only once `/portfolio` is `indexed: true` (no message needed at merge). Portfolio route: `validateSearch` returns typed `{ shoot?: ShootTypeId }` so their `search: { shoot }` type-checks. Types without portfolio photos fall back to "Alles"; portfolio exports a pure helper (working name `shootTypesWithPhotos`) in unit 3 and sends its name. ShootType gains `photosLabel` and `frameColor` (theirs, additive). RichParagraph moves to `components/` (theirs)
|
||||
|
||||
## Stage Progress
|
||||
|
||||
### 🔵 INCEPTION PHASE
|
||||
- [x] Workspace Detection
|
||||
- [x] Reverse Engineering - SKIP (artifacts current; team agreement)
|
||||
- [x] Requirements Analysis (approved)
|
||||
- [x] User Stories - SKIP
|
||||
- [x] Workflow Planning (approved)
|
||||
- [x] Application Design - EXECUTE (approved)
|
||||
- [ ] Units Generation - SKIP
|
||||
|
||||
### 🟢 CONSTRUCTION PHASE
|
||||
- [ ] Functional Design - EXECUTE (units 2 and 3) / SKIP (unit 1)
|
||||
- [ ] NFR Requirements - SKIP
|
||||
- [ ] NFR Design - SKIP
|
||||
- [ ] Infrastructure Design - SKIP
|
||||
- [~] Code Generation - EXECUTE (per unit) — Unit 1 Shared Instagram block: generated, awaiting approval
|
||||
- [ ] Build and Test - EXECUTE
|
||||
|
||||
### 🟡 OPERATIONS PHASE
|
||||
- [ ] Deployment Setup, Monitoring Setup, Production Readiness Validation - SKIP (Operations = No)
|
||||
|
||||
## Current Status
|
||||
- **Lifecycle Phase**: CONSTRUCTION
|
||||
- **Current Stage**: Code Generation — Unit 1 Shared Instagram block (awaiting approval)
|
||||
- **Next Stage**: Functional Design — Unit 2 Gallery building blocks
|
||||
@@ -0,0 +1,186 @@
|
||||
# AI-DLC Audit Log — portfolio-page
|
||||
|
||||
## Initial User Request
|
||||
|
||||
**Timestamp**: 2026-10-24T19:30:00Z
|
||||
|
||||
**User Input**: "Ik wil een nieuwe feature starten voor het bouwen van de portfolio pagina. Wederom met aandacht voor SEO, accessibility en reusability van code elementen, chakra en theming. Net zoals voorgaande feature."
|
||||
|
||||
**AI Response**: "Started AI-DLC workflow (existing multi-feature workspace, no welcome message). Began Workspace Detection."
|
||||
|
||||
**Context**: INCEPTION - Workspace Detection (start)
|
||||
|
||||
---
|
||||
|
||||
## Workspace Detection — Branch Base Decision
|
||||
|
||||
**Timestamp**: 2026-10-24T19:33:00Z
|
||||
|
||||
**User Input**: "Portfolio vanaf over-mij branch"
|
||||
|
||||
**AI Response**: "Flagged that feature over-mij-page is not finished (Build and Test started but not closed, audit entry uncommitted, branch not merged to master) while the portfolio page will reuse its shared blocks (PageIntro, PageSection, media+text block). Asked how to sequence the two features: finish over-mij first (recommended), branch portfolio from feature/over-mij-page, or branch from master. User chose to branch from feature/over-mij-page."
|
||||
|
||||
**Context**: INCEPTION - Workspace Detection. Process decision on branch base.
|
||||
|
||||
---
|
||||
|
||||
## Workspace Detection
|
||||
|
||||
**Timestamp**: 2026-10-24T19:34:50Z
|
||||
|
||||
**User Input**: (none — automatic stage)
|
||||
|
||||
**AI Response**: "Feature resolution: request is clearly new work, so a new feature was started without a feature-selection prompt. Classification: Feature (new page, no defect). Slug: portfolio-page. Branch feature/portfolio-page created from feature/over-mij-page (ae769cb); the uncommitted over-mij-page audit.md entry stays in the working tree and belongs to that feature. Brownfield (React SPA in web/, placeholder route web/src/routes/portfolio.tsx and design reference design/andreaslop-static/portfolio.html exist). Language configuration inherited from aidlc-docs/language-preference.md (answer A: English docs, Dutch conversation), stated to the user for correction instead of re-asking. Reverse engineering artifacts in _shared/ are stale: generated at 99d4610, while 43 files under web/ changed up to ae769cb (shared section blocks, Over mij page, seo.ts, sitePages.ts). Next: refresh Reverse Engineering."
|
||||
|
||||
**Context**: INCEPTION - Workspace Detection (complete). Parallel features: over-mij-page (🟢 Construction, Build and Test). Conflicts: see below.
|
||||
|
||||
⚠️ **Potential Conflict Detected**
|
||||
Feature "portfolio-page" may affect components also touched by active feature "over-mij-page":
|
||||
- Shared components: web/src/content, shared section components (PageIntro, PageSection, media+text block), web/src/seo.ts, web/src/sitePages.ts
|
||||
- Resolution: portfolio-page is stacked on feature/over-mij-page; over-mij-page must be merged to master before the portfolio PR, or the portfolio PR will also carry its commits.
|
||||
|
||||
---
|
||||
|
||||
## Workspace Detection — Parallel Work Setup
|
||||
|
||||
**Timestamp**: 2026-10-24T19:55:00Z
|
||||
|
||||
**User Input**: "kan je niet verde rin eeen worktree en zorgen dat je die update zodra over mij klaar is? Ik heb meerdere features gestart omdat ik die tegelijk wilden gaan oppakken. Kan je daarmee werken? OM wel te zorgen dat er geen dubbel werk gedaan wordt? Alsof je met teamgenoten praat?"
|
||||
|
||||
**AI Response**: "Moved the feature into its own worktree K:\Development\SlpSoftware\Projects\AndreaSlopFotografie-portfolio (branch feature/portfolio-page); the main checkout is left on a detached HEAD at ae769cb. Moved this feature's registry row from the main checkout to the worktree. Coordinated with the parallel sessions (contact-page, soorten-fotoshoots-page, over-mij-page) and recorded the agreements in aidlc-state.md § Parallel Work Agreements. Asked the over-mij session to notify all three when it is merged, so portfolio can rebase onto master. Reverse Engineering skipped: per team agreement the shared artifacts are current with the over-mij blocks, and each feature updates only its own lines (the prepared broad refresh was not applied)."
|
||||
|
||||
**Context**: INCEPTION - Workspace Detection (parallel setup) → Reverse Engineering SKIP → Requirements Analysis next
|
||||
|
||||
---
|
||||
|
||||
## Branch Update — over-mij-page merged
|
||||
|
||||
**Timestamp**: 2026-10-24T20:30:00Z
|
||||
|
||||
**User Input**: (none — notification from the over-mij-page session: merged to master as 11a5224, PR #7)
|
||||
|
||||
**AI Response**: "Updated feature/portfolio-page as agreed with the user ('zorgen dat je die update zodra over mij klaar is'). The branch had no own commits, so it was fast-forwarded from ae769cb to master 11a5224 (only docs changed: 7a56a47, 194df71); uncommitted portfolio docs were stashed and re-applied. Resolved the expected conflict in aidlc-docs/active-features.md: kept master's ✅ Complete row for over-mij-page and added the portfolio-page row."
|
||||
|
||||
**Context**: INCEPTION - before Requirements Analysis. Branch base is now master.
|
||||
|
||||
---
|
||||
|
||||
## Requirements Analysis — Start
|
||||
|
||||
**Timestamp**: 2026-10-24T20:45:00Z
|
||||
|
||||
**User Input**: "ja start de requirement analysis"
|
||||
|
||||
**AI Response**: "Started Requirements Analysis (standard depth: new page, multiple components incl. new PortfolioGrid and Lightbox, clear intent but open choices). Compared the design (portfolio.html: page head, 8 photos cropped 3:4 in a 3/2/1-column grid, lightbox with prev/next/close/caption/counter, Instagram block) with the live site andreaslop.nl/portfolio (no h1 or intro, 10 newer photos, 9 of 10 without alt text, no filters, Instagram block). Created inception/requirements/requirement-verification-questions.md (in Dutch, like the previous feature) with 13 content questions (photo set, grid layout, lightbox, caption, deep link, image sizes, loading, intro text, filters, Instagram block, SEO title/description, JSON-LD ImageGallery, OG image) plus the Security Baseline and Property-Based Testing opt-ins and the Operations phase question."
|
||||
|
||||
**Context**: INCEPTION - Requirements Analysis (awaiting answers)
|
||||
|
||||
---
|
||||
|
||||
## Requirements Analysis — Verification Answers
|
||||
|
||||
**Timestamp**: 2026-10-24T21:05:00Z
|
||||
|
||||
**User Input**: "Ik heb de vragen beantwoord"
|
||||
|
||||
**AI Response**: "Read the answers: Q1 A (the 10 live photos, re-processed, descriptive alt texts), Q2 B (masonry), Q3 A (accessible lightbox on Chakra Dialog), Q4 C (separate short caption per photo, e.g. shoot type), Q5 A (no deep link to a single photo), Q6 A (two sizes: grid ~800px, lightbox ~1600–2000px, neighbours preloaded), Q7 A (first row eager/high priority, rest deferred), Q8 A (eyebrow Werk, h1 Portfolio, intro 'Klik of tik'), Q9 B (filters per shoot type based on shootTypes.ts), Q10 A (InstagramGrid shared with own content, same photos as homepage), Q11 B (keep title and description), Q12 A (ImageGallery with ImageObject list via webPage()), Q13 A (own OG image from a portfolio photo), Security Baseline A (Yes), PBT A (Yes), Operations B (No). Recorded extension and operations configuration. Detected interactions needing clarification: masonry vs. 'first row' loading and reading order; caption vs. shoot type data; who assigns shoot types; filter state in URL; lightbox scope under a filter; empty filters. Created inception/requirements/requirement-clarification-questions.md with 7 questions. Notified soorten-fotoshoots of the dependency on shootTypes.ts and that the portfolio uses none of their shoot photos."
|
||||
|
||||
**Context**: INCEPTION - Requirements Analysis (awaiting clarification answers)
|
||||
|
||||
---
|
||||
|
||||
## Requirements Analysis — Clarification Answers and Requirements Document
|
||||
|
||||
**Timestamp**: 2026-10-24T21:30:00Z
|
||||
|
||||
**User Input**: "Ik heb de vragen beantwoord"
|
||||
|
||||
**AI Response**: "Read the clarification answers, all A: C1 masonry in row order, C2 first 3 photos eager, C3 caption = shoot type label from the same data as the filters, C4 shoot type and alt text per photo proposed in Functional Design and approved by the user, C5 filter in the URL (?shoot=, canonical stays /portfolio), C6 lightbox browses within the active filter, C7 only filters for shoot types with photos plus 'Alles'. No remaining contradictions. Loaded the Security Baseline and Property-Based Testing rules. Generated inception/requirements/requirements.md (9 FRs, 5 SEO requirements, 6 NFRs, extension compliance at requirements level, dependencies on contact-page's webPage() and soorten-fotoshoots' shootTypes.ts). Added LAYOUT.md 'Intro' block for consistency with the other pages (not asked as a question; flagged to the user for review). Confirmed the ?shoot=<id> URL to soorten-fotoshoots. Presented the Requirements Analysis completion message."
|
||||
|
||||
**Context**: INCEPTION - Requirements Analysis (awaiting approval)
|
||||
|
||||
---
|
||||
|
||||
## Requirements Analysis — Approval
|
||||
|
||||
**Timestamp**: 2026-10-24T21:40:00Z
|
||||
|
||||
**User Input**: "ga door naar workflow planning"
|
||||
|
||||
**AI Response**: "Requirements approved (incl. the LAYOUT.md 'Intro' addition). User Stories skipped (single persona). Started Workflow Planning."
|
||||
|
||||
**Context**: INCEPTION - Requirements Analysis (approved) → Workflow Planning
|
||||
|
||||
---
|
||||
|
||||
## Workflow Planning
|
||||
|
||||
**Timestamp**: 2026-10-24T21:50:00Z
|
||||
|
||||
**User Input**: (none — stage executed after approval)
|
||||
|
||||
**AI Response**: "Created inception/plans/execution-plan.md. Risk Medium (lightbox and row-order masonry; two peer dependencies). Execute: Application Design (standard), Functional Design for units 2 and 3, Code Generation for 3 units, Build and Test. Skip: Units Generation, Functional Design unit 1, NFR Requirements, NFR Design, Infrastructure Design, Operations. Units: 1 Shared Instagram block, 2 Gallery building blocks (generic, fixture-tested, no peer dependency), 3 Portfolio page (cherry-picks webPage() and shootTypes.ts first; stops and reports if missing). Presented the plan for approval."
|
||||
|
||||
**Context**: INCEPTION - Workflow Planning (awaiting approval)
|
||||
|
||||
---
|
||||
|
||||
## Workflow Planning — Approval
|
||||
|
||||
**Timestamp**: 2026-10-24T22:00:00Z
|
||||
|
||||
**User Input**: "akkoord, ga verder"
|
||||
|
||||
**AI Response**: "Execution plan approved. Started Application Design (standard depth). Inspected the hero swipe logic (inline in useHeroSlider), the ?pakket= search handling (validateSearch + lib/packageFromSearch) and DeferredImage; no Chakra Dialog in use yet. Created inception/plans/application-design-plan.md with the already-decided points (claimed names with generic APIs, generic gallery item, content modules, URL state via validateSearch, Lightbox on Chakra Dialog, SEO builders on webPage()) and 7 questions: composition of grid/lightbox/filter, filter bar semantics, filter bar style, history behaviour, swipe extraction, masonry technique, lightbox code splitting."
|
||||
|
||||
**Context**: INCEPTION - Application Design (awaiting answers)
|
||||
|
||||
---
|
||||
|
||||
## Application Design — Answers
|
||||
|
||||
**Timestamp**: 2026-10-24T22:30:00Z
|
||||
|
||||
**User Input**: "ik heb de vragen beantwoord" (preceded by: "kan je voor de voorgestelde ontwerpen en de verwijderknop een voorbeeld geven?")
|
||||
|
||||
**AI Response**: "Before the answers: published an interactive example page (https://claude.ai/artifact/6s8P5d17ac69otiaWzDWZZ) for questions 2 (filter semantics), 3 (filter styles) and 4 (back button; 'verwijderknop' interpreted as 'terugknop', stated to the user). Answers read: Q1 A, Q2 A, Q3 A, Q4 A, Q5 A, Q6 'A, als het later nodig', Q7 A. Q6 looks cut off; added follow-up question 6a to the plan before generating the design. Also recorded the soorten-fotoshoots agreement: typed validateSearch { shoot?: ShootTypeId } on /portfolio, links shown once /portfolio is indexed, helper for shoot types with photos in unit 3."
|
||||
|
||||
**Context**: INCEPTION - Application Design (follow-up question pending)
|
||||
|
||||
---
|
||||
|
||||
## Application Design — Follow-up Answer and Artifacts
|
||||
|
||||
**Timestamp**: 2026-10-24T22:50:00Z
|
||||
|
||||
**User Input**: "Ik heb de vraag beantwoord en voor de duidleijkheid mijn antwoord op vraag 6 gecorrigeerd"
|
||||
|
||||
**AI Response**: "Read Q6 'A, als het later nodig kunnen we het alsnog ombouwen' and follow-up 6a = B: CSS-only masonry now, no preparation for JS measuring. Generated inception/application-design/components.md, component-methods.md, services.md, component-dependency.md and application-design.md. Key points: shared PortfolioGrid, Lightbox (lazy, Chakra Dialog) and FilterBar (toggle buttons, eyebrow style, new recipe) connected by components/portfolio/PortfolioGallery; URL owns the filter (typed validateSearch, replace navigation), PortfolioGallery owns the open photo; useSwipe + lib/swipeDirection extracted from the hero (and wrapIndex shared); generic GalleryItem; per-unit split of new/changed files; peer dependencies only in unit 3. Presented the completion message."
|
||||
|
||||
**Context**: INCEPTION - Application Design (awaiting approval)
|
||||
|
||||
---
|
||||
|
||||
## Application Design — Approval
|
||||
|
||||
**Timestamp**: 2026-10-25T07:00:00Z
|
||||
|
||||
**User Input**: "Akkoord, ga verder"
|
||||
|
||||
**AI Response**: "Application Design approved. Units Generation skipped (units fixed in the execution plan). Moved to CONSTRUCTION. Unit 1 (Shared Instagram block) has no Functional Design; created construction/plans/shared-instagram-code-generation-plan.md (13 steps: InstagramContent type and module, git mv of InstagramGrid to components/, homepage switched, tests, pnpm check, visual check, own RE lines, code summary, two commits: inception docs then unit 1; no push). Started pnpm install in the worktree (no node_modules yet). Noted soorten-fotoshoots commit eb23536 for unit 3."
|
||||
|
||||
**Context**: CONSTRUCTION - Code Generation Unit 1 (plan awaiting approval)
|
||||
|
||||
---
|
||||
|
||||
## Code Generation — Unit 1 — Plan Approval
|
||||
|
||||
**Timestamp**: 2026-10-25T07:10:00Z
|
||||
|
||||
**User Input**: "Approve plan"
|
||||
|
||||
**AI Response**: "Executed shared-instagram-code-generation-plan.md steps 1–12: InstagramContent type and instagramContent.ts, introPhotos exported, InstagramGrid moved to components/ (git mv) with props type changed, new test for the photo reuse, homepage switched; no leftovers. pnpm check green (60 files, 274 tests, Lighthouse 7 URLs mobile+desktop). Coordinated port 4173 with the parallel sessions (claim/free protocol). No browser available for the side-by-side visual check; verified by construction and unchanged tests, flagged to the user. Own RE lines updated; code summary written. Committing the inception docs and unit 1 locally (no push)."
|
||||
|
||||
**Context**: CONSTRUCTION - Code Generation Unit 1 (generated, awaiting approval)
|
||||
|
||||
---
|
||||
+47
@@ -0,0 +1,47 @@
|
||||
# Code Generation Plan — Unit 1: Shared Instagram block
|
||||
|
||||
Single source of truth for code generation of this unit. Workspace root: `K:\Development\SlpSoftware\Projects\AndreaSlopFotografie-portfolio` (worktree); all code in `web/src/`. Branch `feature/portfolio-page`.
|
||||
|
||||
## Unit Context
|
||||
- **Requirements**: FR-PF-08 (Instagram block shared, own content, same photos on home and portfolio), NFR-PF-02 (reuse, English comments), NFR-PF-03 (homepage `InstagramGrid` unchanged in output), NFR-PF-06 (content shaped for the API)
|
||||
- **Design**: [components.md § Unit 1](../../inception/application-design/components.md), [component-methods.md](../../inception/application-design/component-methods.md) (`InstagramContent`, `InstagramGrid({ content: InstagramContent; profileUrl })`)
|
||||
- **Dependencies**: none on other units or parallel features; unit 3 uses the moved component on the portfolio page
|
||||
- **Behavioural contract**: the homepage renders exactly as before — same DOM roles, names, texts, test ids, styles and photos. Existing tests pass with only import paths and the content source changed.
|
||||
- **No business logic, no new pure helpers** → no property-based tests in this unit (PBT N/A); example-based tests + axe.
|
||||
- **Photos**: the Instagram tiles keep reusing the homepage's intro and testimonial photos (one description per photo). On the homepage they cost no extra download; on the portfolio they are deferred images below the grid.
|
||||
|
||||
## Steps
|
||||
|
||||
### Content
|
||||
- [x] **Step 1** — `content/types.ts`: add `InstagramContent { title; handle; photos: ContentImage[] }` (comment: fixed selection until the API delivers the real feed, FR-HP-10); remove `instagram` from `HomeContent`.
|
||||
- [x] **Step 2** — `content/homeContent.ts`: export the shared `introPhotos` (named export) and remove the `instagram` block.
|
||||
- [x] **Step 3** — Create `content/instagramContent.ts`: `title`, `handle`, and `photos` = `introPhotos` + the testimonial images, in the current order (moves the existing comment, reworded for both pages).
|
||||
|
||||
### Component
|
||||
- [x] **Step 4** — `git mv components/home/InstagramGrid → components/InstagramGrid` (component and test).
|
||||
- [x] **Step 5** — `InstagramGrid.tsx`: props type `InstagramContent`; doc comment says it is used on the homepage and the portfolio. No markup or style change.
|
||||
- [x] **Step 6** — `InstagramGrid.test.tsx`: content from `instagramContent`; same assertions. Add one test: the tiles are exactly the intro photos followed by the testimonial photos (guards the "one description per photo" reuse).
|
||||
|
||||
### Homepage
|
||||
- [x] **Step 7** — `routes/index.tsx`: import `InstagramGrid` from its new path and pass `instagramContent`. `app.test.tsx` passes unchanged (Instagram region, hidden without a valid link).
|
||||
|
||||
### Verification and docs
|
||||
- [x] **Step 8** — Search for leftovers: no `home/InstagramGrid` and no `homeContent.instagram` / `HomeContent['instagram']` references in `web/`; no duplicate component files.
|
||||
- [x] **Step 9** — Run `pnpm check` in `web/` (lint, format, typecheck/build, tests with coverage, audits, Lighthouse). Fix and rerun until green.
|
||||
- [x] **Step 10** — Visual check of the homepage Instagram block in the browser (desktop and phone width): no visible difference with master. *Outcome: no browser available in this session; verified by construction (diff = props type + comment) and unchanged tests; browser look recommended on test.*
|
||||
- [x] **Step 11** — Update the reverse engineering lines about `InstagramGrid` and the content modules only (code-structure, architecture, api-documentation; team agreement: own lines only).
|
||||
- [x] **Step 12** — Write `aidlc-docs/features/portfolio-page/construction/shared-instagram/code/code-summary.md` (created/modified/moved files, tests, verification outcome).
|
||||
- [x] **Step 13** — Commit on `feature/portfolio-page`: first the inception docs ("Plans the portfolio page"), then this unit ("Shares the Instagram block between pages"). No push until asked.
|
||||
|
||||
## Files
|
||||
- **Created**: `content/instagramContent.ts`
|
||||
- **Moved + modified**: `components/home/InstagramGrid/InstagramGrid.tsx`, `InstagramGrid.test.tsx` → `components/InstagramGrid/`
|
||||
- **Modified**: `content/types.ts`, `content/homeContent.ts`, `routes/index.tsx`
|
||||
- **Docs**: `aidlc-docs/_shared/reverse-engineering/{code-structure,architecture,api-documentation}.md` (own lines), unit code summary
|
||||
|
||||
## Extension Compliance (unit 1)
|
||||
| Rule | Status | Rationale |
|
||||
|---|---|---|
|
||||
| SECURITY-10 | Compliant | No new dependencies |
|
||||
| Other SECURITY rules | N/A | Behaviour-preserving move; no data, endpoints, headers or config |
|
||||
| PBT-01..10 | N/A | No pure functions or business logic in this unit; example-based component and route tests cover the contract |
|
||||
@@ -0,0 +1,21 @@
|
||||
# Code Summary — Unit 1: Shared Instagram block
|
||||
|
||||
Plan: [shared-instagram-code-generation-plan.md](../../plans/shared-instagram-code-generation-plan.md)
|
||||
|
||||
## Changes (`web/src/`)
|
||||
| File | Change |
|
||||
|---|---|
|
||||
| `components/home/InstagramGrid/*` → `components/InstagramGrid/*` | Moved (`git mv`). Component: props type `HomeContent['instagram']` → `InstagramContent`, doc comment notes it is shared. Markup, styles and test ids unchanged |
|
||||
| `components/InstagramGrid/InstagramGrid.test.tsx` | Content from `instagramContent`; new test: the tiles are the intro photos followed by the review photos |
|
||||
| `content/types.ts` | New `InstagramContent`; `instagram` removed from `HomeContent` |
|
||||
| `content/homeContent.ts` | `introPhotos` exported; `instagram` block and the `testimonials` import removed |
|
||||
| `content/instagramContent.ts` | New: title, handle, photos (= `introPhotos` + review images, same order as before) |
|
||||
| `routes/index.tsx` | Imports `InstagramGrid` from its new path and passes `instagramContent` |
|
||||
|
||||
Docs: own lines about `InstagramGrid` and the content modules in `_shared/reverse-engineering/{code-structure,architecture,api-documentation}.md`.
|
||||
|
||||
## Verification
|
||||
- Leftover search: no `home/InstagramGrid`, `homeContent.instagram` or `HomeContent['instagram']` in `web/`.
|
||||
- `pnpm check`: ✅ lint, format, build, audits, tests — 60 test files, 274 tests passed (coverage thresholds met), Lighthouse mobile and desktop: all assertions passed for 7 URLs.
|
||||
- Homepage output: identical by construction. The component diff is only the props type and one comment line, and the photo list has the same values and order; the existing component and route tests (`app.test.tsx`: Instagram region, left out without a valid link) pass unchanged. A side-by-side look in a browser was **not** done in this session (no browser available); recommended once on test.
|
||||
- PBT: N/A for this unit (no pure functions or business logic).
|
||||
+11
-2
@@ -1,11 +1,13 @@
|
||||
import { screen, within } from '@testing-library/react';
|
||||
import { describe, expect, it } from 'vitest';
|
||||
import homeContent from '@/content/homeContent';
|
||||
import { introPhotos } from '@/content/homeContent';
|
||||
import instagramContent from '@/content/instagramContent';
|
||||
import testimonials from '@/content/testimonials';
|
||||
import { axeResults } from '@/test/axe';
|
||||
import { renderWithProviders } from '@/test/renderWithProviders';
|
||||
import InstagramGrid from './InstagramGrid';
|
||||
|
||||
const instagram = homeContent.instagram;
|
||||
const instagram = instagramContent;
|
||||
const PROFILE = 'https://www.instagram.com/andreaslopfotografie/';
|
||||
|
||||
function expectExternal(link: HTMLElement) {
|
||||
@@ -50,6 +52,13 @@ describe('InstagramGrid', () => {
|
||||
});
|
||||
});
|
||||
|
||||
it('reuses the intro photos and then the review photos, so each photo keeps one description', () => {
|
||||
expect(instagram.photos).toEqual([
|
||||
...introPhotos,
|
||||
...testimonials.map((testimonial) => testimonial.image),
|
||||
]);
|
||||
});
|
||||
|
||||
it('still renders the heading and handle when there are no photos', async () => {
|
||||
await renderWithProviders(
|
||||
<InstagramGrid
|
||||
+3
-2
@@ -3,12 +3,12 @@ import DeferredImage from '@/components/DeferredImage/DeferredImage';
|
||||
import PageSection from '@/components/PageSection/PageSection';
|
||||
import Reveal from '@/components/Reveal/Reveal';
|
||||
import SectionHeading from '@/components/SectionHeading/SectionHeading';
|
||||
import type { HomeContent } from '@/content/types';
|
||||
import type { InstagramContent } from '@/content/types';
|
||||
|
||||
const TITLE_ID = 'instagram-title';
|
||||
|
||||
type InstagramGridProps = {
|
||||
content: HomeContent['instagram'];
|
||||
content: InstagramContent;
|
||||
// A checked https link (visibleSocials); without one the route leaves
|
||||
// the section out
|
||||
profileUrl: string;
|
||||
@@ -17,6 +17,7 @@ type InstagramGridProps = {
|
||||
// "Instagram" (design .instagram): the handle as a link to the profile and
|
||||
// a row of square photos running from edge to edge, each linking to the
|
||||
// profile too. A fixed selection until the API delivers the real feed.
|
||||
// Shared by the homepage and the portfolio.
|
||||
export default function InstagramGrid({
|
||||
content,
|
||||
profileUrl,
|
||||
@@ -1,5 +1,4 @@
|
||||
import type { ContentImage, HomeContent } from './types';
|
||||
import testimonials from './testimonials';
|
||||
|
||||
// Images
|
||||
import intro1 from '../assets/home/intro-1.jpg';
|
||||
@@ -12,7 +11,7 @@ import deco2 from '../assets/home/deco-2.png';
|
||||
|
||||
// Shared by the intro gallery and the Instagram tiles, so one photo keeps
|
||||
// one description
|
||||
const introPhotos: ContentImage[] = [
|
||||
export const introPhotos: ContentImage[] = [
|
||||
{
|
||||
src: intro1,
|
||||
alt: 'Babyhandje in de hand van de moeder, op een gebreid dekentje',
|
||||
@@ -78,16 +77,6 @@ const homeContent: HomeContent = {
|
||||
title: 'Contact',
|
||||
lead: 'Wil je meer informatie ontvangen? Neem gerust contact met mij op.',
|
||||
},
|
||||
instagram: {
|
||||
title: 'Instagram',
|
||||
handle: '@andreaslopfotografie',
|
||||
// Photos the page already loads, so the tiles cost no extra download;
|
||||
// Andrea can swap them until the API delivers the real feed
|
||||
photos: [
|
||||
...introPhotos,
|
||||
...testimonials.map((testimonial) => testimonial.image),
|
||||
],
|
||||
},
|
||||
};
|
||||
|
||||
export default homeContent;
|
||||
|
||||
@@ -0,0 +1,18 @@
|
||||
import { introPhotos } from './homeContent';
|
||||
import testimonials from './testimonials';
|
||||
import type { InstagramContent } from './types';
|
||||
|
||||
// The Instagram block on the homepage and the portfolio until the API
|
||||
// delivers the real feed. Reuses photos the site already has, so each photo
|
||||
// keeps one description and the homepage downloads nothing extra for them;
|
||||
// Andrea can swap them in the meantime.
|
||||
const instagramContent: InstagramContent = {
|
||||
title: 'Instagram',
|
||||
handle: '@andreaslopfotografie',
|
||||
photos: [
|
||||
...introPhotos,
|
||||
...testimonials.map((testimonial) => testimonial.image),
|
||||
],
|
||||
};
|
||||
|
||||
export default instagramContent;
|
||||
@@ -128,12 +128,14 @@ export interface HomeContent {
|
||||
title: string;
|
||||
lead: string;
|
||||
};
|
||||
// A fixed selection until the API delivers the real feed (FR-HP-10)
|
||||
instagram: {
|
||||
title: string;
|
||||
handle: string;
|
||||
photos: ContentImage[];
|
||||
};
|
||||
}
|
||||
|
||||
// The Instagram block, shown on the homepage and the portfolio: a fixed
|
||||
// selection until the API delivers the real feed (FR-HP-10)
|
||||
export interface InstagramContent {
|
||||
title: string;
|
||||
handle: string;
|
||||
photos: ContentImage[];
|
||||
}
|
||||
|
||||
// Where a link goes: a route (a typo is a type error) and optionally an
|
||||
|
||||
@@ -1,13 +1,14 @@
|
||||
import { createFileRoute } from '@tanstack/react-router';
|
||||
import Hero from '../components/Hero/Hero';
|
||||
import InstagramGrid from '../components/InstagramGrid/InstagramGrid';
|
||||
import AboutBlock from '../components/home/AboutBlock/AboutBlock';
|
||||
import ContactSection from '../components/home/ContactSection/ContactSection';
|
||||
import InstagramGrid from '../components/home/InstagramGrid/InstagramGrid';
|
||||
import Pricing from '../components/home/Pricing/Pricing';
|
||||
import Testimonials from '../components/home/Testimonials/Testimonials';
|
||||
import IntroGallery from '../components/home/IntroGallery/IntroGallery';
|
||||
import heroContent from '../content/heroContent';
|
||||
import homeContent from '../content/homeContent';
|
||||
import instagramContent from '../content/instagramContent';
|
||||
import packages from '../content/packages';
|
||||
import testimonials from '../content/testimonials';
|
||||
import siteContent from '../content/siteContent';
|
||||
@@ -52,7 +53,7 @@ function Index() {
|
||||
/>
|
||||
{instagram && (
|
||||
<InstagramGrid
|
||||
content={homeContent.instagram}
|
||||
content={instagramContent}
|
||||
profileUrl={instagram.href}
|
||||
/>
|
||||
)}
|
||||
|
||||
Reference in New Issue
Block a user