Adds the inception docs and design for the homepage sections
Refreshes the shared reverse engineering docs, adds the requirements, application design and units for the homepage-sections feature, and updates the static design: live prices and form fields, the new Lieve woorden block and the coming-soon gate over the contact form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,26 +1,23 @@
|
||||
# Code Quality Assessment
|
||||
|
||||
## Test Coverage
|
||||
- **Overall**: None
|
||||
- **Unit Tests**: None (no test runner installed)
|
||||
- **Integration Tests**: None
|
||||
- Verification so far is `tsc` type-checking during `pnpm build` and manual browser checks
|
||||
- **Overall**: Good. Vitest with v8 coverage; 100% threshold enforced for `src/lib/**`, `src/seo.ts`, `src/sitemap.ts`; other files reported
|
||||
- **Unit Tests**: Pure helpers, SEO, sitemap, monitoring config, security headers, server config (incl. drift check against `deploy/`)
|
||||
- **Component Tests**: AppShell, NavigationBar, Footer, Hero (+ slider hook), BackToTop, PageIntro, StatusPage, Umami — with axe accessibility checks
|
||||
- **Property-based Tests**: fast-check, shared arbitraries in `src/test/arbitraries.ts`, seed logged in CI
|
||||
- **Integration / E2E**: No browser E2E; Lighthouse CI covers built pages (accessibility, best practices, SEO, performance)
|
||||
|
||||
## Code Quality Indicators
|
||||
- **Linting**: Not configured (TypeScript `noUnused*` flags only)
|
||||
- **Code Style**: Mostly consistent (Prettier: 4 spaces, single quotes). Exception: `routes/over-mij.tsx` uses double quotes and 2-space indent
|
||||
- **Documentation**: Good inline comments in Dutch explaining intent; README is a stub
|
||||
- **Linting**: ESLint (typescript-eslint, react-hooks, jsx-a11y), enforced in CI
|
||||
- **Code Style**: Consistent, Prettier-enforced in CI
|
||||
- **Documentation**: Short Dutch comments explaining *why*, often referencing requirement IDs (FR-xx, BR-xx, NFR-xx, Mx) from earlier AI-DLC features
|
||||
|
||||
## Technical Debt
|
||||
- `theme.ts` `globalCss.body.height: '250vh'` — temporary scroll-testing hack; forces every page to be 2.5 screens tall
|
||||
- `components/Footer.tsx` and `routes/over-mij.tsx` use Tailwind-style `className`s (`p-2`, `text-sm`, …) that do nothing — Tailwind is not installed
|
||||
- `AppShell` has no `<main>` landmark; static design has a skip link targeting `#main`
|
||||
- Header logo is not a link to the homepage (design: link with aria-label)
|
||||
- Social links are defined inside `Hero/heroContent.ts`; the footer in the design needs the same links → candidate for shared site-level content
|
||||
- `NavigationBar.tsx` uses `let [open, setOpen]` (should be `const`)
|
||||
- Unused Vite starter assets: `assets/hero.png`, `assets/typescript.svg`, `assets/vite.svg`
|
||||
- Design asset `footer-mark.png` (footer logo) not yet present in `web/src/assets`
|
||||
- Homepage mobile Lighthouse performance target is lowered to 0.8 (images not responsive, title after JavaScript); back to 0.9 is planned with responsive images from the API and prerendering
|
||||
- Five routes are placeholders (`noindex`); `lighthouserc.cjs` keeps its own list of indexed/noindex paths, guarded by a test against `sitePages.ts`
|
||||
- Static design images for the homepage sections (intro gallery, about photo, pricing decorations) are not yet in `web/src/assets`
|
||||
- No responsive image pipeline (srcset/sizes); hero photos are single large JPEGs
|
||||
|
||||
## Patterns and Anti-patterns
|
||||
- **Good Patterns**: design tokens as single source of truth; API-shaped static content; accessible interactions (aria labels, Escape to close, reduced motion, focus-visible handling); shared `navItems` for desktop and mobile
|
||||
- **Anti-patterns**: no-op `className` usage (see above); global body height hack
|
||||
- **Good Patterns**: API-shaped content; pure, property-tested helpers; tokens and recipes as single source of truth; configuration as code for headers; strong accessibility baseline (axe in tests, Lighthouse accessibility 1.0)
|
||||
- **Anti-patterns**: None significant found
|
||||
|
||||
Reference in New Issue
Block a user