Refreshes the shared reverse engineering docs, adds the requirements, application design and units for the homepage-sections feature, and updates the static design: live prices and form fields, the new Lieve woorden block and the coming-soon gate over the contact form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1.8 KiB
1.8 KiB
Code Quality Assessment
Test Coverage
- Overall: Good. Vitest with v8 coverage; 100% threshold enforced for
src/lib/**,src/seo.ts,src/sitemap.ts; other files reported - Unit Tests: Pure helpers, SEO, sitemap, monitoring config, security headers, server config (incl. drift check against
deploy/) - Component Tests: AppShell, NavigationBar, Footer, Hero (+ slider hook), BackToTop, PageIntro, StatusPage, Umami — with axe accessibility checks
- Property-based Tests: fast-check, shared arbitraries in
src/test/arbitraries.ts, seed logged in CI - Integration / E2E: No browser E2E; Lighthouse CI covers built pages (accessibility, best practices, SEO, performance)
Code Quality Indicators
- Linting: ESLint (typescript-eslint, react-hooks, jsx-a11y), enforced in CI
- Code Style: Consistent, Prettier-enforced in CI
- Documentation: Short Dutch comments explaining why, often referencing requirement IDs (FR-xx, BR-xx, NFR-xx, Mx) from earlier AI-DLC features
Technical Debt
- Homepage mobile Lighthouse performance target is lowered to 0.8 (images not responsive, title after JavaScript); back to 0.9 is planned with responsive images from the API and prerendering
- Five routes are placeholders (
noindex);lighthouserc.cjskeeps its own list of indexed/noindex paths, guarded by a test againstsitePages.ts - Static design images for the homepage sections (intro gallery, about photo, pricing decorations) are not yet in
web/src/assets - No responsive image pipeline (srcset/sizes); hero photos are single large JPEGs
Patterns and Anti-patterns
- Good Patterns: API-shaped content; pure, property-tested helpers; tokens and recipes as single source of truth; configuration as code for headers; strong accessibility baseline (axe in tests, Lighthouse accessibility 1.0)
- Anti-patterns: None significant found