Admin en bezoeker gebruiken dezelfde resource; alleen GET is anoniem, de rest vereist AdminOnly. OfferingAdminDto vervalt (displayOrder zit nu in OfferingDto), move-up/move-down zijn vervangen door de order-route die een onbekende of onvolledige lijst met 400 afwijst. De admin-frontend en alle tests zijn mee aangepast. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
4.1 KiB
Requirements Verification Questions — contact-forms-module
Input: contact-api-contract v0.3.1-draft (decisions by Bryan are not asked again). Only repo-specific or still-open points below. Answers may be given by "Redesign - SLS" (within Bryan's decisions) or by Bryan.
Question 1: Security Extensions
Should security extension rules be enforced for this feature?
- A) Yes — enforce all SECURITY rules as blocking constraints (recommended: public anonymous endpoint, PII, mail)
- B) No — skip all SECURITY rules
- X) Other (please describe after [Answer]: tag below)
[Answer]: A (Security Baseline enabled, per Bryan for the whole work) - answered by Redesign - SLS (technical lead) 2026-11-09
Question 2: Property-Based Testing Extension
Should property-based testing rules be enforced?
- A) Yes — all PBT rules
- B) Partial — only pure functions and serialization round-trips (validation rules, token/idempotency logic)
- C) No — skip all PBT rules
- X) Other (please describe after [Answer]: tag below)
[Answer]: B (partial: pure functions and serialization round-trips) - answered by Redesign - SLS (technical lead) 2026-11-09
Question 3: Operations phase
Should the Operations phase (deployment/monitoring/readiness) run for this feature? (Deployment already exists via the Gitea workflow.)
- A) No — closes after Build and Test; deployment follows existing workflow
- B) Yes — run the Operations phase
- C) Not sure yet — decide at Build and Test
- X) Other (please describe after [Answer]: tag below)
[Answer]: C (decide at Build and Test) - answered by Redesign - SLS (technical lead) 2026-11-09
Question 4: Module layout
Where does the new module live?
- A) New projects
SlpModularCms.Modules.Contact+SlpModularCms.Modules.Contact.Tests(own DbContext + migration, like Offerings), referenced by Api.SlpSoftware and Api.AndreaSlopFotografie (recommended) - B) Inside Modules.Offerings
- X) Other (please describe after [Answer]: tag below)
[Answer]: A - answered by Redesign - SLS (technical lead) 2026-11-09
Question 5: Database and migrations per host
Offerings uses MySQL with Database.Migrate() at startup. For the Contact module:
- A) Same approach: own DbContext, MySQL, additive migration applied at startup; migration regenerated after the rebase on identity-email-notifications (recommended)
- B) Reuse an existing DbContext (e.g. Core)
- X) Other (please describe after [Answer]: tag below)
[Answer]: A (migration regenerated after rebase) - answered by Redesign - SLS (technical lead) 2026-11-09
Question 6: Availability gate marker
Peer advice (ASF session): a [PublicSiteEndpoint] marker attribute in Core, read via endpoint metadata in AvailabilityMiddleware, deny-by-default, admin routes never exempt, /api/v1/Availability/status stays open. Own unit together with (b).
- A) Marker attribute (recommended)
- B) Prefix list next to the existing bypass list
- X) Other (please describe after [Answer]: tag below)
[Answer]: A ([PublicSiteEndpoint] marker, deny-by-default) - answered by Redesign - SLS (technical lead) 2026-11-09
Question 7: Reverse engineering
The _shared/reverse-engineering artifacts date from July 2026 (before Offerings, SlpSoftware and ASF hosts).
- A) Skip a full rerun; do a targeted review of the touched areas (Offerings, Email, rate limiter, Availability, capabilities, SecurityEvents) and record findings in the requirements (recommended)
- B) Full rerun
- X) Other (please describe after [Answer]: tag below)
[Answer]: A (targeted review; new MailKind, existing mail code untouched) - answered by Redesign - SLS (technical lead) 2026-11-09
Question 8: Admin UI scope
Unit (f) admin UI ("Berichten") is in the existing React admin (frontend/). The ASF session is still changing auth/refresh, users and theme assets there.
- A) Build (f) last, on the rebased branch after their merge, only touching new files plus the menu entry (recommended)
- B) Build it in parallel on the current base
- X) Other (please describe after [Answer]: tag below)
[Answer]: A (admin UI last, after ASF merge; report if the merge takes too long) - answered by Redesign - SLS (technical lead) 2026-11-09