Frontend (Unit 2 completion): dual dev-server tooling (pnpm dev:slave, pnpm dev:all), per-instance browser tab titles, and a backend capability check (SystemController + useSystemCapabilities + ModuleGuard) so a Master-only page is hidden on a slave instance instead of assuming every backend has every module. Master/slave protocol fixes surfaced by actually running master and slave side by side locally: - Deactivating a CMS instance (Inactive) now releases the slave's master gate instead of leaving it stuck on its last pushed status. - The periodic integrity check now also re-pushes status to every reachable slave (previously URL-verification only) and runs once immediately on startup. - Added the originally-specified (but never implemented) slave-pull path: a slave now periodically polls its own status from the master (GET /api/v1/SlaveStatus) and fails open to Available if the master is unreachable for too long, complementing the existing push. - The slave's own Settings page can no longer "successfully" change local availability while the master controls it; it's now locked with an explanatory banner and the backend rejects the write with 409 instead of silently no-op'ing it. - CMS instance status badges now match the dashboard's color/icon styling instead of a plain grey badge. Also corrected the master-cms-module design docs to match this as-built behavior, and flagged (without a full rewrite) a larger, pre-existing divergence between its inception-stage application design and what construction actually built. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
154 lines
6.0 KiB
C#
154 lines
6.0 KiB
C#
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.Options;
|
|
using SlpModularCms.Core.Availability;
|
|
using SlpModularCms.Core.Data;
|
|
using SlpModularCms.Core.Identity.Entities;
|
|
using SlpModularCms.Modules.Availability.Services;
|
|
using Xunit;
|
|
using FluentAssertions;
|
|
using NSubstitute;
|
|
|
|
namespace SlpModularCms.Modules.Availability.Tests;
|
|
|
|
public class PersistentAvailabilityServiceTests
|
|
{
|
|
private readonly ApplicationDbContext _context;
|
|
private readonly PersistentAvailabilityService _service;
|
|
|
|
public PersistentAvailabilityServiceTests()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(databaseName: Guid.NewGuid().ToString())
|
|
.Options;
|
|
_context = new ApplicationDbContext(options);
|
|
|
|
var availabilityOptions = Substitute.For<IOptions<AvailabilityOptions>>();
|
|
availabilityOptions.Value.Returns(new AvailabilityOptions { CircuitBreakerSeconds = 30 });
|
|
|
|
var masterAvailabilityService = Substitute.For<IMasterAvailabilityService>();
|
|
masterAvailabilityService.GetMasterStatus().Returns(new MasterGateStatus(true, null));
|
|
|
|
_service = new PersistentAvailabilityService(_context, availabilityOptions, masterAvailabilityService);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task IsAvailableAsync_ShouldReturnAvailable_WhenNoStateInDb()
|
|
{
|
|
// Act
|
|
var status = await _service.IsAvailableAsync();
|
|
|
|
// Assert
|
|
status.Should().Be(AvailabilityStatus.Available);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task UpdateStatusAsync_ShouldPersistInDb()
|
|
{
|
|
// Act
|
|
await _service.UpdateStatusAsync(AvailabilityStatus.Maintenance, "Maintenance mode", "Admin");
|
|
|
|
// Assert
|
|
var status = await _service.IsAvailableAsync();
|
|
status.Should().Be(AvailabilityStatus.Maintenance);
|
|
|
|
var dbState = await _context.AvailabilityStates.FirstAsync();
|
|
dbState.Status.Should().Be(AvailabilityStatus.Maintenance);
|
|
dbState.Message.Should().Be("Maintenance mode");
|
|
dbState.UpdatedBy.Should().Be("Admin");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task CircuitBreaker_ShouldReturnCachedStatus_AfterDatabaseError()
|
|
{
|
|
await _service.UpdateStatusAsync(AvailabilityStatus.Available, "Reset", "System");
|
|
_context.Dispose(); // Force DB error on next call
|
|
|
|
var status1 = await _service.IsAvailableAsync();
|
|
|
|
status1.Should().Be(AvailabilityStatus.Available); // Fallback
|
|
|
|
var status2 = await _service.IsAvailableAsync();
|
|
status2.Should().Be(AvailabilityStatus.Available); // From cache (circuit breaker active)
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetStatusDetailsAsync_ShouldReturnAvailable_WhenNoStateInDb()
|
|
{
|
|
var details = await _service.GetStatusDetailsAsync();
|
|
|
|
details.Status.Should().Be(AvailabilityStatus.Available);
|
|
details.Message.Should().BeNull();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetStatusDetailsAsync_ShouldReturnCorrectStatusAndMessage()
|
|
{
|
|
await _service.UpdateStatusAsync(AvailabilityStatus.Maintenance, "Scheduled maintenance", "Admin");
|
|
|
|
var details = await _service.GetStatusDetailsAsync();
|
|
|
|
details.Status.Should().Be(AvailabilityStatus.Maintenance);
|
|
details.Message.Should().Be("Scheduled maintenance");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetStatusDetailsAsync_ShouldReturnFallback_WhenDatabaseError()
|
|
{
|
|
await _service.UpdateStatusAsync(AvailabilityStatus.Available, null, "System");
|
|
_context.Dispose(); // Force DB error
|
|
|
|
var details = await _service.GetStatusDetailsAsync();
|
|
|
|
details.Status.Should().Be(AvailabilityStatus.Available); // Fallback
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetStatusDetailsAsync_ShouldReturnNotAvailable_WhenMasterGateDisabled()
|
|
{
|
|
var availabilityOptions = Substitute.For<IOptions<AvailabilityOptions>>();
|
|
availabilityOptions.Value.Returns(new AvailabilityOptions { CircuitBreakerSeconds = 30 });
|
|
|
|
var masterAvailabilityService = Substitute.For<IMasterAvailabilityService>();
|
|
masterAvailabilityService.GetMasterStatus().Returns(new MasterGateStatus(false, "Master heeft deze slave uitgeschakeld"));
|
|
|
|
var service = new PersistentAvailabilityService(_context, availabilityOptions, masterAvailabilityService);
|
|
|
|
var details = await service.GetStatusDetailsAsync();
|
|
|
|
details.Status.Should().Be(AvailabilityStatus.NotAvailable);
|
|
details.Message.Should().Be("Master heeft deze slave uitgeschakeld");
|
|
details.IsMasterControlled.Should().BeTrue();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task UpdateStatusAsync_UpdatesExistingRecord_WhenCalledTwice()
|
|
{
|
|
await _service.UpdateStatusAsync(AvailabilityStatus.Maintenance, "First update", "Admin1");
|
|
await _service.UpdateStatusAsync(AvailabilityStatus.Available, "Reset", "Admin2");
|
|
|
|
var status = await _service.IsAvailableAsync();
|
|
status.Should().Be(AvailabilityStatus.Available);
|
|
|
|
var dbState = await _context.AvailabilityStates.SingleAsync();
|
|
dbState.Status.Should().Be(AvailabilityStatus.Available);
|
|
dbState.UpdatedBy.Should().Be("Admin2");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task UpdateStatusAsync_Throws_WhenMasterControlsTheGate()
|
|
{
|
|
var availabilityOptions = Substitute.For<IOptions<AvailabilityOptions>>();
|
|
availabilityOptions.Value.Returns(new AvailabilityOptions { CircuitBreakerSeconds = 30 });
|
|
|
|
var masterAvailabilityService = Substitute.For<IMasterAvailabilityService>();
|
|
masterAvailabilityService.GetMasterStatus().Returns(new MasterGateStatus(false, "Uitgeschakeld door master"));
|
|
|
|
var service = new PersistentAvailabilityService(_context, availabilityOptions, masterAvailabilityService);
|
|
|
|
var act = async () => await service.UpdateStatusAsync(AvailabilityStatus.Available, null, "Admin");
|
|
|
|
await act.Should().ThrowAsync<MasterControlledAvailabilityException>();
|
|
(await _context.AvailabilityStates.FirstOrDefaultAsync()).Should().BeNull();
|
|
}
|
|
}
|