Files
SluijsensandClaude Sonnet 5.5 0bea72202b
Continuous Integration / config-sls (pull_request) Successful in 7s
Continuous Integration / config-asf (pull_request) Successful in 7s
Continuous Integration / changes (pull_request) Successful in 14s
Continuous Integration / frontend-prepare (pull_request) Successful in 26s
Continuous Integration / backend-build (pull_request) Successful in 2m0s
Continuous Integration / vulnerability-scan (pull_request) Successful in 2m3s
Continuous Integration / frontend-build (pull_request) Successful in 42s
Continuous Integration / frontend-lint (pull_request) Successful in 36s
Continuous Integration / frontend-test (pull_request) Successful in 2m23s
Continuous Integration / compile-sites (pull_request) Successful in 8m2s
Continuous Integration / backend-test (pull_request) Successful in 2m19s
Continuous Integration / publish-sls-test (pull_request) Skipped
Continuous Integration / publish-sls-production (pull_request) Skipped
Continuous Integration / deploy-sls-test (pull_request) Skipped
Continuous Integration / deploy-sls-production (pull_request) Skipped
Continuous Integration / publish-asf-test (pull_request) Skipped
Continuous Integration / deploy-asf-test (pull_request) Skipped
Continuous Integration / smoke-sls-test (pull_request) Skipped
Continuous Integration / smoke-asf-test (pull_request) Skipped
Docs: Hero afgesloten (Build and Test, release-checklist 4b, aannamelijst met besluiten van 2026-11-17)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-17 10:30:18 +01:00

2.4 KiB

Build and Test summary: hero-module

  • Closed: 2026-11-17 (Bryan: "the features work well"; accepted on the test hosts, relayed by SLP Software - SLS - Main)
  • Branch: feature/hero-module (master merged in before the PR)
  • Scope: Hero module H0 to H6 (image pipeline with background rendering, media store, backend, host injection, admin), including the changes made after the first test round: background renderer with progress and retry, tabs Content/Images, sticky save bar, per-photo "Processing finished", drag reorder, multi-upload, unsaved-changes guard, crop thumbnail with live preview, no hero-wide schedule or on/off (migration RemoveHeroScheduleAndSwitch), refresh-token race fix, renderer backlog log.

Result

Counts of the last full run are in the PR (CI runs SlpModularCms.Ci.slnf against MariaDB and the frontend pnpm run build, lint, test). Local runs before this closing: Hero.Tests 173, Core.Tests 925, Contact, Identity, Offerings, Availability, Master all pass; Api.Tests pass against a local MariaDB; frontend build, lint and 671 tests pass.

Verified on the test hosts

  • Upload and save fast on the Raspberry Pi (background rendering); a 4.4 MB photo finishes; progress, failed state and retry in the admin.
  • Anonymous smoke test (scripts/smoke-site.sh) on SLS-test and ASF-test: injected hero markers, no inline script in the admin, /theme-init.js served.
  • LCP/CLS with Lighthouse (mobile, 5 runs, median, 2026-11-17): SLS 0.71 score, LCP about 5.0 s (text, SPA bundle bound), CLS 0.00 after the SLS-side fix of the static packages list (it was 0.35, not caused by the hero); ASF 0.78 score, LCP about 5.0 s against 6.0 s for the baked page, CLS 0.00.

Not verified here (carried into the production checklist, section 4b)

  • A real iPhone HEIC upload (the build cannot write HEIC; only the library self-test ran).
  • Write access of the IIS application pool to the media directory on ASF production (Bryan to test with ASF).
  • Real Raspberry Pi timings in production on the final renderer, and a browser check of the layout (light/dark, narrow/wide, collapsed menu) of the new tabs and save bar.
  • The OpenAPI snapshot (openapi/slpsoftware.v1.json) was edited by hand after the schedule removal; CI regenerates and compares it.

Operations

Not run as a separate stage (Q19 = B). The points are in docs/release-checklist-productie.md, section 4b.