From 17de06ca86596ef7b5936aa5d8a890278f33068a Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Tue, 10 Nov 2026 15:57:07 +0100 Subject: [PATCH] Docs: feature identity-email-notifications afgesloten (productie 2026-11-10, run 639); andreaslop-site-hosting als afgehandeld gemarkeerd (via PR #11) Co-Authored-By: Claude Sonnet 5.5 --- aidlc-docs/active-features.md | 14 +++++++------- .../andreaslop-site-hosting/aidlc-state.md | 5 ++++- .../features/andreaslop-site-hosting/audit.md | 10 ++++++++++ .../identity-email-notifications/aidlc-state.md | 12 +++++++++++- .../identity-email-notifications/audit.md | 13 +++++++++++++ .../production-readiness-checklist.md | 17 ++++++++--------- 6 files changed, 53 insertions(+), 18 deletions(-) diff --git a/aidlc-docs/active-features.md b/aidlc-docs/active-features.md index 412a9c8..2f2020b 100644 --- a/aidlc-docs/active-features.md +++ b/aidlc-docs/active-features.md @@ -9,10 +9,10 @@ | Feature | Local Dev Master/Slave Setup (local-dev-master-slave-setup) | ✅ Complete | unknown | Modules.Master, Api, Frontend | 2026-07-02 | | Feature | Gitea Deployment Workflow (gitea-deployment-workflow) | 🟡 Operations (wacht op CI-proef en eerste test-deploy) | feature/gitea-deployment-workflow | CI/CD, Api (hosting/config), Core, Modules, Frontend (build), Docs | 2026-07-27 | | Feature | SlpSoftware Production API (slpsoftware-api) | ✅ Complete | feature/slpsoftware-api | Clients (new Api.SlpSoftware), Modules (new Offerings module + Tests), Core (CmsHost), CI/CD (retargeted to Api.SlpSoftware) | 2026-08-02 | -| Feature | Andrea's site hosting (andreaslop-site-hosting) | 🟡 Operations (wacht op CI-proef en eerste test-deploy) | feature/andreaslop-site-hosting | Core (CmsHost, CSP, static content), Clients (new Api.AndreaSlopFotografie), Frontend (theme), CI/CD | 2026-11-06 | -| Bug | [cms-admin-nine-points](bugs/cms-admin-nine-points/bug-fix.md) | ✅ Complete (wacht op goedkeuring ASF test) | feature/andreaslop-site-hosting | Core (auth, invitations), Identity, Availability, Frontend | 2026-11-08 | -| Bug | [invitation-delete-and-lifetime](bugs/invitation-delete-and-lifetime/bug-fix.md) | ✅ Complete (wacht op goedkeuring ASF test) | feature/andreaslop-site-hosting | Core (invitations), Identity, Frontend | 2026-11-08 | -| Feature | Identity e-mail notifications (identity-email-notifications) | 🔵 Inception (wacht op antwoorden) | feature/identity-email-notifications | Core (IEmailSender), Identity, Frontend | 2026-11-08 | -| Bug | [owner-cannot-promote-requester-identity](bugs/owner-cannot-promote-requester-identity/bug-fix.md) | ✅ Complete (wacht op ASF test deploy) | feature/identity-email-notifications | Identity (UsersController) | 2026-11-08 | -| Bug | [availability-gate-blocks-website-and-admin](bugs/availability-gate-blocks-website-and-admin/bug-fix.md) | ✅ Complete (wacht op deploy) | feature/identity-email-notifications | Availability (middleware) | 2026-11-09 | -| Bug | [setup-page-after-failed-status-read](bugs/setup-page-after-failed-status-read/bug-fix.md) | ✅ Complete (wacht op deploy) | feature/identity-email-notifications | Frontend (router guard, login), Identity (Setup limiter) | 2026-11-09 | +| Feature | Andrea's site hosting (andreaslop-site-hosting) | ✅ Complete (gemerged naar master via PR #11, 2026-11-10; ASF-productie op IIS apart) | feature/andreaslop-site-hosting | Core (CmsHost, CSP, static content), Clients (new Api.AndreaSlopFotografie), Frontend (theme), CI/CD | 2026-11-06 | +| Bug | [cms-admin-nine-points](bugs/cms-admin-nine-points/bug-fix.md) | ✅ Complete (gemerged via PR #11, 2026-11-10) | feature/andreaslop-site-hosting | Core (auth, invitations), Identity, Availability, Frontend | 2026-11-08 | +| Bug | [invitation-delete-and-lifetime](bugs/invitation-delete-and-lifetime/bug-fix.md) | ✅ Complete (gemerged via PR #11, 2026-11-10) | feature/andreaslop-site-hosting | Core (invitations), Identity, Frontend | 2026-11-08 | +| Feature | Identity e-mail notifications (identity-email-notifications) | ✅ Complete (in productie op SlpSoftware sinds 2026-11-10, master e671078) | feature/identity-email-notifications | Core (IEmailSender), Identity, Frontend | 2026-11-08 | +| Bug | [owner-cannot-promote-requester-identity](bugs/owner-cannot-promote-requester-identity/bug-fix.md) | ✅ Complete (gemerged via PR #11, 2026-11-10) | feature/identity-email-notifications | Identity (UsersController) | 2026-11-08 | +| Bug | [availability-gate-blocks-website-and-admin](bugs/availability-gate-blocks-website-and-admin/bug-fix.md) | ✅ Complete (gemerged via PR #11, 2026-11-10) | feature/identity-email-notifications | Availability (middleware) | 2026-11-09 | +| Bug | [setup-page-after-failed-status-read](bugs/setup-page-after-failed-status-read/bug-fix.md) | ✅ Complete (gemerged via PR #11, 2026-11-10) | feature/identity-email-notifications | Frontend (router guard, login), Identity (Setup limiter) | 2026-11-09 | diff --git a/aidlc-docs/features/andreaslop-site-hosting/aidlc-state.md b/aidlc-docs/features/andreaslop-site-hosting/aidlc-state.md index 51440a7..6e787d7 100644 --- a/aidlc-docs/features/andreaslop-site-hosting/aidlc-state.md +++ b/aidlc-docs/features/andreaslop-site-hosting/aidlc-state.md @@ -5,7 +5,7 @@ - **Feature Slug**: andreaslop-site-hosting - **Project Type**: Brownfield - **Start Date**: 2026-11-06T00:06:13Z -- **Current Stage**: OPERATIONS - Production Readiness (complete; waiting for CI proof and first test deploy) +- **Current Stage**: COMPLETE for the test environment - merged to master on 2026-11-10 through PR #11 (master e671078, together with identity-email-notifications). ASF production (IIS) is a separate piece of work. - **Branch**: feature/andreaslop-site-hosting - **Request Type**: Feature (two units: U1 core-site-hosting, U2 andreaslop-client) @@ -60,3 +60,6 @@ ### Production Readiness - **Verdict**: Yes with caveats (test only), see operations/production-readiness-checklist.md + +### Handled on 2026-11-10 +`feature/andreaslop-site-hosting` was never merged on its own. Its 24 commits were part of the ancestry of `feature/identity-email-notifications` and went to master with PR #11 (merge commit e671078). Nothing remains unmerged. ASF production on IIS is a separate, later piece of work (see `../identity-email-notifications/operations/deployment/deployment-plan.md`). diff --git a/aidlc-docs/features/andreaslop-site-hosting/audit.md b/aidlc-docs/features/andreaslop-site-hosting/audit.md index cf31cf4..fd83fc3 100644 --- a/aidlc-docs/features/andreaslop-site-hosting/audit.md +++ b/aidlc-docs/features/andreaslop-site-hosting/audit.md @@ -474,3 +474,13 @@ ## Redeploy after the invitation-link fix **Timestamp**: 2026-11-08 **Run**: 612 (dispatch, deploy_asf_test only), head 0908f42, all gates and deploy-asf-test green. Live: /health version 1.0.0+0908f42; /admin/invite/complete?token=x 200 text/html (SPA); old /invite/complete?token=x on ASF 404 website page (acceptable); /admin/ and favicon unchanged. + +--- + +## Merged to master + +**Timestamp**: 2026-11-10T18:00:00Z + +**AI Response**: "feature/andreaslop-site-hosting is handled: its 24 commits reached master through PR #11 (merge commit e671078) together with identity-email-notifications, as reported by the coordinating session after Bryan's approval. ASF production on IIS stays a separate piece of work." + +--- diff --git a/aidlc-docs/features/identity-email-notifications/aidlc-state.md b/aidlc-docs/features/identity-email-notifications/aidlc-state.md index 175072e..bbd8106 100644 --- a/aidlc-docs/features/identity-email-notifications/aidlc-state.md +++ b/aidlc-docs/features/identity-email-notifications/aidlc-state.md @@ -5,7 +5,7 @@ - **Feature Slug**: identity-email-notifications - **Project Type**: Brownfield - **Start Date**: 2026-11-08 -- **Current Stage**: OPERATIONS - code complete and on ASF test and SlpSoftware test; waiting for Bryan's testing of run 635 (65ee73f) on both test environments before any merge +- **Current Stage**: COMPLETE - operations done; in production on SlpSoftware since 2026-11-10 (run 639, master e671078) - **Branch**: feature/identity-email-notifications (branched from feature/andreaslop-site-hosting at e9feb37; own branch, not merged anywhere) - **Request Type**: Feature (Bryan chose real e-mail over a workaround button; relayed by session "CMS & API") @@ -68,3 +68,13 @@ - [x] Logout hang: with the CMS switched off (own setting or master) signing out froze the app. Cause: the AppLayout effect "NotAvailable -> go to /dashboard" also ran for a guest, which the authenticated route sent back to /login - an endless navigation loop. Fixed (only for an authenticated user); test `LogoutWhileCmsOff.test.tsx` never finished on the old code. - [ ] Not built, decisions with Bryan: own rate-limit policy for `Setup/status`, judge the admin token only when a request is really blocked, a visible error state with "Reload" and a fetch timeout (see `../contact-feature/contact-feature-prereqs.md`, local commit 3f060a8, not pushed). - Merge to master: **not approved**. Bryan wants to test both test environments first (including run 635 / 65ee73f); the CMS session may merge later on his explicit go (Gitea PR with merge commit and green CI unless he chooses otherwise). + +### Completion (2026-11-10, relayed by "CMS & API" from Bryan) +- [x] Everything tested and approved by Bryan on both test environments (ASF test, SlpSoftware test): mails (light and dark, Gmail app and Thunderbird), disabling the CMS and signing out while disabled, ASF status and poll, role change, owner. CI run 636 (2818b74) green. +- [x] Merged to master on 2026-11-10 through PR #11 (merge commit e671078; 66 commits, including the 24 of `feature/andreaslop-site-hosting`, which was never merged separately and is therefore handled by the same PR). +- [x] SlpSoftware production deployed 2026-11-10 (run 639, master e671078); Pi-Main reports it healthy: mail on, migrations applied, no master-URL warnings, `/health` 200. +- [x] `MasterModule__MasterUrl` set on the test and the production master host. +- [ ] Not built (decisions with Bryan, kept in `../contact-feature/contact-feature-prereqs.md`): own rate-limit policy for `Setup/status`, judging the admin token only on a real block, a visible error state with "Reload" and a fetch timeout. The availability-gate change (public routes never 503) belongs to the contact feature. +- Open recommendation for Bryan: check SPF/DKIM/DMARC alignment on a real production mail ("show original" in Gmail and Outlook). +- Out of scope, separate piece of work: ASF production on IIS (see `operations/deployment/deployment-plan.md`). +- Follow-up: the contact feature (prerequisites in `../contact-feature/contact-feature-prereqs.md`). diff --git a/aidlc-docs/features/identity-email-notifications/audit.md b/aidlc-docs/features/identity-email-notifications/audit.md index 0226c3f..0daadca 100644 --- a/aidlc-docs/features/identity-email-notifications/audit.md +++ b/aidlc-docs/features/identity-email-notifications/audit.md @@ -132,3 +132,16 @@ --- +--- + +## Feature closed + +**Timestamp**: 2026-11-10T18:00:00Z + +**User Input**: "(Relayed by 'CMS & API', Bryan's decisions) Everything is approved; merge, release and finish the AI-DLC flow. Close identity-email-notifications on a new branch from master: state to COMPLETE, audit, production readiness, mark andreaslop-site-hosting as handled, point to the contact-feature prerequisites." + +**AI Response**: "Recorded: PR #11 merged (master e671078, 66 commits including the 24 of feature/andreaslop-site-hosting); SlpSoftware production deployed through run 639 and reported healthy by Pi-Main (mail on, migrations applied, no master-URL warnings, /health 200); MasterModule__MasterUrl set on the test and production master hosts. Not built, on purpose: own rate-limit policy for Setup/status, judging the admin token only on a real block, an error state with Reload, a fetch timeout (decisions left to Bryan, listed in the contact-feature prerequisites) - none of them blocks this feature. Recommended to Bryan: an SPF/DKIM/DMARC check of a real production mail. ASF production on IIS stays a separate piece of work." + +**Context**: Operations complete; feature complete. Facts about production and the approvals are as reported by the coordinating session, not verified by this session. + +--- diff --git a/aidlc-docs/features/identity-email-notifications/operations/production-readiness-checklist.md b/aidlc-docs/features/identity-email-notifications/operations/production-readiness-checklist.md index 3ec4e68..99a1f67 100644 --- a/aidlc-docs/features/identity-email-notifications/operations/production-readiness-checklist.md +++ b/aidlc-docs/features/identity-email-notifications/operations/production-readiness-checklist.md @@ -29,14 +29,13 @@ Scope: ASF test and SlpSoftware test now; SlpSoftware production after Bryan's a - **Production secrets wired to env vars/secrets manager**: Yes: `Email__Smtp__Username/Password` in the host's environment file (Pi). For IIS see the open point. ## Open Points -1. **ASF production on IIS** (decided 2026-11-09): not worked out here. The Pi-specific assumptions (systemd unit, `shared/env`, journalctl, scp deploy, reverse-proxy Pi) and what changes on IIS are listed in `deployment/deployment-plan.md`; a later ASF-production feature must settle them (environment variables and secrets, restart, logs, deploy path, hosting model, database and mail-server reachability). -2. Sentry alert rule to be created (monitoring setup). -3. Real test mails on ASF test and SlpSoftware test. -4. Merge to master / SlpSoftware production: not approved yet (the branch is already on ASF test and SlpSoftware test). Bryan first tests both test environments including run 635 (65ee73f: logout hang, mail card gutter); the merge then happens on his explicit go. -5. Per-site DMARC tightening later (stays `p=none` now). -6. Confirm the dark-mode mail card in the Gmail app (Gmail and non-Gmail account) and Outlook with a real test mail; the layout uses inline styles and Outlook selectors but the clients' own colour conversion cannot be tested in code. -7. Decisions left to Bryan (not built): own rate-limit policy for `Setup/status`, judging the admin token only on a real block (log noise), a visible error state with "Reload" and a fetch timeout; the contact-feature gate change is in `features/contact-feature/contact-feature-prereqs.md`. -8. CI of run 635 (65ee73f) was not confirmed green when this was written. +1. **ASF production on IIS** (decided 2026-11-09): not worked out here and not part of this feature. The Pi-specific assumptions (systemd unit, `shared/env`, journalctl, scp deploy, reverse-proxy Pi) and what changes on IIS are listed in `deployment/deployment-plan.md`; a later ASF-production feature must settle them. Still open. +2. Sentry alert rule: exists (reported 2026-11-10). +3. Real test mails on ASF test and SlpSoftware test: done and approved by Bryan (light and dark, Gmail app and Thunderbird). +4. Merge and SlpSoftware production: done. PR #11 merged (master e671078), production run 639 on 2026-11-10, healthy per Pi-Main (mail on, migrations applied, no master-URL warnings, `/health` 200). CI green (run 636 on the branch). +5. `MasterModule__MasterUrl` set on the test and the production master host: done (the variable name is `MasterModule__MasterUrl`). +6. **Recommendation, still open:** check SPF, DKIM and DMARC alignment on a real production mail ("show original" in Gmail and Outlook). Per-site DMARC tightening stays for later (`p=none` now). +7. Decisions left to Bryan, not built (none blocks production): own rate-limit policy for `Setup/status`, judging the admin token only on a real block (log noise), a visible error state with "Reload" and a fetch timeout. The availability-gate change for public routes belongs to the contact feature: see `../../contact-feature/contact-feature-prereqs.md`. ## Overall Readiness -- **Ready for Production**: Not yet. SlpSoftware production needs the real test mails, the alert rule and Bryan's approval; ASF production is a separate piece of work. +- **Ready for Production**: Yes for SlpSoftware (in production since 2026-11-10). ASF production is a separate piece of work (IIS), not covered here. -- 2.39.5