Docs: aidlc-state, audit en production-readiness-checklist bijgewerkt met de fixes en bevindingen van 9-10 nov (o.a. MasterModule__MasterUrl)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-10 00:12:27 +01:00
co-authored by Claude Sonnet 5.5
parent 3f060a89fc
commit d8d150e10d
3 changed files with 33 additions and 2 deletions
@@ -5,7 +5,7 @@
- **Feature Slug**: identity-email-notifications
- **Project Type**: Brownfield
- **Start Date**: 2026-11-08
- **Current Stage**: CONSTRUCTION - U1 and U2 code generated and tested; requirements and design approved by Bryan (relayed), D1 and D2 decided
- **Current Stage**: OPERATIONS - code complete and on ASF test and SlpSoftware test; waiting for Bryan's testing of run 635 (65ee73f) on both test environments before any merge
- **Branch**: feature/identity-email-notifications (branched from feature/andreaslop-site-hosting at e9feb37; own branch, not merged anywhere)
- **Request Type**: Feature (Bryan chose real e-mail over a workaround button; relayed by session "CMS & API")
@@ -58,3 +58,13 @@
- [x] Monitoring Setup - Q4 B (config-related mail failures at Error), Q5 A; log-level change built and tested; operations/monitoring/*
- [x] Production Readiness - checklist written; verdict: not yet (real test mails, Sentry rule, Bryan's approval); operations/production-readiness-checklist.md
- Open for a later feature: ASF production on IIS (hosting assumptions listed in operations/deployment/deployment-plan.md)
### Late fixes after the first test deploys (2026-11-09/10, all on the branch)
- [x] Mail layout: SLP red, dark-mode button, logo swap (dark variant) and white badge, site name next to the logo, dark card that stands out (page `#0a0e14`, card `#273244`, 1px border), inline card border `#d1d5db` and Outlook `data-ogsb`/`data-ogsc` rules, 16 px gutter around the card. Light mode unchanged. Real behaviour in the Gmail app (Gmail and non-Gmail account) and Outlook still to be confirmed by a real test mail.
- [x] Master/slave status: the slave's fail-open grace period now runs from the master's last contact (poll, push, registration), not from the last successful poll (a pushed "not available" fell open at the next failed poll). Poll failures log `master_poll_failed reason=... detail=...` (first stack frame, `url_absolute`, `scheme`, `key_present`; never URL, key or message).
- [x] Master URL: the shipped `appsettings.json` holds a placeholder; the hourly/start-up integrity check (no request) used it and re-registered slaves with it, so their polls failed. Now `MasterUrlRules` (absolute http(s), no credentials/query/fragment): the master skips background checks on an unusable value (warning), a slave refuses one (400 `invalid_master_url`), the poller reports `invalid_master_url`. **The variable is `MasterModule__MasterUrl`** (section `MasterModule`); an earlier note said `Master__MasterUrl`, which is never bound - corrected in `operations/deployment/deployment-plan.md`.
- [x] Availability gate: an expired token on a blocked route answers 401 (not 503) so the app refreshes its session and passes as admin; missing, forged, wrong-key and non-admin tokens stay 503.
- [x] Session at start-up: a refresh without a verdict (429/5xx/network) ends in an "unreachable" retry screen, not as a guest; Retry-After is sent (refresh 15 s) and honoured (max 15 s per wait).
- [x] Logout hang: with the CMS switched off (own setting or master) signing out froze the app. Cause: the AppLayout effect "NotAvailable -> go to /dashboard" also ran for a guest, which the authenticated route sent back to /login - an endless navigation loop. Fixed (only for an authenticated user); test `LogoutWhileCmsOff.test.tsx` never finished on the old code.
- [ ] Not built, decisions with Bryan: own rate-limit policy for `Setup/status`, judge the admin token only when a request is really blocked, a visible error state with "Reload" and a fetch timeout (see `../contact-feature/contact-feature-prereqs.md`, local commit 3f060a8, not pushed).
- Merge to master: **not approved**. Bryan wants to test both test environments first (including run 635 / 65ee73f); the CMS session may merge later on his explicit go (Gitea PR with merge commit and green CI unless he chooses otherwise).