CI: jobnamen {actie}-{site}-{omgeving} (config-sls, publish/deploy-sls-test/-production); docs en merge-checklist bijgewerkt

Inputs (deploy_test, deploy_production, deploy_asf_test) en config-outputs ongewijzigd.
Branch protection: vereiste check publish-test (pull_request) moet publish-sls-test (pull_request) worden.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-15 14:29:57 +01:00
co-authored by Claude Sonnet 5.5
parent d8141db050
commit d63ba28cdc
6 changed files with 54 additions and 48 deletions
@@ -402,14 +402,14 @@ server {
}
```
#### 1.7.3 Artifact Upload Body Size (413 on `publish-test`/`publish-production`)
#### 1.7.3 Artifact Upload Body Size (413 on `publish-sls-test`/`publish-sls-production`)
The Gitea instance itself (`gitea.slpsoftware.nl`) sits behind the same proxy Pi as every other
domain in § 1.7 — Actions' own web UI/API traffic is proxied through it exactly like
`test.slpsoftware.nl` and `slpsoftware.nl` are. Gitea Actions' artifact upload
(`actions/upload-artifact`) sends the build output in chunks; if a chunk exceeds nginx's
`client_max_body_size` (default 1m), nginx itself rejects it with `413 Request Entity Too Large`
before the request ever reaches Gitea — surfacing in the `publish-test`/`publish-production` job log
before the request ever reaches Gitea — surfacing in the `publish-sls-test`/`publish-sls-production` job log
as repeated `A 413 status code has been received, will attempt to retry the upload` followed by
`Retry limit has been reached` on individual files once the action's retries are exhausted.
@@ -433,9 +433,9 @@ http {
sudo nginx -t && sudo systemctl reload nginx
```
#### 1.7.4 Never Re-Run `deploy-test`/`deploy-production` Alone — Gitea Platform Limitation
#### 1.7.4 Never Re-Run `deploy-sls-test`/`deploy-sls-production` Alone — Gitea Platform Limitation
`deploy-test` and `deploy-production` in `continuous_integration.yaml` are not ordinary jobs — each
`deploy-sls-test` and `deploy-sls-production` in `continuous_integration.yaml` are not ordinary jobs — each
one *calls* the reusable `deploy-scp.yaml` workflow (`uses: ./.gitea/workflows/deploy-scp.yaml`).
Re-running **only** one of these two jobs after a failure (Gitea's per-job "re-run" action) is a
known Gitea Actions limitation, not a bug in either workflow file here: Gitea does not cleanly resume
@@ -446,7 +446,7 @@ List Artifacts - Error is not retryable
Status Code: 404
Error: List Artifacts failed: Artifact service responded with 404
```
even though `publish-test`/`publish-production` genuinely succeeded and uploaded the artifact
even though `publish-sls-test`/`publish-sls-production` genuinely succeeded and uploaded the artifact
moments earlier in the same run (retention had not expired — this is not the same failure mode as
§ 1.7.3, and not a retention issue at all).
@@ -466,13 +466,13 @@ This matches a documented behaviour of Actions-style re-run implementations, see
GitHub's own tooling ([cli/cli#13522](https://github.com/cli/cli/issues/13522)): re-running an
*existing* run can replay against secrets/variables as they were **when that run was first created**,
not their current values — particularly for a job that calls a reusable workflow with
`secrets: inherit` (exactly what `deploy-test`/`deploy-production` do here). The documented contract
`secrets: inherit` (exactly what `deploy-sls-test`/`deploy-sls-production` do here). The documented contract
("secrets are fetched at the time of the re-run") does not hold in practice for this case. A genuinely
**new** run (fresh push, or `workflow_dispatch`) always fetches current values correctly — only
re-running an existing run risks the stale snapshot.
**Net effect of § 1.7.4 + § 1.7.5 together**: neither of Gitea's two "re-run" options is fully safe
for `deploy-test`/`deploy-production` — "re-run this job alone" loses the artifact, "re-run all jobs"
for `deploy-sls-test`/`deploy-sls-production` — "re-run this job alone" loses the artifact, "re-run all jobs"
can keep stale secrets. **The one reliable option is to trigger a brand new run** (an actual push, or
`workflow_dispatch`'s "Run workflow" button) rather than using either re-run action on a failed run,
whenever a secret or variable was just changed to fix that failure. Re-running an existing run is
@@ -531,12 +531,12 @@ Current compact overview, including the ASF test jobs and deploying a branch: `d
Already built (U5/U6) — this is the read-only walkthrough for whoever operates it:
1. Push to `master`, or a manual `workflow_dispatch` (inputs `deploy_test`, `deploy_production`, `deploy_asf_test`, all off by default) → the gates run (`changes`, `backend-build`, `backend-test`, `vulnerability-scan`, `frontend-prepare`, `frontend-build`, `frontend-test`, `frontend-lint`)
2. `publish-test` runs on a push to `master`, on pull requests (build only, no deploy) and on a dispatch with `deploy_test`; `publish-production` only on a dispatch with `deploy_production`
3. `deploy-test` (on a push to `master`, or a dispatch with `deploy_test`; not on pull requests) calls `deploy-scp.yaml`, which uploads into a new
2. `publish-sls-test` runs on a push to `master`, on pull requests (build only, no deploy) and on a dispatch with `deploy_test`; `publish-sls-production` only on a dispatch with `deploy_production`
3. `deploy-sls-test` (on a push to `master`, or a dispatch with `deploy_test`; not on pull requests) calls `deploy-scp.yaml`, which uploads into a new
`releases/{timestamp}/`, links `shared/wwwroot-web` and any `shared/modules/*.dll` in, switches
`current`, restarts `slpsoftware-test.service`, verifies `https://test.slpsoftware.nl/health`,
then prunes old releases (only test — `run_db_backup: false`)
4. `deploy-production` (only with the flag) does the same, plus a database backup first
4. `deploy-sls-production` (only with the flag) does the same, plus a database backup first
(`run_db_backup: true`) — see § 4
## 3. First-Ever Deploy Notes
@@ -634,7 +634,7 @@ section documents what actually changes when that day comes (OPEN-04 — not sch
per Q5 = B of the deployment setup plan).
### 5.1 What carries over unchanged
- The CI workflow's gates, the two-build split, the `config` job pattern
- The CI workflow's gates, the two-build split, the `config-sls` job pattern
- The overall shape of the interface: `artifact_name`, `environment`, `deploy_path`
### 5.2 What does not carry over — read this before assuming it's a drop-in swap
@@ -25,7 +25,7 @@ there is no separate DSN per environment.
| Variable | Value |
|---|---|
| `VITE_SENTRY_DSN` | the project's DSN (same value used by both `publish-test` and `publish-production`) |
| `VITE_SENTRY_DSN` | the project's DSN (same value used by both `publish-sls-test` and `publish-sls-production`) |
### 1.2 Host configuration
@@ -14,7 +14,7 @@ as the artifact built, tested, and deployed to `test.slpsoftware.nl` / `slpsoftw
| File | Change |
|---|---|
| `.gitea/workflows/continuous_integration.yaml` | `publish-test`/`publish-production`'s "Build admin frontend" and "Publish" steps retargeted from `src/SlpModularCms.Api` to `src/SlpModularCms.Api.SlpSoftware` (6 lines). Everything else — the six CI gates, `deploy-scp.yaml` calls, Gitea variables/secrets, `SlpModularCms.Api.Tests` (Unit 1's own regression suite, scoped to `Api` per NFR-CS-01) — is unchanged. |
| `.gitea/workflows/continuous_integration.yaml` | `publish-sls-test`/`publish-sls-production`'s "Build admin frontend" and "Publish" steps retargeted from `src/SlpModularCms.Api` to `src/SlpModularCms.Api.SlpSoftware` (6 lines). Everything else — the six CI gates, `deploy-scp.yaml` calls, Gitea variables/secrets, `SlpModularCms.Api.Tests` (Unit 1's own regression suite, scoped to `Api` per NFR-CS-01) — is unchanged. |
| `deploy-scp.yaml` | **No change.** It never hardcodes an entry-point `.dll` name; it uploads whatever the artifact contains and restarts a `service_name` input string. |
| `gitea-deployment-workflow/operations/deployment/deployment-instructions.md` § 1.6 | systemd unit `ExecStart` documentation updated to `SlpModularCms.Api.SlpSoftware.dll`, with an explicit note that this is a manual, host-side edit for already-existing units — this session cannot reach the Pi to apply it. |
| `rollback-plan.md` | **No change.** Operates on the release-directory/symlink level, not a specific `.dll` name. |