Aanbod: RESTful routes zonder /admin, één OfferingDto en herordenen via PUT /offerings/order
Admin en bezoeker gebruiken dezelfde resource; alleen GET is anoniem, de rest vereist AdminOnly. OfferingAdminDto vervalt (displayOrder zit nu in OfferingDto), move-up/move-down zijn vervangen door de order-route die een onbekende of onvolledige lijst met 400 afwijst. De admin-frontend en alle tests zijn mee aangepast. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { beforeEach, describe, expect, it } from 'vitest';
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { screen } from '@testing-library/react';
|
||||
import userEvent from '@testing-library/user-event';
|
||||
import { http, HttpResponse } from 'msw';
|
||||
@@ -13,7 +13,7 @@ beforeEach(() => {
|
||||
resetMockOfferings();
|
||||
});
|
||||
|
||||
const OFFERINGS_URL = `${API_BASE}/api/v1/offerings/admin`;
|
||||
const OFFERINGS_URL = `${API_BASE}/api/v1/offerings`;
|
||||
|
||||
describe('OfferingsListPage', () => {
|
||||
it('renders the page title and Add button', async () => {
|
||||
@@ -86,6 +86,32 @@ describe('OfferingsListPage', () => {
|
||||
).toBeDisabled();
|
||||
});
|
||||
|
||||
it('moves a row down by sending the full new order to PUT /offerings/order', async () => {
|
||||
mockAuthenticated();
|
||||
let sentBody: { orderedIds: string[] } | undefined;
|
||||
server.use(
|
||||
http.put(`${OFFERINGS_URL}/order`, async ({ request }) => {
|
||||
sentBody = (await request.json()) as { orderedIds: string[] };
|
||||
return new HttpResponse(null, { status: 204 });
|
||||
}),
|
||||
);
|
||||
renderApp('/offerings');
|
||||
|
||||
await userEvent.click(
|
||||
await screen.findByTestId(
|
||||
'offering-row-aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa-move-down-button',
|
||||
{},
|
||||
{ timeout: 10000 },
|
||||
),
|
||||
);
|
||||
|
||||
await vi.waitFor(() =>
|
||||
expect(sentBody).toEqual({
|
||||
orderedIds: ['bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb', 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa'],
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it('redirects unauthenticated users to login', async () => {
|
||||
mockGuest();
|
||||
renderApp('/offerings');
|
||||
|
||||
@@ -7,11 +7,11 @@ import { OfferingsList } from '../components/OfferingsList';
|
||||
import { DeleteOfferingDialog } from '../components/DeleteOfferingDialog';
|
||||
import { useOfferings } from '../services/useOfferings';
|
||||
import { useDeleteOffering } from '../services/useDeleteOffering';
|
||||
import type { OfferingAdminDto } from '../services/types';
|
||||
import type { OfferingDto } from '../services/types';
|
||||
|
||||
export function OfferingsListPage() {
|
||||
const { t } = useTranslation();
|
||||
const [offeringPendingDelete, setOfferingPendingDelete] = useState<OfferingAdminDto | null>(null);
|
||||
const [offeringPendingDelete, setOfferingPendingDelete] = useState<OfferingDto | null>(null);
|
||||
const { data: offerings, isPending, isError } = useOfferings();
|
||||
const deleteOffering = useDeleteOffering({
|
||||
onSuccess: () => setOfferingPendingDelete(null),
|
||||
|
||||
Reference in New Issue
Block a user