Fixes mobile sidebar collapsing to content height instead of filling the overlay
Continuous Integration / config (pull_request) Successful in 9s
Continuous Integration / backend-build (pull_request) Successful in 5m9s
Continuous Integration / vulnerability-scan (pull_request) Successful in 4m28s
Continuous Integration / frontend-prepare (pull_request) Successful in 1m53s
Continuous Integration / backend-test (pull_request) Successful in 5m29s
Continuous Integration / frontend-build (pull_request) Successful in 2m16s
Continuous Integration / frontend-test (pull_request) Successful in 4m42s
Continuous Integration / frontend-lint (pull_request) Successful in 1m54s
Continuous Integration / publish-production (pull_request) Skipped
Continuous Integration / deploy-production (pull_request) Skipped
Continuous Integration / publish-test (pull_request) Successful in 6m37s
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / config (pull_request) Successful in 9s
Continuous Integration / backend-build (pull_request) Successful in 5m9s
Continuous Integration / vulnerability-scan (pull_request) Successful in 4m28s
Continuous Integration / frontend-prepare (pull_request) Successful in 1m53s
Continuous Integration / backend-test (pull_request) Successful in 5m29s
Continuous Integration / frontend-build (pull_request) Successful in 2m16s
Continuous Integration / frontend-test (pull_request) Successful in 4m42s
Continuous Integration / frontend-lint (pull_request) Successful in 1m54s
Continuous Integration / publish-production (pull_request) Skipped
Continuous Integration / deploy-production (pull_request) Skipped
Continuous Integration / publish-test (pull_request) Successful in 6m37s
Continuous Integration / deploy-test (pull_request) Skipped
The aside had no explicit height, so it stretched to full height on desktop only because its flex-row parent applies align-items:stretch. In the mobile SidebarOverlay it sits in a plain (non-flex) h-full div, so it shrank to fit its nav items, pushing settings/profile up under the nav instead of staying pinned to the bottom.
This commit is contained in:
@@ -54,7 +54,7 @@ export function Sidebar({ onClose }: SidebarProps = {}) {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<aside
|
<aside
|
||||||
className="flex w-64 shrink-0 flex-col border-r border-border bg-card"
|
className="flex h-full w-64 shrink-0 flex-col border-r border-border bg-card"
|
||||||
data-testid="app-sidebar"
|
data-testid="app-sidebar"
|
||||||
>
|
>
|
||||||
<div className="flex h-16 items-center justify-between border-b border-border px-6">
|
<div className="flex h-16 items-center justify-between border-b border-border px-6">
|
||||||
|
|||||||
Reference in New Issue
Block a user