Makes the application say what it is doing and when it fails
U4. Console logging plus Sentry, a same-origin tunnel so ad blockers cannot silence browser errors, Umami on the admin SPA, and six security events that alert rules can actually be built on. The correlation id is the W3C trace id from the ambient Activity, enabled by one line of ActivityTrackingOptions so every entry from every category carries it without touching a call site. It propagates across the master/slave boundary via traceparent, which TraceIdentifier cannot do at all, and it is the same value ProblemDetails already returns to the browser. The security events use source-generated LoggerMessage with constant templates. Sentry groups log events by message, so interpolating an email address would give every address its own issue and "more than 20 failed logins in five minutes" could never fire — the events would arrive, be visible, be tagged, and the alerting would silently be impossible. A test asserts the rendered message is identical across argument values. Scrubbing happens in-process, before transmission, and covers Set-Cookie as well as Cookie: the login response issues the refreshToken there, so scrubbing only the request side would protect nothing. Transactions are scrubbed too, because they carry request data and are the channel nobody thinks of. The tunnel derives its destination from the DSN once at startup and reads nothing from the request, which is what separates a tunnel from a server-side request forgery primitive. Size is capped by a bounded read rather than by trusting Content-Length, and the endpoint is rate limited. Two things found along the way. Zod 4's url() hands the value to the URL constructor, which accepts any scheme — so the existing frontend validation would have accepted the exact "htp://" typo BR-U4-24 names, and the SPA would have called a nonexistent origin. Now constrained to http(s). And the new appsettings comments are verified against the real configuration provider, because the failure mode if it rejected them is both hosts refusing to start after a release switch. One deviation. IAdminTokenValidator was meant to gain a reason-reporting overload; implemented that way, a substitute returning false by default silently inverted the access decision while both methods compiled. Two methods whose difference is invisible at the call site is the defect, so it is now a single Validate returning AdminTokenResult. Touches two files from already-committed units: DatabaseMigrationExtensions (U2) gains a flush before the rethrow, or the one Critical event in the system dies with the process; AdminTokenValidator (U1) classifies why a bypass was refused. Build 0 errors; 366 backend tests pass, up from 315, and 237 frontend tests, up from 213. tsc clean, eslint clean on every changed file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HHoJpxYXzHACSQguHrC5fw
This commit is contained in:
@@ -0,0 +1,133 @@
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Configuration;
|
||||
using Microsoft.Extensions.DependencyInjection;
|
||||
using Microsoft.Extensions.Options;
|
||||
using SlpModularCms.Core.Hosting.Observability;
|
||||
using SlpModularCms.Core.Hosting.Security;
|
||||
using Xunit;
|
||||
|
||||
namespace SlpModularCms.Core.Tests.Hosting;
|
||||
|
||||
/// <summary>
|
||||
/// Loads the committed <c>appsettings.json</c> of both hosts and runs the startup validators
|
||||
/// against them.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// Everything asserted here is a startup failure in production if it is wrong, which means the
|
||||
/// symptom is a host that will not boot after a release switch. Two specific reasons this exists:
|
||||
///
|
||||
/// The files carry <c>//</c> comments explaining non-obvious values. The JSON configuration
|
||||
/// provider does tolerate them, but "does tolerate" is worth verifying rather than assuming when
|
||||
/// the failure mode is both hosts refusing to start.
|
||||
///
|
||||
/// And <c>SecurityHeaders</c> policy names are validated with <c>ValidateOnStart</c>, so a typo in
|
||||
/// the committed file stops the process. Better to fail here than in a deployment.
|
||||
/// </remarks>
|
||||
public class DeployedConfigurationTests
|
||||
{
|
||||
public static TheoryData<string> HostConfigurations => new()
|
||||
{
|
||||
Path.Combine("host-config", "master.appsettings.json"),
|
||||
Path.Combine("host-config", "slave.appsettings.json")
|
||||
};
|
||||
|
||||
private static IConfigurationRoot Load(string relativePath)
|
||||
{
|
||||
File.Exists(relativePath).Should().BeTrue($"'{relativePath}' should be copied to the test output");
|
||||
|
||||
return new ConfigurationBuilder()
|
||||
.AddJsonFile(relativePath, optional: false)
|
||||
.Build();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[MemberData(nameof(HostConfigurations))]
|
||||
public void HostConfiguration_ShouldParse_IncludingItsComments(string relativePath)
|
||||
{
|
||||
var act = () => Load(relativePath);
|
||||
|
||||
act.Should().NotThrow();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[MemberData(nameof(HostConfigurations))]
|
||||
public void HostConfiguration_ShouldPassSecurityHeadersStartupValidation(string relativePath)
|
||||
{
|
||||
var services = new ServiceCollection();
|
||||
services.AddLogging();
|
||||
services.AddCmsSecurityHeaders(Load(relativePath));
|
||||
|
||||
var act = () => services.BuildServiceProvider().GetRequiredService<IStartupValidator>().Validate();
|
||||
|
||||
act.Should().NotThrow();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[MemberData(nameof(HostConfigurations))]
|
||||
public void HostConfiguration_ShouldShipWithoutASentryDsn(string relativePath)
|
||||
{
|
||||
var options = Load(relativePath)
|
||||
.GetSection(ObservabilityOptions.SectionName)
|
||||
.Get<ObservabilityOptions>();
|
||||
|
||||
options.Should().NotBeNull();
|
||||
// A DSN identifies a project and belongs to an account. It is supplied per environment as
|
||||
// Observability__SentryDsn; the repository is not where it should be written down.
|
||||
options!.IsSentryConfigured.Should().BeFalse();
|
||||
options.TunnelMaxPayloadBytes.Should().BeGreaterThan(0);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// At <c>Information</c>, EF's command logging prints every SQL statement including parameter
|
||||
/// values, and the login path passes a normalised email address through it. Raising the
|
||||
/// default log level without pinning this category would start writing that to the console and
|
||||
/// to Sentry breadcrumbs.
|
||||
/// </summary>
|
||||
[Theory]
|
||||
[MemberData(nameof(HostConfigurations))]
|
||||
public void HostConfiguration_ShouldPinEfCommandLoggingBelowInformation(string relativePath)
|
||||
{
|
||||
var level = Load(relativePath)["Logging:LogLevel:Microsoft.EntityFrameworkCore.Database.Command"];
|
||||
|
||||
level.Should().Be("Warning");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Sentry breadcrumbs are capped by the logging level, so leaving the default at Warning would
|
||||
/// deliver every event with an empty breadcrumb trail — the feature present, configured, and
|
||||
/// useless.
|
||||
/// </summary>
|
||||
[Theory]
|
||||
[MemberData(nameof(HostConfigurations))]
|
||||
public void HostConfiguration_ShouldAllowInformationLevelLogging(string relativePath)
|
||||
{
|
||||
var configuration = Load(relativePath);
|
||||
|
||||
configuration["Logging:LogLevel:Default"].Should().Be("Information");
|
||||
configuration["Logging:LogLevel:Microsoft.AspNetCore"].Should().Be("Information");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[MemberData(nameof(HostConfigurations))]
|
||||
public void HostConfiguration_ShouldRateLimitTheSentryTunnel(string relativePath)
|
||||
{
|
||||
var configuration = Load(relativePath);
|
||||
|
||||
configuration.GetValue<int>("RateLimiting:SentryTunnel:PermitLimit").Should().BeGreaterThan(0);
|
||||
configuration.GetValue<int>("RateLimiting:SentryTunnel:WindowSeconds").Should().BeGreaterThan(0);
|
||||
}
|
||||
|
||||
/// <summary>The admin SPA must never fall to the relaxed policy on the host that serves it.</summary>
|
||||
[Fact]
|
||||
public void MasterHostConfiguration_ShouldApplyTheStrictPolicyToAdmin()
|
||||
{
|
||||
var options = Load(Path.Combine("host-config", "master.appsettings.json"))
|
||||
.GetSection(SecurityHeadersOptions.SectionName)
|
||||
.Get<SecurityHeadersOptions>();
|
||||
|
||||
options.Should().NotBeNull();
|
||||
options!.Enabled.Should().BeTrue();
|
||||
options.PathPolicies
|
||||
.Should().Contain(rule => rule.PathPrefix == "/admin" && rule.Policy == CspPolicyCatalog.Strict);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user