identity-email-notifications: Build and Test samenvatting

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-08 19:27:01 +01:00
co-authored by Claude Sonnet 5.5
parent 9532b4a92c
commit 70c6d49e7a
2 changed files with 38 additions and 0 deletions
@@ -50,3 +50,5 @@
- [x] U1 mail-foundation - Infrastructure Design (construction/mail-foundation/infrastructure-design/infrastructure-design.md), Code Generation done, build and tests green (see code-summary.md); hand-back pending
- [x] U2 identity-mail-flows - Code Generation done, build and tests green (see construction/identity-mail-flows/code/code-summary.md); includes D1 and D2; hand-back pending
- [x] U3 password-reset - Code Generation done, build and tests green (see construction/password-reset/code/code-summary.md); hand-back pending (D2, the security stamp in the access token, was built in U2)
- [~] Build and Test - summary written (construction/build-and-test/build-and-test-summary.md); manual real test mail on ASF test pending
- [ ] Operations (deployment, monitoring, production readiness incl. SPF/DKIM alignment checklist)
@@ -0,0 +1,36 @@
# Build and Test summary - identity-email-notifications (U1 + U2 + U3)
Branch `feature/identity-email-notifications`, head after U3. Everything below was run locally except the MariaDB-backed API host tests, which run in CI (the developer's `appsettings.local.json` overrides the connection string on this machine).
## Build
- `dotnet build` of the solution: succeeds (no new warnings from this feature; the pre-existing NU1510 pruning warnings are unrelated).
- Frontend: `npx tsc -b` clean, `npx eslint .` clean, `vite build` for the default build and `VITE_THEME=asf` succeeds.
- New dependency: MailKit 4.18.2 (MimeKit transitive). `dotnet list package --vulnerable --include-transitive`: none.
## Unit and component tests
| Suite | Result |
|---|---|
| Core.Tests | 502 passed (mail options/validator, address rules, renderer, SMTP sender against an in-process stub, site settings, mail service, language, password-reset flow with real Identity and tokens, cooldown, dispatcher, stamp check, DI wiring; property-based tests PBT-02/03/07/08/09) |
| Modules.Identity.Tests | 126 passed (users, hierarchy, mail flows, site settings API, auth incl. forgot/reset) |
| Modules.Availability / Master / Offerings | 82 / 57 / 57 passed (unchanged) |
| Api.AndreaSlopFotografie.Tests (config) | 6 passed (mail off by default, no credential committed) |
| Frontend (Vitest) | 355 passed |
## Integration tests
- **Real MariaDB (run locally in a throw-away container, and in CI via `ConnectionStrings__DefaultConnection`)**: all migrations apply on a fresh database; the two newest are undone and re-applied (`AddSiteSettings`, `AddLanguagePreference`); the `DateTimeOffset` round trip keeps the full 24 hours whatever the written offset.
- **Real pipeline on a TestServer**: real Identity, real data-protection tokens, real JWT bearer check: deactivated or deleted users are refused with a valid token (GET and POST), a password change or reset ends earlier access tokens (stamp), refresh keeps working after a plain change, a completed reset revokes refresh tokens, a request touches nothing.
- **SMTP**: the sender talks to an in-process SMTP server (success, sender override, header-injection refused without connecting, timeout, nothing listening).
- **Not run here, runs in CI**: `Api.Tests` and the ASF `HostPipelineTests` (they start the full hosts against MariaDB and apply the new migrations through the real start-up path).
- **Manual, still to do (needs Bryan's go and the mail settings on the host)**: one real test mail from the ASF test host to an address of Bryan (invitation; "Wachtwoord vergeten?"; resend), the Mail card, the language choice, a deactivation notice. smtp4dev can be used locally first.
## Performance
Not applicable beyond: one extra indexed query per authenticated request (active and stamp check, no cache by design). Mail is sent inside administrator requests with a 10 s bound; the anonymous reset request answers immediately.
## Security checks (Security Baseline)
Input validation on every new endpoint (address allowlist, bounded lengths), anonymous endpoints rate limited and uniform (no account enumeration), tokens single-use and time-limited, no secrets or tokens or links in logs (recipient domain only), credentials only via environment, start-up validation without echoing secrets, dependency scan clean. Compliant; items N/A as listed in the requirements.
## Behaviour changes for SlpSoftware (when it is deployed there)
Access tokens issued before the release are refused once (silent refresh issues a new one); a password change ends earlier access tokens; three additive migrations (`SiteSettings`, `Users.PreferredLanguage`, `Invitations.Language`); default token providers registered; two new anonymous endpoints that answer 404 while mail is off; nothing else changes without an SMTP host.
## Open items before the feature can close
1. The real test mail on ASF test (manual, above). 2. Operations stage (deployment config, monitoring, production readiness incl. the SPF/DKIM alignment checklist). 3. Bryan's approval of this stage.