Hero-admin: schakelaar Actief, destructieve knoppen rood, slide-kopjes, juiste voorvertoning in het focusvenster, status per foto

- Schakelaar (role=switch) Actief / Niet actief bij de knoppen, gedimde rij; 'Verberg voor schermlezers'; veld 'Beschrijving' binnen een groep 'Slide N'
- Alle foto's zonder complete set tonen 'Wordt verwerkt' (voortgang bij de foto die bezig is, 'in de wachtrij' bij de rest); totaal bovenaan telt ook nog niet opgeslagen foto's
- Per foto 'Verwerking afgerond' (zelfde weergave voor een hergebruikte foto), foto direct bruikbaar; niet-opgeslagen foto's worden zelf ververst (GET /hero/images/{id}), ook in een achtergrondtab
- Focusvenster toont de hele foto (full-preview in elke set, achtergrond-aanvulling voor oude sets) in plaats van de uitgesneden wide-variant (vervorming)
- Prullenbak en 'Wijzigingen weggooien' in de destructieve stijl
- upload-respons: reused (intern)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-16 23:26:47 +01:00
co-authored by Claude Sonnet 5.5
parent 9f07934f9e
commit 6999f5b2ba
25 changed files with 794 additions and 73 deletions
@@ -264,4 +264,112 @@ public class HeroFocusSaveTests
await act.Should().ThrowAsync<OperationCanceledException>();
done.Should().BeLessThan(specs.Count);
}
[Fact]
public async Task EveryImageWithoutACompleteSet_IsProcessing_InTheAdminApi_AndTwoNewPhotosAreBothCut()
{
using var rig = new HeroTestRig();
// The helper Upload cuts everything that is pending, so the finished photo is made first.
var ready = await rig.Upload(HeroTestRig.Photo(seed: 3));
var first = await rig.UploadWithoutRendering(HeroTestRig.Photo(seed: 1));
var second = await rig.UploadWithoutRendering(HeroTestRig.Photo(seed: 2));
var request = new HeroSaveRequest("Titel", null, null, "slideshow", [], true, null, null,
[new HeroSlideRequest(null, Guid.Parse(first.Id), "een"), new HeroSlideRequest(null, Guid.Parse(second.Id), "twee"), new HeroSlideRequest(null, Guid.Parse(ready.Id), "drie")]);
var saved = await rig.Service.SaveAsync(request, HeroTestRig.Admin, default);
saved.Slides.Select(s => s.Image.Processing).Should().Equal(true, true, false);
(await rig.Service.GetAsync(default)).Slides.Select(s => s.Image.Processing).Should().Equal(true, true, false);
(await rig.RenderPending()).Should().Be(2, "both new photos are cut, one after the other");
(await rig.Service.GetAsync(default)).Slides.Should().OnlyContain(s => !s.Image.Processing && s.Image.Variants.Count > 0);
}
[Theory]
[InlineData(3000, 2000)]
[InlineData(2000, 3000)]
[InlineData(1600, 1600)]
[InlineData(3000, 1000)]
public async Task EverySet_HasAFullFramePreviewAtTheShapeOfThePicture_ThatIsNotPublishedToWebsites(int width, int height)
{
using var rig = new HeroTestRig();
var image = await rig.Upload(HeroTestRig.Photo(width, height));
var id = Guid.Parse(image.Id);
await rig.Service.SaveAsync(Save(id, null), HeroTestRig.Admin, default);
var admin = (await rig.Service.GetAsync(default)).Slides[0].Image;
var stored = rig.Db.HeroImages.Single();
admin.PreviewSrc.Should().NotBeNull();
var preview = stored.Variants.Single(v => v.Ratio == "full");
(preview.Width / (double)preview.Height).Should().BeApproximately(width / (double)height, 0.01, "the preview is the whole picture, not a crop");
preview.Width.Should().Be(Math.Min(1280, width));
admin.Variants.Should().NotContain(v => v.Ratio == "full", "the admin lists only the variants of the website");
(await rig.Public.GetActiveAsync(default))!.Slides[0].Image.Variants.Should().NotContain(v => v.Ratio == "full");
(await rig.Store.ExistsAsync($"hero/{stored.SetHash}/{preview.FileName}", default)).Should().BeTrue();
}
[Fact]
public async Task ASetMadeBeforeThePreviewExisted_GetsOnlyThePreviewAdded_WithoutBeingProcessingOrChangingItsAddresses()
{
using var rig = new HeroTestRig();
var image = await rig.Upload(HeroTestRig.Photo(2000, 3000));
var id = Guid.Parse(image.Id);
await rig.Service.SaveAsync(Save(id, null), HeroTestRig.Admin, default);
var stored = rig.Db.HeroImages.Single();
var setBefore = stored.SetHash;
var preview = stored.Variants.Single(v => v.Ratio == "full");
stored.Variants = stored.Variants.Where(v => v.Ratio != "full").ToList(); // as an older set looked
await rig.Db.SaveChangesAsync();
await rig.Store.DeleteAsync($"hero/{setBefore}/{preview.FileName}", default);
var oldLook = (await rig.Service.GetAsync(default)).Slides[0].Image;
oldLook.Processing.Should().BeFalse("adding the preview is not work the administrator waits for");
oldLook.PreviewSrc.Should().BeNull();
(await rig.RenderPending()).Should().Be(1);
var after = rig.Db.HeroImages.Single();
after.SetHash.Should().Be(setBefore, "nothing live changes");
(await rig.Service.GetAsync(default)).Slides[0].Image.PreviewSrc.Should().NotBeNull();
(await rig.Store.ExistsAsync($"hero/{setBefore}/{preview.FileName}", default)).Should().BeTrue();
}
[Fact]
public async Task APhotoThatIsAlreadyThere_ComesBackAsReused_WithItsVariants_AndNothingToWaitFor()
{
using var rig = new HeroTestRig();
var photo = HeroTestRig.Photo(seed: 5);
var first = await rig.Upload(photo);
var again = await rig.UploadWithoutRendering(photo);
again.Id.Should().Be(first.Id);
again.Reused.Should().BeTrue();
again.Processing.Should().BeFalse();
again.Variants.Should().NotBeEmpty();
first.Reused.Should().BeFalse();
}
[Fact]
public async Task TheStateOfOneImage_IsAskedForByItsId_WithTheRunningRenderersFlags()
{
using var rig = new HeroTestRig();
var dto = await rig.UploadWithoutRendering(HeroTestRig.Photo(seed: 6));
var id = Guid.Parse(dto.Id);
(await rig.Images.GetImageAsync(id, default))!.Processing.Should().BeTrue();
rig.Signal.SetProgress(id, 4, 19);
var busy = (await rig.Images.GetImageAsync(id, default))!;
(busy.RenderDone, busy.RenderTotal).Should().Be((4, 19));
rig.Signal.ClearProgress(id);
await rig.RenderPending();
var done = (await rig.Images.GetImageAsync(id, default))!;
done.Processing.Should().BeFalse();
done.Variants.Should().NotBeEmpty();
(await rig.Images.GetImageAsync(Guid.NewGuid(), default)).Should().BeNull();
}
}