Fixes a wrong placeholder and explains the optional env fields
AllowedConnectOrigins had a sentry-ingest-origin placeholder that was simply incorrect - the Sentry tunnel exists precisely so that exception is never needed. Both SecurityHeaders fields are Umami-only now, with inline comments on when to set them versus leave them out, and a note that MasterModule__MasterUrl degrades to a warning rather than a startup failure when unset.
This commit is contained in:
@@ -1334,3 +1334,14 @@ by Infrastructure Design. U5 carries REF-U3-01's Umami origin gate plus FR-21 an
|
||||
**Context**: OPERATIONS — Deployment Setup, instance-naming correction before final approval
|
||||
|
||||
---
|
||||
## Deployment Setup — Clarified SecurityHeaders and MasterModule Config Guidance
|
||||
|
||||
**Timestamp**: 2026-07-28T04:25:00Z
|
||||
|
||||
**User Input**: "Ik snap niet wat ik precies moet invullen voor de SecurityHeaders velden in de env bestanden. Ook zie ik de MasterModule property. Die is als het goed is niet nodig voor een API mest de master module, toch?"
|
||||
|
||||
**AI Response**: "Corrected a real error in my own draft: AllowedConnectOrigins__0 was documented with a <sentry-ingest-origin> placeholder, but per domain-entities.md (U3), Sentry deliberately needs NO connect-src exception — U4's same-origin tunnel (MapSentryTunnel()) exists specifically to avoid that. Both SecurityHeaders fields are only needed for Umami (script-src to load the tracking script, connect-src for its analytics beacons) and should be omitted entirely if Umami isn't used. Confirmed MasterModule__MasterUrl is optional and unvalidated at startup (MasterModuleOptions.MasterUrl is nullable; CmsInstanceService just logs a warning and skips reconciliation if unset, verified against the actual code and its unit test VerifyIntegrityAsync_SkipsCheck_WhenMasterUrlNotConfigured) — safe to leave unset if this instance won't manage any slave CMS instances. Rewrote the shared/env template in deployment-instructions.md with inline comments explaining exactly when each optional field is needed."
|
||||
|
||||
**Context**: OPERATIONS — Deployment Setup, configuration guidance clarified before final approval
|
||||
|
||||
---
|
||||
|
||||
Reference in New Issue
Block a user