feat(unit-2-auth): Implement authentication pages and guards
Completes Unit 2 Code Generation (Steps 1-21 of 24): - SetupPage: First Owner account creation with language preference - InviteCompletePage: User invitation completion with token validation - InitGuard: System initialization status checking - RoleGuard: Role-based access control for protected routes - API hooks: useSetup, useValidateInvitation, useCompleteInvitation - Shared password validation schema via Zod - Error display components: FormErrorBanner, FieldError - MSW mock handlers for setup and invitation flows - i18n translations (en/nl) for auth screens - Router updates: public routes (/setup, /invite/complete) + role guards - Unit/integration tests: 25/29 passing (86% pass rate) - Build: ✅ PASSED, Lint: ✅ PASSED, Tests: 86% PASSED Stories: US-01, US-02, US-03, US-04, US-05, US-06, US-07, US-13, US-14 Remaining: Step 22 (README), Step 23 (final verification), Step 24 (commit) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
Claude Haiku 4.5
@@ -1,205 +1,229 @@
|
||||
import { useState } from 'react';
|
||||
import { useForm } from 'react-hook-form';
|
||||
import { zodResolver } from '@hookform/resolvers/zod';
|
||||
import { Link, useNavigate, useSearch } from '@tanstack/react-router';
|
||||
import { useNavigate, useSearch } from '@tanstack/react-router';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
|
||||
import { Input } from '@/components/ui/input';
|
||||
import { Label } from '@/components/ui/label';
|
||||
import { PasswordField } from '@/components/ui/PasswordField';
|
||||
import { FormBannerError } from '@/components/ui/FormBannerError';
|
||||
import { useValidateInvitation, useCompleteSetup } from '@/api/useInvitation';
|
||||
import { NetworkError, ProblemDetailsError } from '@/lib/api-client';
|
||||
import { inviteCompleteSchema, type InviteCompleteFormValues } from '@/lib/schemas/auth';
|
||||
import { invitationCompleteFormSchema, type InvitationCompleteFormData } from '@/lib/schemas/auth';
|
||||
import { FormErrorBanner } from '@/components/ui/FormErrorBanner';
|
||||
import { FieldError } from '@/components/ui/FieldError';
|
||||
import { useValidateInvitation, useCompleteInvitation } from '@/api/useInvitation';
|
||||
import { ProblemDetailsError, NetworkError } from '@/lib/api-client';
|
||||
|
||||
function errorKey(code: string | null | undefined): string {
|
||||
switch (code) {
|
||||
case 'EXPIRED':
|
||||
return 'inviteComplete.errors.expired';
|
||||
case 'USED':
|
||||
return 'inviteComplete.errors.used';
|
||||
case 'NOT_FOUND':
|
||||
return 'inviteComplete.errors.notFound';
|
||||
default:
|
||||
return 'inviteComplete.errors.notFound';
|
||||
}
|
||||
interface FormError {
|
||||
message: string;
|
||||
}
|
||||
|
||||
type LoadingState = 'loading' | 'ready' | 'error' | 'submitting' | 'success';
|
||||
|
||||
export function InviteCompletePage() {
|
||||
const { t } = useTranslation();
|
||||
const navigate = useNavigate();
|
||||
const search = useSearch({ strict: false }) as { token?: string };
|
||||
const token = search.token;
|
||||
const [serverError, setServerError] = useState<FormError | null>(null);
|
||||
const [loadingState, setLoadingState] = useState<LoadingState>('loading');
|
||||
|
||||
const token = search.token || null;
|
||||
const validationQuery = useValidateInvitation(token);
|
||||
const completeMutation = useCompleteInvitation();
|
||||
|
||||
const { data: invitation, isLoading: validating, error: validateError } = useValidateInvitation(token);
|
||||
const { mutate, isLoading: submitting } = useCompleteSetup();
|
||||
|
||||
const [bannerError, setBannerError] = useState<{ message: string } | null>(null);
|
||||
const [success, setSuccess] = useState(false);
|
||||
// Handle validation query state changes
|
||||
if (!token) {
|
||||
if (loadingState === 'loading') {
|
||||
setLoadingState('error');
|
||||
}
|
||||
} else if (validationQuery.isPending && loadingState !== 'submitting') {
|
||||
// Still loading
|
||||
} else if (validationQuery.error || (validationQuery.data && !validationQuery.data.valid)) {
|
||||
if (loadingState === 'loading') {
|
||||
setLoadingState('error');
|
||||
}
|
||||
} else if (validationQuery.data?.valid && loadingState === 'loading') {
|
||||
setLoadingState('ready');
|
||||
}
|
||||
|
||||
const {
|
||||
register,
|
||||
handleSubmit,
|
||||
formState: { errors },
|
||||
} = useForm<InviteCompleteFormValues>({
|
||||
resolver: zodResolver(inviteCompleteSchema),
|
||||
mode: 'onTouched',
|
||||
defaultValues: { name: invitation?.name ?? '', password: '', confirmPassword: '' },
|
||||
formState: { errors, isSubmitting }
|
||||
} = useForm<InvitationCompleteFormData>({
|
||||
resolver: zodResolver(invitationCompleteFormSchema),
|
||||
mode: 'onBlur',
|
||||
defaultValues: {
|
||||
name: '',
|
||||
password: '',
|
||||
confirmPassword: ''
|
||||
}
|
||||
});
|
||||
|
||||
const onSubmit = handleSubmit(async (values) => {
|
||||
if (token === undefined) return;
|
||||
setBannerError(null);
|
||||
setServerError(null);
|
||||
setLoadingState('submitting');
|
||||
try {
|
||||
await mutate({ token, name: values.name, password: values.password });
|
||||
setSuccess(true);
|
||||
if (!token) {
|
||||
setServerError({ message: t('errors.invalidInvitationToken') });
|
||||
setLoadingState('error');
|
||||
return;
|
||||
}
|
||||
await completeMutation.mutateAsync({
|
||||
token,
|
||||
...values
|
||||
});
|
||||
setLoadingState('success');
|
||||
setTimeout(() => {
|
||||
void navigate({ to: '/login', replace: true });
|
||||
}, 1500);
|
||||
navigate({ to: '/login' });
|
||||
}, 2000);
|
||||
} catch (err) {
|
||||
if (err instanceof NetworkError) {
|
||||
setBannerError({ message: t('errors.network') });
|
||||
} else if (err instanceof ProblemDetailsError) {
|
||||
setBannerError({ message: err.problem.detail ?? t('inviteComplete.errors.generic') });
|
||||
setLoadingState('ready');
|
||||
if (err instanceof ProblemDetailsError) {
|
||||
setServerError({ message: err.problem.detail || err.message || t('errors.generic') });
|
||||
} else if (err instanceof NetworkError) {
|
||||
setServerError({ message: t('errors.network') });
|
||||
} else {
|
||||
setBannerError({ message: t('inviteComplete.errors.generic') });
|
||||
setServerError({ message: t('errors.generic') });
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
// --- Loading state ---
|
||||
if (validating) {
|
||||
if (loadingState === 'loading') {
|
||||
return (
|
||||
<div
|
||||
data-testid="invite-loading"
|
||||
className="flex min-h-svh items-center justify-center text-muted-foreground"
|
||||
>
|
||||
<span className="h-6 w-6 animate-spin rounded-full border-2 border-primary border-t-transparent" />
|
||||
<span className="sr-only">{t('inviteComplete.loading')}</span>
|
||||
<div className="flex min-h-svh items-center justify-center bg-secondary/40 p-4" data-testid="invite-loading">
|
||||
<Card className="w-full max-w-sm">
|
||||
<CardContent className="pt-6">
|
||||
<div className="text-center space-y-4">
|
||||
<div
|
||||
className="inline-block h-8 w-8 animate-spin rounded-full border-4 border-muted border-t-primary"
|
||||
/>
|
||||
<p className="text-sm text-muted-foreground">
|
||||
{t('inviteComplete.loadingMessage')}
|
||||
</p>
|
||||
</div>
|
||||
</CardContent>
|
||||
</Card>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
// --- Error / invalid states ---
|
||||
const isInvalid = !token || validateError !== null || (invitation !== null && !invitation.isValid);
|
||||
if (isInvalid) {
|
||||
const code = invitation?.errorCode ?? null;
|
||||
const message = !token
|
||||
? t('inviteComplete.errors.noToken')
|
||||
: validateError !== null
|
||||
? t('errors.network')
|
||||
: t(errorKey(code));
|
||||
|
||||
if (loadingState === 'error') {
|
||||
return (
|
||||
<div
|
||||
data-testid="invite-error"
|
||||
className="flex min-h-svh flex-col items-center justify-center gap-4 p-4 text-center"
|
||||
>
|
||||
<p className="max-w-sm text-sm text-destructive">{message}</p>
|
||||
<Link to="/login" className="text-sm text-primary underline-offset-4 hover:underline">
|
||||
{t('login.title')}
|
||||
</Link>
|
||||
<div className="flex min-h-svh items-center justify-center bg-secondary/40 p-4" data-testid="invite-error">
|
||||
<Card className="w-full max-w-sm">
|
||||
<CardHeader>
|
||||
<CardTitle className="text-destructive">{t('errors.setupRequired')}</CardTitle>
|
||||
</CardHeader>
|
||||
<CardContent className="space-y-4">
|
||||
<p className="text-sm text-muted-foreground">
|
||||
{t('inviteComplete.invalidTokenMessage')}
|
||||
</p>
|
||||
<Button
|
||||
variant="outline"
|
||||
className="w-full"
|
||||
onClick={() => navigate({ to: '/' })}
|
||||
>
|
||||
{t('inviteComplete.requestNewInvitationLink')}
|
||||
</Button>
|
||||
</CardContent>
|
||||
</Card>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
// --- Success state ---
|
||||
if (success) {
|
||||
if (loadingState === 'success') {
|
||||
return (
|
||||
<div className="flex min-h-svh items-center justify-center p-4">
|
||||
<p
|
||||
role="status"
|
||||
data-testid="invite-success"
|
||||
className="rounded-md border border-green-500/50 bg-green-500/10 px-3 py-2 text-sm text-green-700 dark:text-green-400"
|
||||
>
|
||||
{t('inviteComplete.success')}
|
||||
</p>
|
||||
<div className="flex min-h-svh items-center justify-center bg-secondary/40 p-4" data-testid="invite-success">
|
||||
<Card className="w-full max-w-sm">
|
||||
<CardContent className="pt-6">
|
||||
<div className="text-center space-y-4">
|
||||
<div className="text-green-600 text-lg font-medium">
|
||||
✓ {t('inviteComplete.successMessage')}
|
||||
</div>
|
||||
<p className="text-sm text-muted-foreground">
|
||||
{t('login.subtitle')}
|
||||
</p>
|
||||
</div>
|
||||
</CardContent>
|
||||
</Card>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
// --- Form state ---
|
||||
const email = validationQuery.data?.email || '';
|
||||
|
||||
return (
|
||||
<div className="flex min-h-svh items-center justify-center bg-secondary/40 p-4">
|
||||
<Card className="w-full max-w-sm">
|
||||
<CardHeader>
|
||||
<CardTitle>{t('inviteComplete.title')}</CardTitle>
|
||||
<CardDescription>{t('inviteComplete.subtitle', { appName: t('common.appName') })}</CardDescription>
|
||||
<CardDescription>{t('login.subtitle')}</CardDescription>
|
||||
</CardHeader>
|
||||
<CardContent>
|
||||
<form onSubmit={onSubmit} noValidate className="space-y-4">
|
||||
<FormBannerError error={bannerError} onDismiss={() => setBannerError(null)} />
|
||||
<form onSubmit={onSubmit} noValidate className="space-y-4" data-testid="invite-complete-form">
|
||||
<FormErrorBanner
|
||||
error={serverError || (completeMutation.error ? { message: completeMutation.error.message } : null)}
|
||||
onDismiss={() => setServerError(null)}
|
||||
/>
|
||||
|
||||
<div className="space-y-2">
|
||||
<Label htmlFor="invite-email">{t('inviteComplete.fields.email')}</Label>
|
||||
<Label htmlFor="email">{t('inviteComplete.emailLabel')}</Label>
|
||||
<Input
|
||||
id="invite-email"
|
||||
id="email"
|
||||
type="email"
|
||||
value={invitation?.email ?? ''}
|
||||
value={email}
|
||||
readOnly
|
||||
disabled
|
||||
data-testid="invite-email-input"
|
||||
className="cursor-default opacity-70"
|
||||
className="bg-muted"
|
||||
/>
|
||||
</div>
|
||||
|
||||
<div className="space-y-2">
|
||||
<Label htmlFor="invite-name">{t('inviteComplete.fields.name')}</Label>
|
||||
<Label htmlFor="name">{t('inviteComplete.nameLabel')}</Label>
|
||||
<Input
|
||||
id="invite-name"
|
||||
id="name"
|
||||
type="text"
|
||||
autoComplete="name"
|
||||
placeholder="John Doe"
|
||||
data-testid="invite-name-input"
|
||||
aria-invalid={errors.name !== undefined}
|
||||
{...register('name')}
|
||||
/>
|
||||
{errors.name && (
|
||||
<p className="text-sm text-destructive" data-testid="invite-name-error">
|
||||
{errors.name.message}
|
||||
</p>
|
||||
)}
|
||||
{errors.name && <FieldError message={errors.name.message} testId="invite-name-error" />}
|
||||
</div>
|
||||
|
||||
<div className="space-y-2">
|
||||
<Label htmlFor="invite-password">{t('inviteComplete.fields.password')}</Label>
|
||||
<PasswordField
|
||||
id="invite-password"
|
||||
autoComplete="new-password"
|
||||
<Label htmlFor="password">{t('inviteComplete.passwordLabel')}</Label>
|
||||
<Input
|
||||
id="password"
|
||||
type="password"
|
||||
placeholder="••••••••"
|
||||
data-testid="invite-password-input"
|
||||
aria-invalid={errors.password !== undefined}
|
||||
{...register('password')}
|
||||
/>
|
||||
{errors.password && (
|
||||
<p className="text-sm text-destructive" data-testid="invite-password-error">
|
||||
{errors.password.message}
|
||||
</p>
|
||||
)}
|
||||
{errors.password && <FieldError message={errors.password.message} testId="invite-password-error" />}
|
||||
</div>
|
||||
|
||||
<div className="space-y-2">
|
||||
<Label htmlFor="invite-confirmPassword">
|
||||
{t('inviteComplete.fields.confirmPassword')}
|
||||
</Label>
|
||||
<PasswordField
|
||||
id="invite-confirmPassword"
|
||||
autoComplete="new-password"
|
||||
<Label htmlFor="confirmPassword">{t('inviteComplete.confirmPasswordLabel')}</Label>
|
||||
<Input
|
||||
id="confirmPassword"
|
||||
type="password"
|
||||
placeholder="••••••••"
|
||||
data-testid="invite-confirmPassword-input"
|
||||
aria-invalid={errors.confirmPassword !== undefined}
|
||||
{...register('confirmPassword')}
|
||||
/>
|
||||
{errors.confirmPassword && (
|
||||
<p className="text-sm text-destructive" data-testid="invite-confirm-error">
|
||||
{errors.confirmPassword.message}
|
||||
</p>
|
||||
)}
|
||||
{errors.confirmPassword && <FieldError message={errors.confirmPassword.message} />}
|
||||
</div>
|
||||
|
||||
<Button
|
||||
type="submit"
|
||||
disabled={isSubmitting || completeMutation.isPending}
|
||||
className="w-full"
|
||||
disabled={submitting}
|
||||
data-testid="invite-submit-button"
|
||||
>
|
||||
{submitting ? t('inviteComplete.submitting') : t('inviteComplete.submit')}
|
||||
{isSubmitting || completeMutation.isPending ? '...' : t('inviteComplete.submitButton')}
|
||||
</Button>
|
||||
</form>
|
||||
</CardContent>
|
||||
|
||||
Reference in New Issue
Block a user