Offerings: banner-tabblad in de admin (lijst, formulier, planning), layout uit de frontend; gate-test bijgewerkt

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-12 11:04:50 +01:00
co-authored by Claude Sonnet 5.5
parent a2f4513205
commit 5386abb9ef
16 changed files with 1867 additions and 1178 deletions
@@ -0,0 +1,141 @@
import { beforeEach, describe, expect, it } from 'vitest';
import { screen, waitFor } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { renderApp, mockAuthenticated } from '@/test/utils';
import { getMockBanners, resetMockOfferings, setMockBanners } from '@/features/offerings/mocks/handlers';
import { bannerStatus, fromLocalInput, isAllowedBannerLink, toLocalInput } from '@/features/offerings/schemas/offeringBanner';
import { _resetSetupStatusCache } from '@/router';
beforeEach(() => {
_resetSetupStatusCache();
resetMockOfferings();
});
const T = { timeout: 10000 };
async function openBannerTab() {
mockAuthenticated();
renderApp('/offerings');
await userEvent.click(await screen.findByTestId('offerings-tab-banner', {}, T));
}
describe('Banner tab', () => {
it('switches between the offerings and the banner tab, hiding the add-offering actions on the banner tab', async () => {
mockAuthenticated();
renderApp('/offerings');
expect(await screen.findByTestId('offerings-add-button', {}, T)).toBeInTheDocument();
await userEvent.click(screen.getByTestId('offerings-tab-banner'));
expect(await screen.findByTestId('banners-tab')).toBeInTheDocument();
expect(screen.getByTestId('offerings-tab-banner')).toHaveAttribute('aria-selected', 'true');
expect(screen.queryByTestId('offerings-add-button')).not.toBeInTheDocument();
expect(screen.queryByTestId('offerings-add-fab')).not.toBeInTheDocument();
await userEvent.click(screen.getByTestId('offerings-tab-offerings'));
expect(await screen.findByTestId('offerings-add-button')).toBeInTheDocument();
});
it('shows an empty state, then creates a banner with a link and a schedule', async () => {
await openBannerTab();
expect(await screen.findByTestId('banners-empty', {}, T)).toBeInTheDocument();
await userEvent.click(screen.getByTestId('banner-add-button'));
await userEvent.type(await screen.findByTestId('banner-title'), 'Zomeractie');
await userEvent.type(screen.getByTestId('banner-text'), '10% korting in juli');
await userEvent.type(screen.getByTestId('banner-link-label'), 'Bekijk');
await userEvent.type(screen.getByTestId('banner-link-url'), '/privacy');
await userEvent.type(screen.getByTestId('banner-starts'), '2030-07-01T09:00');
await userEvent.type(screen.getByTestId('banner-ends'), '2030-07-31T23:00');
await userEvent.click(screen.getByTestId('banner-submit'));
await waitFor(() => expect(getMockBanners()).toHaveLength(1));
const saved = getMockBanners()[0];
expect(saved).toMatchObject({ title: 'Zomeractie', linkLabel: 'Bekijk', linkUrl: '/privacy', isActive: true });
expect(saved.startsAt).toBe(fromLocalInput('2030-07-01T09:00'));
expect(await screen.findByText('Zomeractie')).toBeInTheDocument();
expect(screen.getByTestId(`banner-status-${saved.id}`)).toHaveTextContent(/Gepland|Scheduled/);
});
it('rejects an unsafe link and a link without button text, and an end before the start', async () => {
await openBannerTab();
await userEvent.click(await screen.findByTestId('banner-add-button', {}, T));
await userEvent.type(await screen.findByTestId('banner-title'), 'X');
await userEvent.type(screen.getByTestId('banner-text'), 'Y');
await userEvent.type(screen.getByTestId('banner-link-label'), 'Go');
await userEvent.type(screen.getByTestId('banner-link-url'), 'javascript:alert(1)');
await userEvent.click(screen.getByTestId('banner-submit'));
expect(await screen.findByTestId('banner-link-url-error')).toBeInTheDocument();
await userEvent.clear(screen.getByTestId('banner-link-label'));
await userEvent.clear(screen.getByTestId('banner-link-url'));
await userEvent.type(screen.getByTestId('banner-link-url'), '/ok');
await userEvent.click(screen.getByTestId('banner-submit'));
expect(await screen.findByTestId('banner-link-label-error')).toBeInTheDocument();
await userEvent.clear(screen.getByTestId('banner-link-url'));
await userEvent.type(screen.getByTestId('banner-starts'), '2030-07-31T09:00');
await userEvent.type(screen.getByTestId('banner-ends'), '2030-07-01T09:00');
await userEvent.click(screen.getByTestId('banner-submit'));
expect(await screen.findByTestId('banner-ends-error')).toBeInTheDocument();
expect(getMockBanners()).toHaveLength(0);
});
it('edits and deletes an existing banner', async () => {
setMockBanners([
{
id: 'b1', title: 'Oud', text: 'Tekst', linkLabel: null, linkUrl: null, isActive: true,
startsAt: null, endsAt: null, updatedAt: '2026-01-01T00:00:00Z',
},
]);
await openBannerTab();
expect(await screen.findByTestId('banner-status-b1', {}, T)).toHaveTextContent(/Actief|Active/);
await userEvent.click(screen.getByTestId('banner-edit-b1'));
const title = await screen.findByTestId('banner-title');
expect(title).toHaveValue('Oud');
await userEvent.clear(title);
await userEvent.type(title, 'Nieuw');
await userEvent.click(screen.getByTestId('banner-active'));
await userEvent.click(screen.getByTestId('banner-submit'));
await waitFor(() => expect(getMockBanners()[0]).toMatchObject({ title: 'Nieuw', isActive: false }));
expect(await screen.findByTestId('banner-status-b1')).toHaveTextContent(/Uit|Off/);
await userEvent.click(screen.getByTestId('banner-delete-b1'));
expect(await screen.findByTestId('banner-delete-message')).toHaveTextContent('Nieuw');
await userEvent.click(screen.getByTestId('banner-delete-confirm'));
await waitFor(() => expect(getMockBanners()).toHaveLength(0));
expect(await screen.findByTestId('banners-empty')).toBeInTheDocument();
});
});
describe('banner helpers', () => {
it.each([
['https://slpsoftware.nl/actie', true],
['/aanbieding', true],
['/', true],
['http://x.nl', false],
['//evil.example', false],
['/\\evil', false],
['javascript:alert(1)', false],
['mailto:a@b.nl', false],
['actie', false],
['/with space', false],
])('link %s → %s', (url, ok) => {
expect(isAllowedBannerLink(url)).toBe(ok);
});
it('derives the status from switch and schedule', () => {
const now = new Date('2026-11-12T12:00:00Z');
expect(bannerStatus({ isActive: false, startsAt: null, endsAt: null }, now)).toBe('off');
expect(bannerStatus({ isActive: true, startsAt: '2026-11-13T00:00:00Z', endsAt: null }, now)).toBe('scheduled');
expect(bannerStatus({ isActive: true, startsAt: null, endsAt: '2026-11-12T12:00:00Z' }, now)).toBe('expired');
expect(bannerStatus({ isActive: true, startsAt: '2026-11-01T00:00:00Z', endsAt: '2026-12-01T00:00:00Z' }, now)).toBe('live');
});
it('round-trips datetime-local values', () => {
expect(toLocalInput(fromLocalInput('2030-07-01T09:00'))).toBe('2030-07-01T09:00');
expect(fromLocalInput('')).toBeNull();
expect(toLocalInput(null)).toBe('');
});
});