Offerings: banner krijgt positie top|bottom (backend, migratie, admin-tab, OpenAPI)
- OfferingBanner.Position ('top'|'bottom'); bestaande banners worden 'bottom' (migratie AddOfferingBannerPosition)
- GET /api/v1/offerings/banner?position=top|bottom: zonder parameter bottom, 204 zonder actieve banner, 400 bij ongeldige waarde; antwoord bevat position
- Max 1 actieve banner per positie (laatst gewijzigde binnen de planning wint); top en bottom kunnen tegelijk actief zijn
- Top: tekst max 120 tekens, titel optioneel; bottom: titel verplicht
- Admin: Banner-tab met twee secties (Boven/Onder), eigen aanmaken en aan/uit per plek
- OpenAPI-snapshot met de hand bijgewerkt (geen lokale MariaDB): CI bevestigt
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
import { useState } from 'react';
|
||||
import { useForm } from 'react-hook-form';
|
||||
import { useForm, useWatch } from 'react-hook-form';
|
||||
import { zodResolver } from '@hookform/resolvers/zod';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { toast } from 'sonner';
|
||||
@@ -12,21 +12,23 @@ import { Dialog, DialogContent, DialogHeader, DialogTitle } from '@/components/u
|
||||
import { NetworkError } from '@/lib/api-client';
|
||||
import {
|
||||
fromLocalInput,
|
||||
bannerTextMaxLength,
|
||||
offeringBannerFormSchema,
|
||||
toLocalInput,
|
||||
type OfferingBannerFormData,
|
||||
} from '../schemas/offeringBanner';
|
||||
import { useSaveOfferingBanner } from '../services/useSaveOfferingBanner';
|
||||
import type { OfferingBannerDto } from '../services/types';
|
||||
import type { BannerPosition, OfferingBannerDto } from '../services/types';
|
||||
|
||||
interface OfferingBannerDialogProps {
|
||||
/** Open for editing this banner; null with `creating` = a new one. */
|
||||
/** Open for editing this banner (its own position applies); null with `creatingPosition` = a new one there. */
|
||||
banner: OfferingBannerDto | null;
|
||||
creating: boolean;
|
||||
creatingPosition: BannerPosition | null;
|
||||
onClose: () => void;
|
||||
}
|
||||
|
||||
const EMPTY: OfferingBannerFormData = {
|
||||
const emptyForm = (position: BannerPosition): OfferingBannerFormData => ({
|
||||
position,
|
||||
title: '',
|
||||
text: '',
|
||||
linkLabel: '',
|
||||
@@ -34,11 +36,12 @@ const EMPTY: OfferingBannerFormData = {
|
||||
isActive: true,
|
||||
startsAt: '',
|
||||
endsAt: '',
|
||||
};
|
||||
});
|
||||
|
||||
function toForm(banner: OfferingBannerDto | null): OfferingBannerFormData {
|
||||
if (!banner) return EMPTY;
|
||||
function toForm(banner: OfferingBannerDto | null, position: BannerPosition): OfferingBannerFormData {
|
||||
if (!banner) return emptyForm(position);
|
||||
return {
|
||||
position: banner.position,
|
||||
title: banner.title,
|
||||
text: banner.text,
|
||||
linkLabel: banner.linkLabel ?? '',
|
||||
@@ -49,26 +52,35 @@ function toForm(banner: OfferingBannerDto | null): OfferingBannerFormData {
|
||||
};
|
||||
}
|
||||
|
||||
export function OfferingBannerDialog({ banner, creating, onClose }: OfferingBannerDialogProps) {
|
||||
export function OfferingBannerDialog({ banner, creatingPosition, onClose }: OfferingBannerDialogProps) {
|
||||
const { t } = useTranslation();
|
||||
const open = creating || banner !== null;
|
||||
const open = creatingPosition !== null || banner !== null;
|
||||
const position: BannerPosition = banner?.position ?? creatingPosition ?? 'bottom';
|
||||
|
||||
return (
|
||||
<Dialog open={open} onOpenChange={(next) => { if (!next) onClose(); }}>
|
||||
<DialogContent className="max-h-[90vh] overflow-y-auto sm:max-w-lg">
|
||||
<DialogHeader>
|
||||
<DialogTitle data-testid="banner-dialog-title">
|
||||
{banner ? t('offerings.banners.editTitle') : t('offerings.banners.createTitle')}
|
||||
{banner ? t(`offerings.banners.editTitle_${position}`) : t(`offerings.banners.createTitle_${position}`)}
|
||||
</DialogTitle>
|
||||
</DialogHeader>
|
||||
{/* Content is unmounted while closed, so every opening starts from fresh form state. */}
|
||||
<OfferingBannerForm banner={banner} onClose={onClose} />
|
||||
<OfferingBannerForm banner={banner} position={position} onClose={onClose} />
|
||||
</DialogContent>
|
||||
</Dialog>
|
||||
);
|
||||
}
|
||||
|
||||
function OfferingBannerForm({ banner, onClose }: { banner: OfferingBannerDto | null; onClose: () => void }) {
|
||||
function OfferingBannerForm({
|
||||
banner,
|
||||
position,
|
||||
onClose,
|
||||
}: {
|
||||
banner: OfferingBannerDto | null;
|
||||
position: BannerPosition;
|
||||
onClose: () => void;
|
||||
}) {
|
||||
const { t } = useTranslation();
|
||||
const [serverError, setServerError] = useState<string | null>(null);
|
||||
const save = useSaveOfferingBanner();
|
||||
@@ -76,12 +88,15 @@ function OfferingBannerForm({ banner, onClose }: { banner: OfferingBannerDto | n
|
||||
const {
|
||||
register,
|
||||
handleSubmit,
|
||||
control,
|
||||
formState: { errors },
|
||||
} = useForm<OfferingBannerFormData>({
|
||||
resolver: zodResolver(offeringBannerFormSchema),
|
||||
mode: 'onTouched',
|
||||
defaultValues: toForm(banner),
|
||||
defaultValues: toForm(banner, position),
|
||||
});
|
||||
const textMax = bannerTextMaxLength(position);
|
||||
const textLength = (useWatch({ control, name: 'text' }) ?? '').length;
|
||||
|
||||
const onSubmit = async (values: OfferingBannerFormData) => {
|
||||
setServerError(null);
|
||||
@@ -89,6 +104,7 @@ function OfferingBannerForm({ banner, onClose }: { banner: OfferingBannerDto | n
|
||||
await save.mutateAsync({
|
||||
id: banner?.id,
|
||||
body: {
|
||||
position: values.position,
|
||||
title: values.title,
|
||||
text: values.text,
|
||||
linkLabel: values.linkLabel || null,
|
||||
@@ -114,7 +130,7 @@ function OfferingBannerForm({ banner, onClose }: { banner: OfferingBannerDto | n
|
||||
|
||||
<form onSubmit={handleSubmit(onSubmit)} className="space-y-4" noValidate data-testid="banner-form">
|
||||
<div className="space-y-2">
|
||||
<Label htmlFor="banner-title">{t('offerings.banners.titleLabel')}</Label>
|
||||
<Label htmlFor="banner-title">{t(position === 'top' ? 'offerings.banners.titleLabelOptional' : 'offerings.banners.titleLabel')}</Label>
|
||||
<Input id="banner-title" data-testid="banner-title" maxLength={100} {...register('title')} />
|
||||
<FieldError message={errors.title?.message} testId="banner-title-error" />
|
||||
</div>
|
||||
@@ -124,11 +140,18 @@ function OfferingBannerForm({ banner, onClose }: { banner: OfferingBannerDto | n
|
||||
<textarea
|
||||
id="banner-text"
|
||||
data-testid="banner-text"
|
||||
rows={3}
|
||||
maxLength={300}
|
||||
rows={position === 'top' ? 2 : 3}
|
||||
maxLength={textMax}
|
||||
className="w-full rounded-md border border-input bg-background px-3 py-2 text-sm"
|
||||
{...register('text')}
|
||||
/>
|
||||
<p
|
||||
className={`text-xs ${textLength >= textMax ? 'text-destructive' : 'text-muted-foreground'}`}
|
||||
data-testid="banner-text-counter"
|
||||
>
|
||||
{textLength}/{textMax}
|
||||
{position === 'top' && ` · ${t('offerings.banners.textHintTop')}`}
|
||||
</p>
|
||||
<FieldError message={errors.text?.message} testId="banner-text-error" />
|
||||
</div>
|
||||
|
||||
|
||||
@@ -1,111 +1,182 @@
|
||||
import { useState } from 'react';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { Megaphone, Pencil, Plus, Trash2 } from 'lucide-react';
|
||||
import { Megaphone, Pencil, Plus, Power, Trash2 } from 'lucide-react';
|
||||
import { toast } from 'sonner';
|
||||
import { Badge } from '@/components/ui/badge';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import { Dialog, DialogContent, DialogHeader, DialogTitle } from '@/components/ui/dialog';
|
||||
import { useOfferingBanners } from '../services/useOfferingBanners';
|
||||
import { useDeleteOfferingBanner } from '../services/useDeleteOfferingBanner';
|
||||
import { useSaveOfferingBanner } from '../services/useSaveOfferingBanner';
|
||||
import { bannerStatus } from '../schemas/offeringBanner';
|
||||
import { OfferingBannerDialog } from './OfferingBannerDialog';
|
||||
import type { OfferingBannerDto } from '../services/types';
|
||||
import type { BannerPosition, OfferingBannerDto } from '../services/types';
|
||||
|
||||
const fmt = (iso: string | null) =>
|
||||
iso ? new Date(iso).toLocaleString('nl-NL', { dateStyle: 'short', timeStyle: 'short' }) : null;
|
||||
|
||||
const POSITIONS: BannerPosition[] = ['top', 'bottom'];
|
||||
|
||||
const statusVariant = { live: 'default', scheduled: 'secondary', expired: 'outline', off: 'outline' } as const;
|
||||
|
||||
/** The banner shown now for one position: among the live ones, the most recently changed wins. */
|
||||
function liveBannerOf(banners: OfferingBannerDto[], now = new Date()): OfferingBannerDto | null {
|
||||
const live = banners.filter((b) => bannerStatus(b, now) === 'live');
|
||||
if (live.length === 0) return null;
|
||||
return live.reduce((a, b) => (new Date(b.updatedAt) > new Date(a.updatedAt) ? b : a));
|
||||
}
|
||||
|
||||
export function OfferingBannersTab() {
|
||||
const { t } = useTranslation();
|
||||
const { data: banners, isPending, isError } = useOfferingBanners();
|
||||
const [editing, setEditing] = useState<OfferingBannerDto | null>(null);
|
||||
const [creating, setCreating] = useState(false);
|
||||
const [creating, setCreating] = useState<BannerPosition | null>(null);
|
||||
const [pendingDelete, setPendingDelete] = useState<OfferingBannerDto | null>(null);
|
||||
const remove = useDeleteOfferingBanner();
|
||||
const save = useSaveOfferingBanner();
|
||||
|
||||
const statusVariant = { live: 'default', scheduled: 'secondary', expired: 'outline', off: 'outline' } as const;
|
||||
const toggleActive = (b: OfferingBannerDto) =>
|
||||
save.mutate(
|
||||
{
|
||||
id: b.id,
|
||||
body: {
|
||||
position: b.position,
|
||||
title: b.title,
|
||||
text: b.text,
|
||||
linkLabel: b.linkLabel,
|
||||
linkUrl: b.linkUrl,
|
||||
isActive: !b.isActive,
|
||||
startsAt: b.startsAt,
|
||||
endsAt: b.endsAt,
|
||||
},
|
||||
},
|
||||
{
|
||||
onSuccess: () => toast.success(t('offerings.banners.savedToast')),
|
||||
onError: () => toast.error(t('errors.generic')),
|
||||
},
|
||||
);
|
||||
|
||||
return (
|
||||
<div className="space-y-4" data-testid="banners-tab">
|
||||
<div className="flex items-center justify-between gap-2">
|
||||
<p className="text-sm text-muted-foreground">{t('offerings.banners.intro')}</p>
|
||||
<Button type="button" onClick={() => setCreating(true)} data-testid="banner-add-button">
|
||||
<Plus className="mr-1 size-4" aria-hidden="true" />
|
||||
{t('offerings.banners.addButton')}
|
||||
</Button>
|
||||
</div>
|
||||
<div className="space-y-6" data-testid="banners-tab">
|
||||
<p className="text-sm text-muted-foreground">{t('offerings.banners.intro')}</p>
|
||||
|
||||
{isPending && <p className="text-sm text-muted-foreground">{t('common.loading')}</p>}
|
||||
{isError && <p className="text-sm text-destructive">{t('errors.generic')}</p>}
|
||||
|
||||
{!isPending && !isError && banners?.length === 0 && (
|
||||
<div className="flex flex-col items-center space-y-2 py-12 text-center" data-testid="banners-empty">
|
||||
<Megaphone className="size-10 text-muted-foreground" aria-hidden="true" />
|
||||
<p className="text-muted-foreground">{t('offerings.banners.empty')}</p>
|
||||
</div>
|
||||
)}
|
||||
{!isPending &&
|
||||
!isError &&
|
||||
POSITIONS.map((position) => {
|
||||
const items = (banners ?? []).filter((b) => b.position === position);
|
||||
const live = liveBannerOf(items);
|
||||
return (
|
||||
<section key={position} className="space-y-3" data-testid={`banners-section-${position}`}>
|
||||
<div className="flex flex-wrap items-center justify-between gap-2">
|
||||
<div className="space-y-1">
|
||||
<h2 className="text-base font-semibold">{t(`offerings.banners.section.${position}.title`)}</h2>
|
||||
<p className="text-sm text-muted-foreground">
|
||||
{t(`offerings.banners.section.${position}.description`)}
|
||||
</p>
|
||||
<p className="text-xs text-muted-foreground" data-testid={`banner-live-hint-${position}`}>
|
||||
{live
|
||||
? t('offerings.banners.liveNow', { title: live.title || live.text })
|
||||
: t('offerings.banners.nothingActive')}
|
||||
</p>
|
||||
</div>
|
||||
<Button type="button" onClick={() => setCreating(position)} data-testid={`banner-add-${position}`}>
|
||||
<Plus className="mr-1 size-4" aria-hidden="true" />
|
||||
{t(`offerings.banners.section.${position}.addButton`)}
|
||||
</Button>
|
||||
</div>
|
||||
|
||||
{banners && banners.length > 0 && (
|
||||
<ul className="space-y-2" data-testid="banners-list">
|
||||
{banners.map((b) => {
|
||||
const status = bannerStatus(b);
|
||||
return (
|
||||
<li
|
||||
key={b.id}
|
||||
className="flex flex-col gap-2 rounded-md border p-3 sm:flex-row sm:items-center sm:justify-between"
|
||||
data-testid={`banner-row-${b.id}`}
|
||||
>
|
||||
<div className="min-w-0 space-y-1">
|
||||
<div className="flex flex-wrap items-center gap-2">
|
||||
<span className="font-medium">{b.title}</span>
|
||||
<Badge variant={statusVariant[status]} data-testid={`banner-status-${b.id}`}>
|
||||
{t(`offerings.banners.status.${status}`)}
|
||||
</Badge>
|
||||
</div>
|
||||
<p className="truncate text-sm text-muted-foreground">{b.text}</p>
|
||||
{(b.startsAt || b.endsAt) && (
|
||||
<p className="text-xs text-muted-foreground">
|
||||
{fmt(b.startsAt) ?? '…'} – {fmt(b.endsAt) ?? '…'}
|
||||
</p>
|
||||
)}
|
||||
{items.length === 0 ? (
|
||||
<div
|
||||
className="flex flex-col items-center space-y-2 py-8 text-center"
|
||||
data-testid={`banners-empty-${position}`}
|
||||
>
|
||||
<Megaphone className="size-8 text-muted-foreground" aria-hidden="true" />
|
||||
<p className="text-muted-foreground">{t('offerings.banners.empty')}</p>
|
||||
</div>
|
||||
<div className="flex shrink-0 gap-2">
|
||||
<Button
|
||||
type="button"
|
||||
variant="outline"
|
||||
size="icon"
|
||||
className="size-11"
|
||||
aria-label={t('offerings.banners.editButton')}
|
||||
title={t('offerings.banners.editButton')}
|
||||
data-testid={`banner-edit-${b.id}`}
|
||||
onClick={() => setEditing(b)}
|
||||
>
|
||||
<Pencil className="size-4" aria-hidden="true" />
|
||||
</Button>
|
||||
<Button
|
||||
type="button"
|
||||
variant="outline"
|
||||
size="icon"
|
||||
className="size-11"
|
||||
aria-label={t('offerings.banners.deleteButton')}
|
||||
title={t('offerings.banners.deleteButton')}
|
||||
data-testid={`banner-delete-${b.id}`}
|
||||
onClick={() => setPendingDelete(b)}
|
||||
>
|
||||
<Trash2 className="size-4" aria-hidden="true" />
|
||||
</Button>
|
||||
</div>
|
||||
</li>
|
||||
);
|
||||
})}
|
||||
</ul>
|
||||
)}
|
||||
) : (
|
||||
<ul className="space-y-2" data-testid={`banners-list-${position}`}>
|
||||
{items.map((b) => {
|
||||
const status = bannerStatus(b);
|
||||
const toggleLabel = t(
|
||||
b.isActive ? 'offerings.banners.turnOffButton' : 'offerings.banners.turnOnButton',
|
||||
);
|
||||
return (
|
||||
<li
|
||||
key={b.id}
|
||||
className="flex flex-col gap-2 rounded-md border p-3 sm:flex-row sm:items-center sm:justify-between"
|
||||
data-testid={`banner-row-${b.id}`}
|
||||
>
|
||||
<div className="min-w-0 space-y-1">
|
||||
<div className="flex flex-wrap items-center gap-2">
|
||||
{b.title && <span className="font-medium">{b.title}</span>}
|
||||
<Badge variant={statusVariant[status]} data-testid={`banner-status-${b.id}`}>
|
||||
{t(`offerings.banners.status.${status}`)}
|
||||
</Badge>
|
||||
</div>
|
||||
<p className="truncate text-sm text-muted-foreground">{b.text}</p>
|
||||
{(b.startsAt || b.endsAt) && (
|
||||
<p className="text-xs text-muted-foreground">
|
||||
{fmt(b.startsAt) ?? '…'} – {fmt(b.endsAt) ?? '…'}
|
||||
</p>
|
||||
)}
|
||||
</div>
|
||||
<div className="flex shrink-0 gap-2">
|
||||
<Button
|
||||
type="button"
|
||||
variant="outline"
|
||||
size="icon"
|
||||
className="size-11"
|
||||
aria-label={toggleLabel}
|
||||
title={toggleLabel}
|
||||
disabled={save.isPending}
|
||||
data-testid={`banner-toggle-${b.id}`}
|
||||
onClick={() => toggleActive(b)}
|
||||
>
|
||||
<Power className="size-4" aria-hidden="true" />
|
||||
</Button>
|
||||
<Button
|
||||
type="button"
|
||||
variant="outline"
|
||||
size="icon"
|
||||
className="size-11"
|
||||
aria-label={t('offerings.banners.editButton')}
|
||||
title={t('offerings.banners.editButton')}
|
||||
data-testid={`banner-edit-${b.id}`}
|
||||
onClick={() => setEditing(b)}
|
||||
>
|
||||
<Pencil className="size-4" aria-hidden="true" />
|
||||
</Button>
|
||||
<Button
|
||||
type="button"
|
||||
variant="outline"
|
||||
size="icon"
|
||||
className="size-11"
|
||||
aria-label={t('offerings.banners.deleteButton')}
|
||||
title={t('offerings.banners.deleteButton')}
|
||||
data-testid={`banner-delete-${b.id}`}
|
||||
onClick={() => setPendingDelete(b)}
|
||||
>
|
||||
<Trash2 className="size-4" aria-hidden="true" />
|
||||
</Button>
|
||||
</div>
|
||||
</li>
|
||||
);
|
||||
})}
|
||||
</ul>
|
||||
)}
|
||||
</section>
|
||||
);
|
||||
})}
|
||||
|
||||
<OfferingBannerDialog
|
||||
banner={editing}
|
||||
creating={creating}
|
||||
creatingPosition={creating}
|
||||
onClose={() => {
|
||||
setEditing(null);
|
||||
setCreating(false);
|
||||
setCreating(null);
|
||||
}}
|
||||
/>
|
||||
|
||||
@@ -115,7 +186,7 @@ export function OfferingBannersTab() {
|
||||
<DialogTitle>{t('offerings.banners.deleteTitle')}</DialogTitle>
|
||||
</DialogHeader>
|
||||
<p className="text-sm text-muted-foreground" data-testid="banner-delete-message">
|
||||
{t('offerings.banners.deleteMessage', { title: pendingDelete?.title ?? '' })}
|
||||
{t('offerings.banners.deleteMessage', { title: pendingDelete?.title || pendingDelete?.text || '' })}
|
||||
</p>
|
||||
<div className="flex justify-end gap-2">
|
||||
<Button variant="outline" onClick={() => setPendingDelete(null)} data-testid="banner-delete-cancel">
|
||||
|
||||
@@ -96,6 +96,7 @@ export const offeringsHandlers = [
|
||||
const created: OfferingBannerDto = {
|
||||
id: crypto.randomUUID(),
|
||||
...body,
|
||||
position: body.position ?? 'bottom',
|
||||
updatedAt: new Date().toISOString(),
|
||||
};
|
||||
mockBanners = [created, ...mockBanners];
|
||||
|
||||
@@ -1,9 +1,16 @@
|
||||
import { beforeEach, describe, expect, it } from 'vitest';
|
||||
import { screen, waitFor } from '@testing-library/react';
|
||||
import { screen, waitFor, within } from '@testing-library/react';
|
||||
import userEvent from '@testing-library/user-event';
|
||||
import { renderApp, mockAuthenticated } from '@/test/utils';
|
||||
import { getMockBanners, resetMockOfferings, setMockBanners } from '@/features/offerings/mocks/handlers';
|
||||
import { bannerStatus, fromLocalInput, isAllowedBannerLink, toLocalInput } from '@/features/offerings/schemas/offeringBanner';
|
||||
import {
|
||||
bannerStatus,
|
||||
fromLocalInput,
|
||||
isAllowedBannerLink,
|
||||
offeringBannerFormSchema,
|
||||
toLocalInput,
|
||||
} from '@/features/offerings/schemas/offeringBanner';
|
||||
import type { OfferingBannerDto } from '@/features/offerings/services/types';
|
||||
import { _resetSetupStatusCache } from '@/router';
|
||||
|
||||
beforeEach(() => {
|
||||
@@ -19,6 +26,19 @@ async function openBannerTab() {
|
||||
await userEvent.click(await screen.findByTestId('offerings-tab-banner', {}, T));
|
||||
}
|
||||
|
||||
const banner = (over: Partial<OfferingBannerDto> & { id: string }): OfferingBannerDto => ({
|
||||
position: 'bottom',
|
||||
title: 'Titel',
|
||||
text: 'Tekst',
|
||||
linkLabel: null,
|
||||
linkUrl: null,
|
||||
isActive: true,
|
||||
startsAt: null,
|
||||
endsAt: null,
|
||||
updatedAt: '2026-01-01T00:00:00Z',
|
||||
...over,
|
||||
});
|
||||
|
||||
describe('Banner tab', () => {
|
||||
it('switches between the offerings and the banner tab, hiding the add-offering actions on the banner tab', async () => {
|
||||
mockAuthenticated();
|
||||
@@ -35,11 +55,23 @@ describe('Banner tab', () => {
|
||||
expect(await screen.findByTestId('offerings-add-button')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it('shows an empty state, then creates a banner with a link and a schedule', async () => {
|
||||
it('shows two sections (top and bottom), each with its own empty state and "nothing active" hint', async () => {
|
||||
await openBannerTab();
|
||||
expect(await screen.findByTestId('banners-empty', {}, T)).toBeInTheDocument();
|
||||
const top = await screen.findByTestId('banners-section-top', {}, T);
|
||||
const bottom = screen.getByTestId('banners-section-bottom');
|
||||
expect(within(top).getByTestId('banners-empty-top')).toBeInTheDocument();
|
||||
expect(within(bottom).getByTestId('banners-empty-bottom')).toBeInTheDocument();
|
||||
expect(within(top).getByTestId('banner-add-top')).toBeInTheDocument();
|
||||
expect(within(bottom).getByTestId('banner-add-bottom')).toBeInTheDocument();
|
||||
expect(screen.getByTestId('banner-live-hint-top')).toHaveTextContent(/niets actief|Nothing is active/);
|
||||
expect(screen.getByTestId('banner-live-hint-bottom')).toHaveTextContent(/niets actief|Nothing is active/);
|
||||
});
|
||||
|
||||
await userEvent.click(screen.getByTestId('banner-add-button'));
|
||||
it('creates a bottom banner with a link and a schedule, sending position bottom', async () => {
|
||||
await openBannerTab();
|
||||
expect(await screen.findByTestId('banners-empty-bottom', {}, T)).toBeInTheDocument();
|
||||
|
||||
await userEvent.click(screen.getByTestId('banner-add-bottom'));
|
||||
await userEvent.type(await screen.findByTestId('banner-title'), 'Zomeractie');
|
||||
await userEvent.type(screen.getByTestId('banner-text'), '10% korting in juli');
|
||||
await userEvent.type(screen.getByTestId('banner-link-label'), 'Bekijk');
|
||||
@@ -50,15 +82,50 @@ describe('Banner tab', () => {
|
||||
|
||||
await waitFor(() => expect(getMockBanners()).toHaveLength(1));
|
||||
const saved = getMockBanners()[0];
|
||||
expect(saved).toMatchObject({ title: 'Zomeractie', linkLabel: 'Bekijk', linkUrl: '/privacy', isActive: true });
|
||||
expect(saved).toMatchObject({
|
||||
position: 'bottom',
|
||||
title: 'Zomeractie',
|
||||
linkLabel: 'Bekijk',
|
||||
linkUrl: '/privacy',
|
||||
isActive: true,
|
||||
});
|
||||
expect(saved.startsAt).toBe(fromLocalInput('2030-07-01T09:00'));
|
||||
expect(await screen.findByText('Zomeractie')).toBeInTheDocument();
|
||||
expect(screen.getByTestId(`banner-status-${saved.id}`)).toHaveTextContent(/Gepland|Scheduled/);
|
||||
expect(within(screen.getByTestId('banners-section-bottom')).getByTestId(`banner-status-${saved.id}`)).toHaveTextContent(
|
||||
/Gepland|Scheduled/,
|
||||
);
|
||||
expect(screen.getByTestId('banners-empty-top')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it('requires a title for a bottom banner', async () => {
|
||||
await openBannerTab();
|
||||
await userEvent.click(await screen.findByTestId('banner-add-bottom', {}, T));
|
||||
await userEvent.type(await screen.findByTestId('banner-text'), 'Alleen tekst');
|
||||
await userEvent.click(screen.getByTestId('banner-submit'));
|
||||
expect(await screen.findByTestId('banner-title-error')).toBeInTheDocument();
|
||||
expect(getMockBanners()).toHaveLength(0);
|
||||
});
|
||||
|
||||
it('creates a top banner without a title, limited to 120 characters with a counter', async () => {
|
||||
await openBannerTab();
|
||||
await userEvent.click(await screen.findByTestId('banner-add-top', {}, T));
|
||||
expect(await screen.findByTestId('banner-text')).toHaveAttribute('maxlength', '120');
|
||||
expect(screen.getByTestId('banner-text-counter')).toHaveTextContent('0/120');
|
||||
|
||||
await userEvent.type(screen.getByTestId('banner-text'), 'Gratis verzending deze week');
|
||||
expect(screen.getByTestId('banner-text-counter')).toHaveTextContent('27/120');
|
||||
await userEvent.click(screen.getByTestId('banner-submit'));
|
||||
|
||||
await waitFor(() => expect(getMockBanners()).toHaveLength(1));
|
||||
expect(getMockBanners()[0]).toMatchObject({ position: 'top', title: '', text: 'Gratis verzending deze week' });
|
||||
const top = screen.getByTestId('banners-section-top');
|
||||
expect(await within(top).findByText('Gratis verzending deze week')).toBeInTheDocument();
|
||||
expect(screen.getByTestId('banners-empty-bottom')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it('rejects an unsafe link and a link without button text, and an end before the start', async () => {
|
||||
await openBannerTab();
|
||||
await userEvent.click(await screen.findByTestId('banner-add-button', {}, T));
|
||||
await userEvent.click(await screen.findByTestId('banner-add-bottom', {}, T));
|
||||
await userEvent.type(await screen.findByTestId('banner-title'), 'X');
|
||||
await userEvent.type(screen.getByTestId('banner-text'), 'Y');
|
||||
|
||||
@@ -81,14 +148,43 @@ describe('Banner tab', () => {
|
||||
expect(getMockBanners()).toHaveLength(0);
|
||||
});
|
||||
|
||||
it('edits and deletes an existing banner', async () => {
|
||||
it('lists banners under their own position and shows which one is live (most recently changed wins)', async () => {
|
||||
setMockBanners([
|
||||
{
|
||||
id: 'b1', title: 'Oud', text: 'Tekst', linkLabel: null, linkUrl: null, isActive: true,
|
||||
startsAt: null, endsAt: null, updatedAt: '2026-01-01T00:00:00Z',
|
||||
},
|
||||
banner({ id: 'b-old', title: 'Oud', updatedAt: '2026-01-01T00:00:00Z' }),
|
||||
banner({ id: 'b-new', title: 'Nieuw', updatedAt: '2026-02-01T00:00:00Z' }),
|
||||
banner({ id: 't1', position: 'top', title: '', text: 'Balktekst' }),
|
||||
]);
|
||||
await openBannerTab();
|
||||
const top = await screen.findByTestId('banners-section-top', {}, T);
|
||||
const bottom = screen.getByTestId('banners-section-bottom');
|
||||
|
||||
expect(within(top).getByTestId('banner-row-t1')).toBeInTheDocument();
|
||||
expect(within(top).queryByTestId('banner-row-b-new')).not.toBeInTheDocument();
|
||||
expect(within(bottom).getByTestId('banner-row-b-old')).toBeInTheDocument();
|
||||
expect(within(bottom).getByTestId('banner-row-b-new')).toBeInTheDocument();
|
||||
|
||||
expect(screen.getByTestId('banner-live-hint-bottom')).toHaveTextContent(/Nu live: Nieuw|Live now: Nieuw/);
|
||||
expect(screen.getByTestId('banner-live-hint-top')).toHaveTextContent(/Balktekst/);
|
||||
});
|
||||
|
||||
it('turns a banner off and on from its section', async () => {
|
||||
setMockBanners([banner({ id: 't1', position: 'top', title: '', text: 'Balktekst' })]);
|
||||
await openBannerTab();
|
||||
expect(await screen.findByTestId('banner-status-t1', {}, T)).toHaveTextContent(/Actief|Active/);
|
||||
|
||||
await userEvent.click(screen.getByTestId('banner-toggle-t1'));
|
||||
await waitFor(() => expect(getMockBanners()[0].isActive).toBe(false));
|
||||
expect(getMockBanners()[0].position).toBe('top');
|
||||
expect(await screen.findByTestId('banner-status-t1')).toHaveTextContent(/Uit|Off/);
|
||||
expect(screen.getByTestId('banner-live-hint-top')).toHaveTextContent(/niets actief|Nothing is active/);
|
||||
|
||||
await userEvent.click(screen.getByTestId('banner-toggle-t1'));
|
||||
await waitFor(() => expect(getMockBanners()[0].isActive).toBe(true));
|
||||
});
|
||||
|
||||
it('edits and deletes an existing banner, keeping its position', async () => {
|
||||
setMockBanners([banner({ id: 'b1', title: 'Oud' })]);
|
||||
await openBannerTab();
|
||||
expect(await screen.findByTestId('banner-status-b1', {}, T)).toHaveTextContent(/Actief|Active/);
|
||||
|
||||
await userEvent.click(screen.getByTestId('banner-edit-b1'));
|
||||
@@ -98,14 +194,46 @@ describe('Banner tab', () => {
|
||||
await userEvent.type(title, 'Nieuw');
|
||||
await userEvent.click(screen.getByTestId('banner-active'));
|
||||
await userEvent.click(screen.getByTestId('banner-submit'));
|
||||
await waitFor(() => expect(getMockBanners()[0]).toMatchObject({ title: 'Nieuw', isActive: false }));
|
||||
await waitFor(() => expect(getMockBanners()[0]).toMatchObject({ title: 'Nieuw', isActive: false, position: 'bottom' }));
|
||||
expect(await screen.findByTestId('banner-status-b1')).toHaveTextContent(/Uit|Off/);
|
||||
|
||||
await userEvent.click(screen.getByTestId('banner-delete-b1'));
|
||||
expect(await screen.findByTestId('banner-delete-message')).toHaveTextContent('Nieuw');
|
||||
await userEvent.click(screen.getByTestId('banner-delete-confirm'));
|
||||
await waitFor(() => expect(getMockBanners()).toHaveLength(0));
|
||||
expect(await screen.findByTestId('banners-empty')).toBeInTheDocument();
|
||||
expect(await screen.findByTestId('banners-empty-bottom')).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
describe('banner form schema', () => {
|
||||
const base = {
|
||||
position: 'bottom' as const,
|
||||
title: 'T',
|
||||
text: 'X',
|
||||
linkLabel: '',
|
||||
linkUrl: '',
|
||||
isActive: true,
|
||||
startsAt: '',
|
||||
endsAt: '',
|
||||
};
|
||||
const fieldErrors = (v: object) => {
|
||||
const r = offeringBannerFormSchema.safeParse(v);
|
||||
return r.success ? [] : r.error.issues.map((i) => i.path[0]);
|
||||
};
|
||||
|
||||
it('bottom: title required, text up to 300', () => {
|
||||
expect(fieldErrors(base)).toEqual([]);
|
||||
expect(fieldErrors({ ...base, title: '' })).toContain('title');
|
||||
expect(fieldErrors({ ...base, text: 'x'.repeat(300) })).toEqual([]);
|
||||
expect(fieldErrors({ ...base, text: 'x'.repeat(301) })).toContain('text');
|
||||
});
|
||||
|
||||
it('top: title optional, text up to 120', () => {
|
||||
const top = { ...base, position: 'top' as const, title: '' };
|
||||
expect(fieldErrors(top)).toEqual([]);
|
||||
expect(fieldErrors({ ...top, text: 'x'.repeat(120) })).toEqual([]);
|
||||
expect(fieldErrors({ ...top, text: 'x'.repeat(121) })).toContain('text');
|
||||
expect(fieldErrors({ ...top, text: '' })).toContain('text');
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { z } from 'zod';
|
||||
import type { BannerPosition } from '../services/types';
|
||||
|
||||
/** https:// address or a site path with a single leading slash; mirrors the API rule. */
|
||||
export function isAllowedBannerLink(url: string): boolean {
|
||||
@@ -12,10 +13,19 @@ export function isAllowedBannerLink(url: string): boolean {
|
||||
}
|
||||
}
|
||||
|
||||
export const BANNER_TOP_TEXT_MAX = 120;
|
||||
export const BANNER_BOTTOM_TEXT_MAX = 300;
|
||||
|
||||
export const bannerTextMaxLength = (position: BannerPosition) =>
|
||||
position === 'top' ? BANNER_TOP_TEXT_MAX : BANNER_BOTTOM_TEXT_MAX;
|
||||
|
||||
export const offeringBannerFormSchema = z
|
||||
.object({
|
||||
title: z.string().trim().min(1, 'Title is required').max(100, 'Title must be 100 characters or fewer'),
|
||||
text: z.string().trim().min(1, 'Text is required').max(300, 'Text must be 300 characters or fewer'),
|
||||
position: z.enum(['top', 'bottom']),
|
||||
/** Required for 'bottom', optional for 'top' (checked in superRefine). */
|
||||
title: z.string().trim().max(100, 'Title must be 100 characters or fewer'),
|
||||
/** Max length depends on the position (checked in superRefine). */
|
||||
text: z.string().trim().min(1, 'Text is required'),
|
||||
linkLabel: z.string().trim().max(50, 'Button text must be 50 characters or fewer'),
|
||||
linkUrl: z.string().trim().max(500, 'Link must be 500 characters or fewer'),
|
||||
isActive: z.boolean(),
|
||||
@@ -24,6 +34,13 @@ export const offeringBannerFormSchema = z
|
||||
endsAt: z.string(),
|
||||
})
|
||||
.superRefine((v, ctx) => {
|
||||
if (v.position === 'bottom' && v.title === '') {
|
||||
ctx.addIssue({ code: 'custom', path: ['title'], message: 'Title is required' });
|
||||
}
|
||||
const maxText = bannerTextMaxLength(v.position);
|
||||
if (v.text.length > maxText) {
|
||||
ctx.addIssue({ code: 'custom', path: ['text'], message: `Text must be ${maxText} characters or fewer` });
|
||||
}
|
||||
const hasLabel = v.linkLabel !== '';
|
||||
const hasUrl = v.linkUrl !== '';
|
||||
if (hasLabel !== hasUrl) {
|
||||
|
||||
@@ -40,8 +40,11 @@ export interface OfferingCategoryDto {
|
||||
|
||||
export type MoveDirection = 'up' | 'down';
|
||||
|
||||
export type BannerPosition = 'top' | 'bottom';
|
||||
|
||||
export interface OfferingBannerDto {
|
||||
id: string;
|
||||
position: BannerPosition;
|
||||
title: string;
|
||||
text: string;
|
||||
linkLabel: string | null;
|
||||
@@ -55,6 +58,7 @@ export interface OfferingBannerDto {
|
||||
}
|
||||
|
||||
export interface OfferingBannerRequest {
|
||||
position: BannerPosition;
|
||||
title: string;
|
||||
text: string;
|
||||
linkLabel: string | null;
|
||||
|
||||
Reference in New Issue
Block a user