Hero-admin: voortgangsindicator voor foto's die worden verwerkt, mislukt-melding met opnieuw proberen
Spinner per foto zonder varianten, totaal met voortgangsbalk (aria-valuenow/max), uitleg dat de hero al is opgeslagen, bij 3 mislukte pogingen een melding met 'Opnieuw proberen' (POST /hero/images/{id}/retry; foutstatus staat in het geheugen van de renderer). Test dat een refetch van 5 s onopgeslagen wijzigingen niet overschrijft.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -156,4 +156,37 @@ public class HeroFocusSaveTests
|
||||
|
||||
results.Should().BeEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task AnImageTheRendererGaveUpOn_IsShownAsFailed_AndARetryClearsIt()
|
||||
{
|
||||
using var rig = new HeroTestRig();
|
||||
var dto = await rig.UploadWithoutRendering(HeroTestRig.Photo());
|
||||
var id = Guid.Parse(dto.Id);
|
||||
await rig.Service.SaveAsync(Save(id, null), HeroTestRig.Admin, default);
|
||||
|
||||
for (var i = 0; i < HeroRenderSignal.MaxAttempts; i++)
|
||||
{
|
||||
rig.Signal.RecordFailure(id);
|
||||
}
|
||||
|
||||
var failed = (await rig.Service.GetAsync(default)).Slides[0].Image;
|
||||
failed.Processing.Should().BeTrue();
|
||||
failed.Failed.Should().BeTrue();
|
||||
|
||||
await rig.Images.RetryRenderAsync(id, default);
|
||||
|
||||
(await rig.Service.GetAsync(default)).Slides[0].Image.Failed.Should().BeFalse();
|
||||
(await rig.RenderPending()).Should().Be(1);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ARetryForAnUnknownImage_IsNotFound()
|
||||
{
|
||||
using var rig = new HeroTestRig();
|
||||
|
||||
var act = async () => await rig.Images.RetryRenderAsync(Guid.NewGuid(), default);
|
||||
|
||||
await act.Should().ThrowAsync<HeroImageNotFoundException>();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -32,6 +32,7 @@ public sealed class HeroTestRig : IDisposable
|
||||
public MagickImageProcessor Processor { get; }
|
||||
public MediaStatus Status { get; } = new();
|
||||
public IIndexHtmlCache IndexCache { get; } = Substitute.For<IIndexHtmlCache>();
|
||||
public HeroRenderSignal Signal { get; } = new();
|
||||
public HeroImageService Images { get; }
|
||||
public HeroService Service { get; }
|
||||
public PublicHeroService Public { get; }
|
||||
@@ -51,7 +52,7 @@ public sealed class HeroTestRig : IDisposable
|
||||
Status.SetDirectory(true);
|
||||
var gate = new MediaProcessingGate(mediaOptions);
|
||||
var guard = new MediaUploadGuard(Processor, gate, Status, mediaOptions);
|
||||
Images = new HeroImageService(guard, Processor, Store, gate, Repository, mediaOptions, NullLogger<HeroImageService>.Instance, Time, IndexCache);
|
||||
Images = new HeroImageService(guard, Processor, Store, gate, Repository, mediaOptions, NullLogger<HeroImageService>.Instance, Time, IndexCache, Signal);
|
||||
Service = new HeroService(Repository, Images, Options.Create(HeroOptions), NullLogger<HeroService>.Instance, Time, IndexCache);
|
||||
Public = new PublicHeroService(Repository, Options.Create(HeroOptions), Time);
|
||||
Cleanup = new HeroMediaCleanup(Repository, Store, mediaOptions, NullLogger<HeroMediaCleanup>.Instance, Time);
|
||||
|
||||
Reference in New Issue
Block a user