From 4666c9eb529228cc3e3e7f1615c9da010d0e6bd1 Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Wed, 18 Nov 2026 19:38:46 +0100 Subject: [PATCH] CSP: frame-src van de site-policy zonder 'self' (alleen de ingestelde derde partijen) Co-Authored-By: Claude Sonnet 5.5 --- .../Hosting/Security/StrictSitePolicyTests.cs | 6 +++--- src/SlpModularCms.Core/Hosting/Security/CspPolicyCatalog.cs | 3 ++- .../Hosting/Security/SecurityHeadersOptions.cs | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/SlpModularCms.Core.Tests/Hosting/Security/StrictSitePolicyTests.cs b/src/SlpModularCms.Core.Tests/Hosting/Security/StrictSitePolicyTests.cs index 6cb34ec..cc494a0 100644 --- a/src/SlpModularCms.Core.Tests/Hosting/Security/StrictSitePolicyTests.cs +++ b/src/SlpModularCms.Core.Tests/Hosting/Security/StrictSitePolicyTests.cs @@ -154,11 +154,11 @@ public class StrictSiteFrameSourceTests } [Fact] - public void WithFrameOrigins_FrameSrcListsSelfAndThemOnly_BeforeObjectSrc() + public void WithFrameOrigins_FrameSrcListsThemOnly_WithoutSelf_BeforeObjectSrc() { var set = CspPolicyCatalog.Build(CspPolicyCatalog.StrictSite, [], [], null, null, [Global, Eu + "/"]); - set.ContentSecurityPolicy.Should().Contain($"frame-src 'self' {Global} {Eu}; object-src 'none'"); + set.ContentSecurityPolicy.Should().Contain($"frame-src {Global} {Eu}; object-src 'none'"); set.ContentSecurityPolicy.Should().Contain("frame-ancestors 'none'"); set.FrameOptions.Should().Be("DENY"); } @@ -201,6 +201,6 @@ public class StrictSiteFrameSourceTests using var provider = services.BuildServiceProvider(); provider.GetRequiredService().Get(CspPolicyCatalog.StrictSite) - .ContentSecurityPolicy.Should().Contain($"frame-src 'self' {Global};"); + .ContentSecurityPolicy.Should().Contain($"frame-src {Global};"); } } diff --git a/src/SlpModularCms.Core/Hosting/Security/CspPolicyCatalog.cs b/src/SlpModularCms.Core/Hosting/Security/CspPolicyCatalog.cs index 78f566b..019cf3f 100644 --- a/src/SlpModularCms.Core/Hosting/Security/CspPolicyCatalog.cs +++ b/src/SlpModularCms.Core/Hosting/Security/CspPolicyCatalog.cs @@ -71,7 +71,8 @@ public static class CspPolicyCatalog .Where(origin => !string.IsNullOrWhiteSpace(origin)).ToArray(); if (frames.Length > 0) { - directives.Add($"frame-src {Join("'self'", frames)}"); + // No 'self': a website that embeds only a third party (the captcha widget) frames nothing of its own. + directives.Add($"frame-src {Join(string.Empty, frames).Trim()}"); } directives.AddRange( diff --git a/src/SlpModularCms.Core/Hosting/Security/SecurityHeadersOptions.cs b/src/SlpModularCms.Core/Hosting/Security/SecurityHeadersOptions.cs index 67d01da..69c5e7c 100644 --- a/src/SlpModularCms.Core/Hosting/Security/SecurityHeadersOptions.cs +++ b/src/SlpModularCms.Core/Hosting/Security/SecurityHeadersOptions.cs @@ -74,7 +74,7 @@ public sealed class SecurityHeadersOptions /// /// Origins added as a frame-src directive under the StrictSite policy only (for example the Friendly /// Captcha widget, which renders in an iframe: https://global.frcapi.com, https://eu.frcapi.com). - /// Empty (the default) adds no frame-src at all, so existing headers are unchanged. + /// Empty (the default) adds no frame-src at all, so existing headers are unchanged. The directive lists exactly these origins, without 'self'. /// public IList AllowedSiteFrameOrigins { get; set; } = []; }