Maak slug in CMS zichtbaar en inline aanpasbaar
De CMS-admin toonde het nieuwe Slug-veld nog niet — dat bestond alleen in de API-respons. Voegt een read-only slugweergave onder het titelveld toe met een potlood-icoon om 'm inline te bewerken. Backend: Create/UpdateOfferingRequest accepteren nu een optionele Slug-override. Zonder expliciete waarde blijft het bestaande gedrag (auto-genereren uit titel, regenereren bij titelwijziging). Met een expliciete waarde wordt die genormaliseerd en op uniekheid gecontroleerd; een botsing geeft 409 Conflict (RFC 9457 ProblemDetails, naar het patroon van MasterControlledAvailabilityException). Frontend: de slug wordt alleen meegestuurd als de admin 'm daadwerkelijk bewerkt heeft (dirtyFields.slug), zodat een ongemoeide slug bij een titelwijziging gewoon blijft auto-regenereren. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -46,5 +46,48 @@ describe('OfferingFormPage', () => {
|
||||
|
||||
const titleInput = await screen.findByTestId('offering-title', {}, { timeout: 10000 });
|
||||
expect(titleInput).toHaveValue('Starter');
|
||||
expect(screen.getByTestId('offering-slug-display')).toHaveTextContent('starter');
|
||||
});
|
||||
|
||||
it('shows an auto-generate hint for a new offering until the slug is edited via the pencil icon', async () => {
|
||||
mockAuthenticated();
|
||||
renderApp('/offerings/new');
|
||||
|
||||
await screen.findByTestId('offering-form-submit', {}, { timeout: 10000 });
|
||||
expect(screen.getByTestId('offering-slug-display')).toHaveTextContent(/automatisch|auto-generated/i);
|
||||
|
||||
await userEvent.click(screen.getByTestId('offering-slug-edit'));
|
||||
await userEvent.type(screen.getByTestId('offering-slug'), 'custom-slug');
|
||||
await userEvent.click(screen.getByTestId('offering-slug-confirm'));
|
||||
|
||||
expect(screen.getByTestId('offering-slug-display')).toHaveTextContent('custom-slug');
|
||||
});
|
||||
|
||||
it('reverts the slug when the inline edit is cancelled', async () => {
|
||||
mockAuthenticated();
|
||||
renderApp('/offerings/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/edit');
|
||||
|
||||
await screen.findByTestId('offering-title', {}, { timeout: 10000 });
|
||||
await userEvent.click(screen.getByTestId('offering-slug-edit'));
|
||||
await userEvent.clear(screen.getByTestId('offering-slug'));
|
||||
await userEvent.type(screen.getByTestId('offering-slug'), 'something-else');
|
||||
await userEvent.click(screen.getByTestId('offering-slug-cancel'));
|
||||
|
||||
expect(screen.getByTestId('offering-slug-display')).toHaveTextContent('starter');
|
||||
});
|
||||
|
||||
it('shows a conflict error when the chosen slug is already taken', async () => {
|
||||
mockAuthenticated();
|
||||
renderApp('/offerings/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/edit');
|
||||
|
||||
await screen.findByTestId('offering-title', {}, { timeout: 10000 });
|
||||
await userEvent.click(screen.getByTestId('offering-slug-edit'));
|
||||
await userEvent.clear(screen.getByTestId('offering-slug'));
|
||||
await userEvent.type(screen.getByTestId('offering-slug'), 'pro');
|
||||
await userEvent.click(screen.getByTestId('offering-slug-confirm'));
|
||||
|
||||
await userEvent.click(screen.getByTestId('offering-form-submit'));
|
||||
|
||||
expect(await screen.findByText(/pro.*al in gebruik|already.*taken/i)).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -7,7 +7,7 @@ import { OfferingForm } from '../components/OfferingForm';
|
||||
import { useOffering } from '../services/useOffering';
|
||||
import { useCreateOffering } from '../services/useCreateOffering';
|
||||
import { useUpdateOffering } from '../services/useUpdateOffering';
|
||||
import { NetworkError } from '@/lib/api-client';
|
||||
import { NetworkError, ProblemDetailsError } from '@/lib/api-client';
|
||||
import type { OfferingFormData } from '../schemas/offering';
|
||||
|
||||
export function OfferingFormPage() {
|
||||
@@ -34,7 +34,15 @@ export function OfferingFormPage() {
|
||||
toast.success(t('offerings.form.successToast'));
|
||||
navigate({ to: '/offerings' });
|
||||
} catch (err) {
|
||||
setServerError(err instanceof NetworkError ? t('errors.network') : t('errors.generic'));
|
||||
if (err instanceof NetworkError) {
|
||||
setServerError(t('errors.network'));
|
||||
} else if (err instanceof ProblemDetailsError && err.status === 409) {
|
||||
// Slug conflict: the backend's message is already a user-facing Dutch/English
|
||||
// sentence naming the taken slug — more actionable than a generic fallback.
|
||||
setServerError(err.message);
|
||||
} else {
|
||||
setServerError(t('errors.generic'));
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user