Hero: grote foto's in de achtergrond robuust en sneller, voortgang en opnieuw proberen; admin zonder inline script
- Een decode voor de hele set, per breedte eenmaal geschaald voor WebP en AVIF (6000x4000: 21,1 s -> 6,4 s per set) - Eigen limiet per set (Media:RenderSetTimeoutSeconds 600), harde limiet rond een foto, de renderer stopt nooit door een uitzondering, een mislukte foto wacht tot de volgende ronde en houdt de rij niet op - Logging per foto (start, per variant, einde, fout); voortgang per variant in de admin; nieuwe uitsnede na focuswijziging zichtbaar (oude afbeelding blijft, shimmer); knop Opnieuw proberen - Thema-script als /theme-init.js (CSP script-src 'self'), test en smoke-controle op inline scripts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -5,7 +5,7 @@ import { http, HttpResponse } from 'msw';
|
||||
import { server } from '@/mocks/server';
|
||||
import { API_BASE } from '@/features/auth/mocks/fixtures';
|
||||
import { renderApp, mockAuthenticated } from '@/test/utils';
|
||||
import { emptyHero, failNextUpload, getRetriedImages, getSavedHeroRequests, resetMockHero, setMockHero, slide } from '@/features/hero/mocks/handlers';
|
||||
import { emptyHero, failNextUpload, finishMockRecut, getRetriedImages, getSavedHeroRequests, resetMockHero, setMockHero, slide } from '@/features/hero/mocks/handlers';
|
||||
import { _resetSetupStatusCache } from '@/router';
|
||||
|
||||
const T = { timeout: 10000 };
|
||||
@@ -665,3 +665,74 @@ describe('Order by dragging, wording and calm waiting', () => {
|
||||
expect(screen.getByTestId('hero-slide-0-processing')).toBe(before);
|
||||
}, 20000);
|
||||
});
|
||||
|
||||
|
||||
describe('Progress of a photo that is being prepared', () => {
|
||||
beforeEach(() => {
|
||||
resetMockHero();
|
||||
});
|
||||
|
||||
it('shows which photo is being worked on and at which step', async () => {
|
||||
const waiting = (n: number, step?: [number, number]) => ({
|
||||
...slide(n),
|
||||
image: { ...slide(n).image, variants: [], src: '', processing: true, renderDone: step?.[0] ?? null, renderTotal: step?.[1] ?? null },
|
||||
});
|
||||
setMockHero({ ...emptyHero(), id: 'h1', title: 'T', slides: [slide(1), waiting(2, [7, 16]), waiting(3)] });
|
||||
|
||||
await openPage();
|
||||
|
||||
expect(await screen.findByTestId('hero-processing-current', {}, T)).toHaveTextContent(/foto 2 van 3.*stap 7 van 16|photo 2 of 3.*step 7 of 16/);
|
||||
expect(screen.getByTestId('hero-slide-1-processing-step')).toHaveTextContent('7/16');
|
||||
expect(screen.queryByTestId('hero-slide-2-processing-step')).not.toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
describe('A changed focus point makes a new crop in the background', () => {
|
||||
beforeEach(() => {
|
||||
resetMockHero();
|
||||
});
|
||||
|
||||
it('shows that the new crop is not live yet (old picture underneath), counts it in the total, and clears it when done', async () => {
|
||||
setMockHero({ ...emptyHero(), id: 'h1', title: 'T', slides: [slide(1), slide(2)] });
|
||||
await openPage();
|
||||
await userEvent.click(screen.getByTestId('hero-slide-0-focus'));
|
||||
fireEvent.change(await screen.findByTestId('focus-x', {}, T), { target: { value: '25' } });
|
||||
await userEvent.click(screen.getByTestId('focus-save'));
|
||||
await userEvent.click(screen.getByTestId('hero-save'));
|
||||
|
||||
const recut = await screen.findByTestId('hero-slide-0-recut', {}, T);
|
||||
expect(recut).toHaveClass('hero-shimmer');
|
||||
expect(recut.querySelector('img')).not.toBeNull();
|
||||
expect(recut).toHaveTextContent(/Nieuwe uitsnede|new crop/);
|
||||
expect(screen.getByTestId('hero-processing-count')).toHaveTextContent(/1 van 2|1 of 2/);
|
||||
expect(screen.queryByTestId('hero-slide-1-recut')).not.toBeInTheDocument();
|
||||
|
||||
// The server finishes the new crop; the page asks again by itself.
|
||||
finishMockRecut();
|
||||
await waitFor(() => expect(screen.queryByTestId('hero-slide-0-recut')).not.toBeInTheDocument(), { timeout: 12000 });
|
||||
expect(screen.queryByTestId('hero-processing')).not.toBeInTheDocument();
|
||||
expect(screen.getByTestId('hero-slide-0-focus')).toBeEnabled();
|
||||
}, 25000);
|
||||
|
||||
it('shows a failed new crop with the retry', async () => {
|
||||
const failed = { ...slide(1), image: { ...slide(1).image, processing: true, failed: true } };
|
||||
setMockHero({ ...emptyHero(), id: 'h1', title: 'T', slides: [failed] });
|
||||
|
||||
await openPage();
|
||||
|
||||
expect(await screen.findByTestId('hero-slide-0-recut', {}, T)).toHaveTextContent(/Mislukt|Failed/);
|
||||
await userEvent.click(screen.getByTestId('hero-processing-retry'));
|
||||
await waitFor(() => expect(getRetriedImages()).toEqual([failed.imageId]), T);
|
||||
});
|
||||
|
||||
it('offers to try again for a photo that takes long', async () => {
|
||||
const waiting = { ...slide(1), image: { ...slide(1).image, variants: [], src: '', processing: true } };
|
||||
setMockHero({ ...emptyHero(), id: 'h1', title: 'T', slides: [waiting] });
|
||||
await openPage();
|
||||
|
||||
await userEvent.click(await screen.findByTestId('hero-processing-retry-all', {}, T));
|
||||
|
||||
await waitFor(() => expect(getRetriedImages()).toEqual([waiting.imageId]), T);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user