Master-URL: ongeldige of placeholder-waarde wordt nooit opgeslagen of verstuurd (master slaat achtergrondchecks over, slave weigert met 400, poller meldt invalid_master_url); veilige diagnostiek bij een mislukte poll; releasenote Master__MasterUrl
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -67,6 +67,59 @@ public class MasterStatusPollClientTests
|
||||
ok.LastFailure.Should().BeNull();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("<public-url-of-this-master-instance>")]
|
||||
[InlineData("")]
|
||||
[InlineData("master.example.com")]
|
||||
[InlineData("/relative")]
|
||||
public async Task AnUnusableMasterUrl_IsReportedAsInvalidMasterUrl_NotAsAnException_AndNothingIsSent(string url)
|
||||
{
|
||||
var sent = false;
|
||||
var sut = CreateSut(new CapturingHttpMessageHandler(_ => sent = true));
|
||||
|
||||
var result = await sut.GetStatusAsync(url, ApiKey);
|
||||
|
||||
result.Should().BeNull();
|
||||
sut.LastFailure.Should().Be("invalid_master_url");
|
||||
sut.LastFailure.Should().NotContain(ApiKey);
|
||||
sent.Should().BeFalse();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task AFailure_ComesWithSafeDiagnostics_WhereItWasThrownAndFlagsAboutTheInput_NeverTheUrlKeyOrMessage()
|
||||
{
|
||||
var sut = CreateSut(new ThrowingHttpMessageHandler());
|
||||
|
||||
await sut.GetStatusAsync(MasterUrl, ApiKey);
|
||||
|
||||
sut.LastFailureDetail.Should().Contain("at=").And.Contain("inner=")
|
||||
.And.Contain("url_absolute=true").And.Contain("scheme=https").And.Contain("key_present=true");
|
||||
sut.LastFailureDetail.Should().NotContain(ApiKey).And.NotContain("master.test").And.NotContain("Connection refused");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task AnInvalidAddress_ShowsInTheDetailFlags_AndAMissingKeyToo()
|
||||
{
|
||||
var sut = CreateSut(new FakeHttpMessageHandler(HttpStatusCode.OK));
|
||||
|
||||
await sut.GetStatusAsync("<public-url-of-this-master-instance>", "");
|
||||
|
||||
sut.LastFailure.Should().Be("invalid_master_url");
|
||||
sut.LastFailureDetail.Should().Be("url_absolute=false scheme=none key_present=false");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ASuccess_ClearsTheDiagnostics()
|
||||
{
|
||||
var sut = CreateSut(new FakeHttpMessageHandler(HttpStatusCode.OK, JsonSerializer.Serialize(new { IsAvailable = true })));
|
||||
|
||||
await sut.GetStatusAsync("nonsense", ApiKey);
|
||||
sut.LastFailureDetail.Should().NotBeNull();
|
||||
await sut.GetStatusAsync(MasterUrl, ApiKey);
|
||||
|
||||
sut.LastFailureDetail.Should().BeNull();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetStatusAsync_SetsApiKeyHeader()
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user