From 17553e2f5c61a8b2af14e9c6fb3fa169991bde8b Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Tue, 17 Nov 2026 09:02:54 +0100 Subject: [PATCH] Admin: gedeelde, themagebonden Checkbox en Radio (en RadioGroup); de drie native checkboxen bij Aanbiedingen vervangen Co-Authored-By: Claude Sonnet 5.5 --- frontend/src/components/ui/checkbox.test.tsx | 105 ++++++++++++++++++ frontend/src/components/ui/checkbox.tsx | 77 +++++++++++++ frontend/src/components/ui/radio.tsx | 61 ++++++++++ .../components/OfferingBannerDialog.tsx | 17 ++- .../offerings/components/OfferingForm.tsx | 33 +++--- 5 files changed, 263 insertions(+), 30 deletions(-) create mode 100644 frontend/src/components/ui/checkbox.test.tsx create mode 100644 frontend/src/components/ui/checkbox.tsx create mode 100644 frontend/src/components/ui/radio.tsx diff --git a/frontend/src/components/ui/checkbox.test.tsx b/frontend/src/components/ui/checkbox.test.tsx new file mode 100644 index 0000000..f934d29 --- /dev/null +++ b/frontend/src/components/ui/checkbox.test.tsx @@ -0,0 +1,105 @@ +import { describe, expect, it } from 'vitest'; +import { render, screen } from '@testing-library/react'; +import userEvent from '@testing-library/user-event'; +import { useForm } from 'react-hook-form'; +import { Checkbox, CheckboxField } from './checkbox'; +import { Radio, RadioField, RadioGroup } from './radio'; + +describe('Checkbox', () => { + it('is a real checkbox: Space toggles it and the label is clickable', async () => { + render(); + const box = screen.getByRole('checkbox', { name: 'Uitgelicht' }); + + box.focus(); + await userEvent.keyboard(' '); + expect(box).toBeChecked(); + + await userEvent.click(screen.getByText('Uitgelicht')); + expect(box).not.toBeChecked(); + }); + + it('shows the in-between state and does not change its value', () => { + render(); + const box = screen.getByRole('checkbox', { name: 'alles' }) as HTMLInputElement; + + expect(box.indeterminate).toBe(true); + expect(box).not.toBeChecked(); + }); + + it('can be disabled and marked invalid', async () => { + render(); + const box = screen.getByRole('checkbox', { name: 'x' }); + + expect(box).toBeDisabled(); + expect(box).toHaveAttribute('aria-invalid', 'true'); + await userEvent.click(box); + expect(box).not.toBeChecked(); + }); + + it('draws with the colours of the theme (accent when checked, a visible border, a focus ring)', () => { + render(); + const cls = screen.getByRole('checkbox').className; + + expect(cls).toContain('checked:bg-primary'); + expect(cls).toContain('border-muted-foreground'); + expect(cls).toContain('focus-visible:ring-ring'); + expect(cls).toContain('forced-colors:checked:bg-[Highlight]'); + }); + + it('works with react-hook-form register, like the native input it replaces', async () => { + function Form({ onSubmit }: { onSubmit: (v: { on: boolean }) => void }) { + const { register, handleSubmit } = useForm<{ on: boolean }>({ defaultValues: { on: false } }); + return ( +
+ + + + ); + } + let saved: { on: boolean } | null = null; + render( +
{ + saved = v; + }} + />, + ); + + await userEvent.click(screen.getByLabelText('Aan')); + await userEvent.click(screen.getByText('go')); + + await screen.findByText('go'); + expect(saved).toEqual({ on: true }); + }); +}); + +describe('Radio', () => { + it('is a real radio group: the arrow keys move and select, with a name for the group', async () => { + render( + + + + , + ); + expect(screen.getByRole('radiogroup', { name: 'Weergave' })).toBeInTheDocument(); + const first = screen.getByRole('radio', { name: 'Enkel' }); + const second = screen.getByRole('radio', { name: 'Diavoorstelling' }); + + first.focus(); + await userEvent.keyboard('{ArrowDown}'); + + expect(second).toBeChecked(); + expect(first).not.toBeChecked(); + expect(second).toHaveFocus(); + }); + + it('can be disabled and marked invalid, and uses theme colours', () => { + render(); + const radio = screen.getByRole('radio'); + + expect(radio).toBeDisabled(); + expect(radio).toHaveAttribute('aria-invalid', 'true'); + expect(radio.className).toContain('checked:border-primary'); + expect(radio.className).toContain('forced-colors:checked:border-[Highlight]'); + }); +}); diff --git a/frontend/src/components/ui/checkbox.tsx b/frontend/src/components/ui/checkbox.tsx new file mode 100644 index 0000000..bd5e648 --- /dev/null +++ b/frontend/src/components/ui/checkbox.tsx @@ -0,0 +1,77 @@ +import * as React from 'react'; +import { Check, Minus } from 'lucide-react'; +import { cn } from '@/lib/utils'; + +export interface CheckboxProps extends Omit, 'type' | 'size'> { + /** The "some of them" state of a parent checkbox. It is shown with a minus; the value of the box itself does not change. */ + indeterminate?: boolean; + /** The field has an error: a red border (and aria-invalid for screen readers). */ + invalid?: boolean; +} + +/** + * A real checkbox (a native input: Space toggles it, it works with a label, with react-hook-form's register and in forms), + * drawn in the colours of the theme: a clear border, the accent colour with a check mark when checked, a minus for the + * in-between state, hover, a focus ring, disabled and error states. The check mark is an icon over the input in the + * "primary foreground" colour; in forced-colors (high contrast) mode the system colours take over. + */ +export const Checkbox = React.forwardRef( + ({ className, indeterminate = false, invalid = false, ...props }, forwardedRef) => { + const inner = React.useRef(null); + const setRef = (element: HTMLInputElement | null) => { + inner.current = element; + if (typeof forwardedRef === 'function') forwardedRef(element); + else if (forwardedRef) forwardedRef.current = element; + }; + React.useEffect(() => { + if (inner.current) inner.current.indeterminate = indeterminate; + }, [indeterminate]); + + return ( + + + + ); + }, +); +Checkbox.displayName = 'Checkbox'; + +interface CheckboxFieldProps extends CheckboxProps { + label: React.ReactNode; +} + +/** A checkbox with its label: the whole line is clickable and at least 24 px high. */ +export const CheckboxField = React.forwardRef(({ label, id, disabled, ...props }, ref) => { + const generated = React.useId(); + const inputId = id ?? generated; + return ( + + ); +}); +CheckboxField.displayName = 'CheckboxField'; diff --git a/frontend/src/components/ui/radio.tsx b/frontend/src/components/ui/radio.tsx new file mode 100644 index 0000000..c7e7019 --- /dev/null +++ b/frontend/src/components/ui/radio.tsx @@ -0,0 +1,61 @@ +import * as React from 'react'; +import { cn } from '@/lib/utils'; + +export interface RadioProps extends Omit, 'type' | 'size'> { + invalid?: boolean; +} + +/** + * A real radio button (a native input: with the same name the arrow keys move and select inside the group, Space selects), + * drawn in the colours of the theme: a clear round border, the accent colour with a dot when selected, hover, a focus + * ring, disabled and error states, and system colours in forced-colors (high contrast) mode. + */ +export const Radio = React.forwardRef(({ className, invalid = false, ...props }, ref) => ( + + + +)); +Radio.displayName = 'Radio'; + +interface RadioFieldProps extends RadioProps { + label: React.ReactNode; +} + +/** A radio button with its label: the whole line is clickable and at least 24 px high. */ +export const RadioField = React.forwardRef(({ label, id, disabled, ...props }, ref) => { + const generated = React.useId(); + const inputId = id ?? generated; + return ( + + ); +}); +RadioField.displayName = 'RadioField'; + +/** The group around related radio buttons: role radiogroup with a name, so a screen reader announces what is chosen. */ +export function RadioGroup({ label, className, children, ...props }: { label: string } & Omit, 'aria-label'>) { + return ( +
+ {children} +
+ ); +} diff --git a/frontend/src/features/offerings/components/OfferingBannerDialog.tsx b/frontend/src/features/offerings/components/OfferingBannerDialog.tsx index 3d76414..80248f2 100644 --- a/frontend/src/features/offerings/components/OfferingBannerDialog.tsx +++ b/frontend/src/features/offerings/components/OfferingBannerDialog.tsx @@ -5,6 +5,7 @@ import { useTranslation } from 'react-i18next'; import { toast } from 'sonner'; import { Button } from '@/components/ui/button'; import { Input } from '@/components/ui/input'; +import { CheckboxField } from '@/components/ui/checkbox'; import { Label } from '@/components/ui/label'; import { FieldError } from '@/components/ui/FieldError'; import { FormErrorBanner } from '@/components/ui/FormErrorBanner'; @@ -211,16 +212,12 @@ function OfferingBannerForm({

{t('offerings.banners.scheduleHint')}

-
- - -
+