Handback-documenten bijgewerkt, Build-and-Test-aanvulling, Operations-vragen e-mailfeature
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -32,3 +32,24 @@ The 301 `Location` was built from the decoded path without re-encoding: `/a%3Fb/
|
||||
2. Setup token must be removed from `shared/env` after the first administrator exists (step 17).
|
||||
3. The proxy block change is only the `proxy_pass` target (port 5200); the website repo generator is updated in U3.
|
||||
4. Production for ASF is out of scope.
|
||||
|
||||
## 7. Addendum 2026-11-09: what happened after this hand-back (all on ASF test; nothing on production)
|
||||
After the first test deploy (run 608) the feature was used on `test.andreaslop.nl` and a series of defects and requests came back through the "CMS & API" session. Each has its own record under `aidlc-docs/bugs/` (cause, fix, test) and the deploys are in `audit.md`.
|
||||
|
||||
| Item | Record / where | Shared-code consequence for SlpSoftware |
|
||||
|---|---|---|
|
||||
| Admin files gave 404 in PrerenderedPages mode (catch-all route won over the admin static files) | audit.md, run 610; `notreserved` route constraint | none |
|
||||
| Invitation link pointed at the website root instead of `/admin/...` | audit.md, run 612; `buildAppUrl` | none (frontend only) |
|
||||
| Nine CMS points: invited name not stored, labels, Administrator may use site settings, deactivated or deleted users refused at once (JWT active check), re-inviting a deleted address, setup title, brand logo | `bugs/cms-admin-nine-points` | deactivation takes effect immediately; two additive nullable fields later; Administrator can switch availability |
|
||||
| Pending/expired invitations cannot be removed; invitation lifetime configurable | `bugs/invitation-delete-and-lifetime` | expired invitations now listed; `Identity:Invitation:ExpiryHours` |
|
||||
| Role hierarchy enforced in the API (Administrator only manages Users, never hands out Owner) | same record, follow-up decisions | stricter API |
|
||||
| Owner got 403 when promoting an Administrator to Owner (caller identified by a null name claim) | `bugs/owner-cannot-promote-requester-identity` | fixes the user-management API on every host |
|
||||
| Availability gate stopped the website and `/admin` of a disabled CMS (503) | `bugs/availability-gate-blocks-website-and-admin` | gate now covers `/api/` only |
|
||||
| Setup page shown when the setup status could not be read (429 from the strict login limiter) | `bugs/setup-page-after-failed-status-read` | status read moved to the `refresh` limiter |
|
||||
| Website log level cannot be set through a systemd EnvironmentFile (dot in the variable name) | `Website__LogLevel` (README, infra docs) | none |
|
||||
| Admin layout: the whole page scrolled and the sidebar moved with it | audit/commit `f242da8` | shared layout |
|
||||
| Flaky CI frontend test (redirect timers left running after unmount) | commit `892c548`, hook `useDelayedAction` | shared pages |
|
||||
|
||||
Also built on top of this feature, as its own feature branch: **identity-email-notifications** (mail for invitations, new links, notices and password reset; per-site sender in the site settings; three additive migrations). See `aidlc-docs/features/identity-email-notifications/handback.md`.
|
||||
|
||||
ASF test currently runs the branch `feature/identity-email-notifications` (it contains this whole feature plus the e-mail feature). Still not done for this feature: merge to master (needs Bryan's explicit go and the watched SlpSoftware test deploy), production.
|
||||
|
||||
+13
@@ -34,3 +34,16 @@ Scope: the TEST environment `test.andreaslop.nl`. Production is out of scope; it
|
||||
6. Merging to master deploys the shared Core change and patched packages to SlpSoftware test automatically; watch that deploy.
|
||||
7. Doc-only commits are local and unpushed.
|
||||
8. Production for Andrea Slop Fotografie (not prepared, listed only): own database and user, port 5201, own proxy route and certificate, `Website__NoIndex=false`, own `shared/env`, production deploy path/variables and an approval decision, production Sentry environment and alert rules, backup entry, HSTS preload/redirect review, decision on the placeholder radius and dark mode.
|
||||
|
||||
|
||||
## Status update 2026-11-09 (open follow-ups above, now)
|
||||
1. CI proof: done (runs 607 onward, all later runs green except one timer flake fixed in 892c548).
|
||||
2. First test deploy: DONE (run 608, then 610, 612, 613-626 on the branch). ASF test is live and used by Bryan and Andrea.
|
||||
3. After the first deploy: first administrators exist (Andrea Owner, Bryan Administrator); the verification list was exercised in use. Still to confirm by Bryan/Pi-Main: setup token removed from `shared/env`, forwarded-header behaviour observed (per-client rate-limit partitions), optional Pi timing.
|
||||
4. Sentry alert rules: not confirmed created (owner: "CMS & API" with Bryan's go). Open.
|
||||
5. Backup entry for the test database: not confirmed (Pi-Main). Open.
|
||||
6. Merge to master (and the automatic SlpSoftware test deploy of the shared Core changes, which are now much larger: see handback-u2 addendum): not done, needs Bryan's explicit go; the branch has already been deployed to SlpSoftware test once (run 625/626/627 from the e-mail branch).
|
||||
7. Doc commits: pushed.
|
||||
8. Production: unchanged (not prepared).
|
||||
Operations questions for this feature were all answered (deployment Q1-5 "alles A", monitoring Q1-5 recommended, Q2 = D). Nothing in this feature's Operations stage is waiting for an answer; what remains is the list above plus the e-mail feature's own Operations stage.
|
||||
Note: the log-level variable in the documents above was replaced by `Website__LogLevel` (a variable name with a dot is ignored by systemd).
|
||||
|
||||
Reference in New Issue
Block a user