adds unit tests to cover 80%
This commit is contained in:
@@ -1,10 +1,14 @@
|
||||
using System.IdentityModel.Tokens.Jwt;
|
||||
using System.Security.Claims;
|
||||
using System.Text;
|
||||
using FluentAssertions;
|
||||
using Microsoft.AspNetCore.Http;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Microsoft.IdentityModel.Tokens;
|
||||
using NSubstitute;
|
||||
using SlpModularCms.Core.Availability;
|
||||
using SlpModularCms.Modules.Availability.Middleware;
|
||||
using Xunit;
|
||||
using FluentAssertions;
|
||||
|
||||
namespace SlpModularCms.Modules.Availability.Tests;
|
||||
|
||||
@@ -24,29 +28,23 @@ public class AvailabilityMiddlewareTests
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldAllowRequest_WhenSystemAvailable()
|
||||
{
|
||||
// Arrange
|
||||
var context = new DefaultHttpContext();
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.Available);
|
||||
|
||||
// Act
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
// Assert
|
||||
await _next.Received(1).Invoke(context);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldBlockRequest_WhenSystemUnavailable()
|
||||
{
|
||||
// Arrange
|
||||
var context = new DefaultHttpContext();
|
||||
context.Response.Body = new MemoryStream();
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.NotAvailable);
|
||||
|
||||
// Act
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
// Assert
|
||||
await _next.DidNotReceive().Invoke(Arg.Any<HttpContext>());
|
||||
context.Response.StatusCode.Should().Be(StatusCodes.Status503ServiceUnavailable);
|
||||
}
|
||||
@@ -54,15 +52,124 @@ public class AvailabilityMiddlewareTests
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldAllowBypass_ForStatusEndpoint()
|
||||
{
|
||||
// Arrange
|
||||
var context = new DefaultHttpContext();
|
||||
context.Request.Path = "/api/availability/status";
|
||||
context.Request.Path = "/api/v1/Availability/status";
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.NotAvailable);
|
||||
|
||||
// Act
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
// Assert
|
||||
await _next.Received(1).Invoke(context);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldAllowBypass_ForAuthEndpoints()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Request.Path = "/api/v1/Auth/login";
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.NotAvailable);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.Received(1).Invoke(context);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldAllowBypass_ForSetupStatusEndpoint()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Request.Path = "/api/v1/Setup/status";
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.NotAvailable);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.Received(1).Invoke(context);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldBlockRequest_WhenSystemInMaintenance()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Response.Body = new MemoryStream();
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.Maintenance);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.DidNotReceive().Invoke(Arg.Any<HttpContext>());
|
||||
context.Response.StatusCode.Should().Be(StatusCodes.Status503ServiceUnavailable);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldAllowAdminBypass_WhenOwnerToken()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Request.Headers.Authorization = $"Bearer {CreateJwtWithRole("Owner")}";
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.Maintenance);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.Received(1).Invoke(context);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldAllowAdminBypass_WhenAdministratorToken()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Request.Headers.Authorization = $"Bearer {CreateJwtWithRole("Administrator")}";
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.Maintenance);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.Received(1).Invoke(context);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldNotBypass_WhenUserRoleToken()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Response.Body = new MemoryStream();
|
||||
context.Request.Headers.Authorization = $"Bearer {CreateJwtWithRole("User")}";
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.Maintenance);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.DidNotReceive().Invoke(Arg.Any<HttpContext>());
|
||||
context.Response.StatusCode.Should().Be(StatusCodes.Status503ServiceUnavailable);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldNotBypass_WhenNoAuthorizationHeader()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Response.Body = new MemoryStream();
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.NotAvailable);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.DidNotReceive().Invoke(Arg.Any<HttpContext>());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ShouldNotBypass_WhenInvalidJwtToken()
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Response.Body = new MemoryStream();
|
||||
context.Request.Headers.Authorization = "Bearer not-a-valid-jwt";
|
||||
_service.IsAvailableAsync().Returns(AvailabilityStatus.NotAvailable);
|
||||
|
||||
await _middleware.InvokeAsync(context, _service);
|
||||
|
||||
await _next.DidNotReceive().Invoke(Arg.Any<HttpContext>());
|
||||
}
|
||||
|
||||
private static string CreateJwtWithRole(string role)
|
||||
{
|
||||
var key = new SymmetricSecurityKey(Encoding.UTF8.GetBytes("test-signing-key-at-least-32-chars-long!"));
|
||||
var creds = new SigningCredentials(key, SecurityAlgorithms.HmacSha256);
|
||||
var token = new JwtSecurityToken(
|
||||
claims: [new Claim(ClaimTypes.Role, role)],
|
||||
expires: DateTime.UtcNow.AddHours(1),
|
||||
signingCredentials: creds
|
||||
);
|
||||
return new JwtSecurityTokenHandler().WriteToken(token);
|
||||
}
|
||||
}
|
||||
|
||||
+69
@@ -0,0 +1,69 @@
|
||||
using System.Security.Claims;
|
||||
using FluentAssertions;
|
||||
using Microsoft.AspNetCore.Http;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
using NSubstitute;
|
||||
using SlpModularCms.Core.Availability;
|
||||
using SlpModularCms.Modules.Availability.Controllers;
|
||||
using SlpModularCms.Modules.Availability.Services;
|
||||
|
||||
namespace SlpModularCms.Modules.Availability.Tests.Controllers;
|
||||
|
||||
public class AvailabilityControllerTests
|
||||
{
|
||||
private readonly IAvailabilityService _availabilityService = Substitute.For<IAvailabilityService>();
|
||||
|
||||
private AvailabilityController CreateController(string? callerName = null)
|
||||
{
|
||||
var controller = new AvailabilityController(_availabilityService);
|
||||
var httpContext = new DefaultHttpContext();
|
||||
if (callerName is not null)
|
||||
{
|
||||
httpContext.User = new ClaimsPrincipal(
|
||||
new ClaimsIdentity([new Claim(ClaimTypes.Name, callerName)], "TestAuth"));
|
||||
}
|
||||
controller.ControllerContext = new ControllerContext { HttpContext = httpContext };
|
||||
return controller;
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetStatus_ReturnsOk_WithStatusDetails()
|
||||
{
|
||||
_availabilityService.GetStatusDetailsAsync()
|
||||
.Returns(new AvailabilityStatusDetails(AvailabilityStatus.Available, null));
|
||||
|
||||
var result = await CreateController().GetStatus();
|
||||
|
||||
var ok = result.Should().BeOfType<OkObjectResult>().Subject;
|
||||
ok.Value.Should().BeEquivalentTo(new
|
||||
{
|
||||
Status = "Available",
|
||||
Message = string.Empty,
|
||||
}, options => options.ExcludingMissingMembers());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetStatus_ReturnsOk_WithMaintenanceMessageIncluded()
|
||||
{
|
||||
_availabilityService.GetStatusDetailsAsync()
|
||||
.Returns(new AvailabilityStatusDetails(AvailabilityStatus.Maintenance, "Gepland onderhoud"));
|
||||
|
||||
var result = await CreateController().GetStatus();
|
||||
|
||||
var ok = result.Should().BeOfType<OkObjectResult>().Subject;
|
||||
ok.Value.Should().BeEquivalentTo(new
|
||||
{
|
||||
Status = "Maintenance",
|
||||
Message = "Gepland onderhoud",
|
||||
}, options => options.ExcludingMissingMembers());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task UpdateStatus_ReturnsBadRequest_WhenServiceIsNotPersistentAvailabilityService()
|
||||
{
|
||||
var result = await CreateController("admin@test.com")
|
||||
.UpdateStatus(new UpdateStatusRequest(AvailabilityStatus.Maintenance, "Onderhoud"));
|
||||
|
||||
result.Should().BeOfType<BadRequestObjectResult>();
|
||||
}
|
||||
}
|
||||
+36
-12
@@ -57,21 +57,45 @@ public class PersistentAvailabilityServiceTests
|
||||
[Fact]
|
||||
public async Task CircuitBreaker_ShouldReturnCachedStatus_AfterDatabaseError()
|
||||
{
|
||||
// Deze test is lastig met in-memory DB omdat deze zelden 'failt'.
|
||||
// Maar we kunnen de logica testen door de context te disposen (simulatie van DB error).
|
||||
|
||||
// Arrange
|
||||
await _service.UpdateStatusAsync(AvailabilityStatus.Available, "Reset", "System");
|
||||
_context.Dispose(); // Forceer error op volgende DB call
|
||||
_context.Dispose(); // Force DB error on next call
|
||||
|
||||
// Act
|
||||
var status1 = await _service.IsAvailableAsync(); // Deze zou moeten failen en circuit breaker activeren
|
||||
var status1 = await _service.IsAvailableAsync();
|
||||
|
||||
status1.Should().Be(AvailabilityStatus.Available); // Fallback
|
||||
|
||||
// Assert
|
||||
status1.Should().Be(AvailabilityStatus.Available); // Fallback status
|
||||
|
||||
// Act 2: Circuit breaker is nu actief
|
||||
var status2 = await _service.IsAvailableAsync();
|
||||
status2.Should().Be(AvailabilityStatus.Available); // Direct uit cache
|
||||
status2.Should().Be(AvailabilityStatus.Available); // From cache (circuit breaker active)
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetStatusDetailsAsync_ShouldReturnAvailable_WhenNoStateInDb()
|
||||
{
|
||||
var details = await _service.GetStatusDetailsAsync();
|
||||
|
||||
details.Status.Should().Be(AvailabilityStatus.Available);
|
||||
details.Message.Should().BeNull();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetStatusDetailsAsync_ShouldReturnCorrectStatusAndMessage()
|
||||
{
|
||||
await _service.UpdateStatusAsync(AvailabilityStatus.Maintenance, "Scheduled maintenance", "Admin");
|
||||
|
||||
var details = await _service.GetStatusDetailsAsync();
|
||||
|
||||
details.Status.Should().Be(AvailabilityStatus.Maintenance);
|
||||
details.Message.Should().Be("Scheduled maintenance");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetStatusDetailsAsync_ShouldReturnFallback_WhenDatabaseError()
|
||||
{
|
||||
await _service.UpdateStatusAsync(AvailabilityStatus.Available, null, "System");
|
||||
_context.Dispose(); // Force DB error
|
||||
|
||||
var details = await _service.GetStatusDetailsAsync();
|
||||
|
||||
details.Status.Should().Be(AvailabilityStatus.Available); // Fallback
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user