From 0bea72202bc8089213c115f41d69632777a45f61 Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Tue, 17 Nov 2026 10:30:18 +0100 Subject: [PATCH] Docs: Hero afgesloten (Build and Test, release-checklist 4b, aannamelijst met besluiten van 2026-11-17) Co-Authored-By: Claude Sonnet 5.5 --- aidlc-docs/active-features.md | 2 +- .../features/hero-module/aidlc-state.md | 6 ++--- .../assumptions-and-open-questions.md | 11 ++++++++ .../build-and-test/build-and-test-summary.md | 26 +++++++++++++++++++ docs/release-checklist-productie.md | 5 ++++ 5 files changed, 46 insertions(+), 4 deletions(-) create mode 100644 aidlc-docs/features/hero-module/construction/build-and-test/build-and-test-summary.md diff --git a/aidlc-docs/active-features.md b/aidlc-docs/active-features.md index f573689..54eb947 100644 --- a/aidlc-docs/active-features.md +++ b/aidlc-docs/active-features.md @@ -24,5 +24,5 @@ | Feature | [ASF: host injecteert in voorgerenderde pagina's (asf-host-injection)](features/asf-host-injection/plan.md) | ✅ Gebouwd en op test (afgesloten 2026-11-16; ASF-productie op IIS is een apart, later plan) | feature/contact-forms-module | Core (Hosting/Website), Modules.Offerings, docs | 2026-11-15 | | Feature | [Vertaalbestanden backend (translation-files)](../docs/translation-files.md) | ✅ Afgesloten 2026-11-16 (stappen 1-8, docs; buiten AI-DLC gebouwd; goedgekeurd door Bryan via SLS-Main; productie via de checklist) | feature/contact-forms-module | Core (Texts, Email, Identity, Hosting), Modules.Availability, Modules.Offerings | 2026-11-15 | | Bug | [theme-toggle-first-click](bugs/theme-toggle-first-click/bug-fix.md) | ✅ Complete (niet gecommit/gemerged; buiten AI-DLC gebouwd; oorzaak niet in een echte browser nagebootst) | feature/contact-forms-module | Frontend (useTheme, index.html) | 2026-11-15 | -| Feature | [Hero module (hero-module)](features/hero-module/aidlc-state.md) | 🔵 Inception (Requirements: vragen aan Bryan) | feature/hero-module | Modules (new Hero), Core (Hosting/Website, host injection), CI (release/-regel voor SLS-productie), Frontend (admin) | 2026-11-16 | +| Feature | [Hero module (hero-module)](features/hero-module/aidlc-state.md) | ✅ Afgesloten 2026-11-17 (Build and Test gesloten, Operations in de gezamenlijke productie-checklist 4b; op test door Bryan geaccepteerd; merge naar master via SLS-Main, productie wacht op Bryans go) | feature/hero-module | Modules (new Hero), Core (Hosting/Website, host injection), CI (release/-regel voor SLS-productie), Frontend (admin) | 2026-11-16 | | Feature | [Mediabibliotheek (media-library)](features/media-library/overview.md) | ⚪ Gepland (volgt na de Hero-merge; nog geen AI-DLC-stappen) | n.v.t. | Core (Media), Modules.Hero, later gallerij-module, Frontend (admin) | 2026-11-17 | diff --git a/aidlc-docs/features/hero-module/aidlc-state.md b/aidlc-docs/features/hero-module/aidlc-state.md index 78b590b..a85d2aa 100644 --- a/aidlc-docs/features/hero-module/aidlc-state.md +++ b/aidlc-docs/features/hero-module/aidlc-state.md @@ -5,7 +5,7 @@ - **Feature Slug**: hero-module - **Project Type**: Brownfield - **Start Date**: 2026-11-16 -- **Current Stage**: CONSTRUCTION - Build and Test (first test deploy next) +- **Current Stage**: CLOSED 2026-11-17 (Build and Test closed; Operations in the joint production checklist; merge to master by SLS-Main after green PR checks) - **Branch**: feature/hero-module (worktree K:\Development\Projects\SlpModularCms-contact-forms, from master b2cacfe) ## Workspace State @@ -54,6 +54,6 @@ - [x] NFR Design (construction/nfr-design/) - [x] Infrastructure Design (media directory; construction/infrastructure-design/) - [x] Code Generation - H0 to H6 built (LCP measurement on the test hosts is part of Build and Test) -- [ ] Build and Test - EXECUTE +- [x] Build and Test - closed 2026-11-17 (construction/build-and-test/build-and-test-summary.md) ### 🟡 OPERATIONS PHASE -- [ ] SKIP (Q19 = B; points go into the joint production checklist) +- [x] SKIP (Q19 = B; points are in section 4b of docs/release-checklist-productie.md) diff --git a/aidlc-docs/features/hero-module/assumptions-and-open-questions.md b/aidlc-docs/features/hero-module/assumptions-and-open-questions.md index f5c4275..b67b3c4 100644 --- a/aidlc-docs/features/hero-module/assumptions-and-open-questions.md +++ b/aidlc-docs/features/hero-module/assumptions-and-open-questions.md @@ -35,3 +35,14 @@ Kept while Bryan was away (2026-11-16): no questions to him, a likely assumption | 29 | **A photo could stay "processing" for ever** in the admin: a photo that was uploaded but not saved yet only had the state of the upload response. | The page now asks the server for those photos one by one (`GET /api/v1/hero/images/{id}`, every 5 s while processing, also in a background tab); each photo shows its own state and, when done, a short "Processing finished" note on that photo (no toast). A photo that was already in the CMS (`reused`, internal only) looks the same and is ready at once. | n/a | `heroImageQuery`, `DoneStatus` | | 30 | **Planning (from/to) and the hero-wide on/off are gone** (Bryan, 2026-11-17): the hero is part of the design and always on; a planning per slide became too much trouble. | Removed from model, API (PUT/GET, OpenAPI), validation, host logic (`IsLive` = has a title), admin (fields, nl/en texts) and tests; migration `RemoveHeroScheduleAndSwitch` drops `StartsAt`, `EndsAt` and `IsActive` of the hero (the per-slide `IsActive` stays). The public JSON, golden files and both sites did not depend on them. Without hero data the host writes nothing. | Planning can be added later, probably per slide; a hero-wide switch likewise. | `HeroMapping.IsLive`, migration `RemoveHeroScheduleAndSwitch` | + +## Decisions of 2026-11-17 (Bryan, via SLP Software - SLS - Main) + +| # | Assumption | Decision | Follow-up | +|---|------------|----------|-----------| +| 12, 16 | Upload limits and the 50 published slides | Keep as they are (10 MB, 64 megapixels, 100 uploads per hour, 2 GB total, 50 slides). | None. | +| 10 | AVIF only for slides 2 and up | Bryan asks why the first slide cannot be AVIF only (WebP as fallback). To be evaluated with the ASF session **after the merges** (not in the Hero PR): first slide `` with `` first and WebP as fallback, preload with `type="image/avif"` and `imagesrcset`; check in Chromium, Firefox and WebKit (Playwright) that there is no double download and that a browser without AVIF falls back to WebP; measure bytes and LCP (the LCP element is the hero text, the photo counts little). Golden files change with it, so agree with the ASF session; only adopt when it is not worse, and Bryan checks it later. | Open, after the merges. | +| ASF 11 | Slider markup for the first slide | Bryan chooses the full slider render (first photo with zoom-in); the ASF session does it as a follow-up. | Watch whether the host markup (preload/picture) must change for it. | +| 20 | ASF production hosting (write access, back-up) | Unchanged: Bryan tests with ASF later. | Open. | +| HEIC | iPhone HEIC upload | Still to be tested by Bryan with a real iPhone file (the build cannot write HEIC; only the library self-test ran). | Open. | +| other | Assumptions 2, 3, 6, 7, 9, 14, 17, 18, 20, 22 to 30 | Stay as documented. | None. | diff --git a/aidlc-docs/features/hero-module/construction/build-and-test/build-and-test-summary.md b/aidlc-docs/features/hero-module/construction/build-and-test/build-and-test-summary.md new file mode 100644 index 0000000..3540246 --- /dev/null +++ b/aidlc-docs/features/hero-module/construction/build-and-test/build-and-test-summary.md @@ -0,0 +1,26 @@ +# Build and Test summary: hero-module + +- **Closed**: 2026-11-17 (Bryan: "the features work well"; accepted on the test hosts, relayed by SLP Software - SLS - Main) +- **Branch**: `feature/hero-module` (master merged in before the PR) +- **Scope**: Hero module H0 to H6 (image pipeline with background rendering, media store, backend, host injection, admin), including the changes made after the first test round: background renderer with progress and retry, tabs Content/Images, sticky save bar, per-photo "Processing finished", drag reorder, multi-upload, unsaved-changes guard, crop thumbnail with live preview, no hero-wide schedule or on/off (migration `RemoveHeroScheduleAndSwitch`), refresh-token race fix, renderer backlog log. + +## Result + +Counts of the last full run are in the PR (CI runs `SlpModularCms.Ci.slnf` against MariaDB and the frontend `pnpm run build`, `lint`, `test`). Local runs before this closing: Hero.Tests 173, Core.Tests 925, Contact, Identity, Offerings, Availability, Master all pass; Api.Tests pass against a local MariaDB; frontend build, lint and 671 tests pass. + +## Verified on the test hosts + +- Upload and save fast on the Raspberry Pi (background rendering); a 4.4 MB photo finishes; progress, failed state and retry in the admin. +- Anonymous smoke test (`scripts/smoke-site.sh`) on SLS-test and ASF-test: injected hero markers, no inline script in the admin, `/theme-init.js` served. +- LCP/CLS with Lighthouse (mobile, 5 runs, median, 2026-11-17): SLS 0.71 score, LCP about 5.0 s (text, SPA bundle bound), CLS 0.00 after the SLS-side fix of the static packages list (it was 0.35, not caused by the hero); ASF 0.78 score, LCP about 5.0 s against 6.0 s for the baked page, CLS 0.00. + +## Not verified here (carried into the production checklist, section 4b) + +- A real iPhone HEIC upload (the build cannot write HEIC; only the library self-test ran). +- Write access of the IIS application pool to the media directory on ASF production (Bryan to test with ASF). +- Real Raspberry Pi timings in production on the final renderer, and a browser check of the layout (light/dark, narrow/wide, collapsed menu) of the new tabs and save bar. +- The OpenAPI snapshot (`openapi/slpsoftware.v1.json`) was edited by hand after the schedule removal; CI regenerates and compares it. + +## Operations + +Not run as a separate stage (Q19 = B). The points are in [docs/release-checklist-productie.md](../../../../../docs/release-checklist-productie.md), section 4b. diff --git a/docs/release-checklist-productie.md b/docs/release-checklist-productie.md index ac331c4..88d767a 100644 --- a/docs/release-checklist-productie.md +++ b/docs/release-checklist-productie.md @@ -46,6 +46,11 @@ Achtergrond per onderwerp: [deploy-en-testomgevingen.md](deploy-en-testomgevinge - [ ] De hero staat in het CMS van productie (seed alleen met Bryans go: `scripts/Seed-Hero.ps1`), de focuspunten kloppen en de ASF-foto's zijn gecontroleerd. - [ ] De websites zijn gebouwd met de markers (`CMS:HERO-HTML`, `CMS:HERO-PRELOAD`, `CMS:DATA`); de rooktest slaagt en de LCP van de gerenderde pagina is niet slechter dan die van de ingebakken pagina (Lighthouse, mobiel). - [ ] Het deployartefact past binnen de uploadlimiet van de proxy (de beeldbibliotheek voegt ongeveer 35 MB toe). +- [ ] **Migratie `RemoveHeroScheduleAndSwitch`** (Hero-database): laat de kolommen `StartsAt`, `EndsAt` en `IsActive` van de hero vallen (de planning en de hero-brede aan/uit bestaan niet meer; Bryan, 2026-11-17). Hij draait bij het opstarten; controleer vooraf dat er een recente back-up is. De per-slide aan/uit blijft. +- [ ] **Uploadgrootte van de proxy**: `client_max_body_size` (nginx) staat boven de uploadlimiet van de hero (standaard 10 MB per foto); de proxy-timeout (`proxy_read_timeout`) hoeft niet hoog: een upload slaat alleen het origineel op en de varianten worden op de achtergrond gemaakt. +- [ ] **Per site**: `Hero__TextOnlyRegion=true` en `Hero__TitlePrefix` voor een site zonder hero-afbeeldingen (SLP Software: staan in de committed instellingen); ASF laat beide leeg. `Hero__MaxPublishedSlides` alleen aanpassen als 50 niet past. +- [ ] Na de eerste start staat in het log `Hero image renderer started.` en de samenvattingsregel `Hero image renderer: N images, X waiting for their variants, Y lacking the full-frame preview.`; bij `X`>0 verdwijnt dat binnen enkele minuten (op de Pi rekenen met ongeveer een minuut per grote foto). +- [ ] Vraag in de admin (Hero, Afbeeldingen) na de seed of alle foto's klaar zijn ("Verwerking afgerond"); een foto die blijft hangen heeft een knop Opnieuw proberen. ## 5. Contact-retentie en privacy