Gebruikersbeheer: rolhierarchie in de API afdwingen en uitnodiging opnieuw aanmaken
Een Beheerder mag alleen gebruikers met rol User verwijderen, deactiveren, van rol wisselen of hun uitnodiging intrekken, en kent nooit de Owner-rol toe. De regels staan op een plek (UserManagementRules) en worden in de API afgedwongen. Nieuwe actie om een openstaande of verlopen uitnodiging een nieuwe link te geven (oude link vervalt). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
+333
@@ -0,0 +1,333 @@
|
||||
using System.Security.Claims;
|
||||
using FluentAssertions;
|
||||
using Microsoft.AspNetCore.Http;
|
||||
using Microsoft.AspNetCore.Identity;
|
||||
using Microsoft.AspNetCore.Identity.EntityFrameworkCore;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
using Microsoft.EntityFrameworkCore;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Microsoft.Extensions.Options;
|
||||
using NSubstitute;
|
||||
using SlpModularCms.Core.Data;
|
||||
using SlpModularCms.Core.Identity.Authorization;
|
||||
using SlpModularCms.Core.Identity.Entities;
|
||||
using SlpModularCms.Core.Identity.Models;
|
||||
using SlpModularCms.Core.Identity.Services;
|
||||
using SlpModularCms.Modules.Identity.Controllers;
|
||||
|
||||
namespace SlpModularCms.Modules.Identity.Tests.Controllers;
|
||||
|
||||
/// <summary>
|
||||
/// Who may act on whom, enforced by the API itself (the UI only mirrors it): an Administrator reaches
|
||||
/// plain Users only; Owners and Administrators are an Owner's to manage; the last Owner stays.
|
||||
/// </summary>
|
||||
public class UsersControllerRoleHierarchyTests : IDisposable
|
||||
{
|
||||
private readonly ApplicationDbContext _context;
|
||||
private readonly UserManager<ApplicationUser> _userManager;
|
||||
private readonly RoleManager<ApplicationRole> _roleManager;
|
||||
private readonly IInvitationService _invitations = Substitute.For<IInvitationService>();
|
||||
|
||||
public UsersControllerRoleHierarchyTests()
|
||||
{
|
||||
var dbOptions = new DbContextOptionsBuilder<ApplicationDbContext>()
|
||||
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
||||
.Options;
|
||||
_context = new ApplicationDbContext(dbOptions);
|
||||
|
||||
_userManager = new UserManager<ApplicationUser>(
|
||||
new UserStore<ApplicationUser, ApplicationRole, ApplicationDbContext, Guid>(_context),
|
||||
Options.Create(new IdentityOptions()),
|
||||
new PasswordHasher<ApplicationUser>(),
|
||||
Array.Empty<IUserValidator<ApplicationUser>>(),
|
||||
Array.Empty<IPasswordValidator<ApplicationUser>>(),
|
||||
new UpperInvariantLookupNormalizer(),
|
||||
new IdentityErrorDescriber(),
|
||||
null!,
|
||||
NullLogger<UserManager<ApplicationUser>>.Instance);
|
||||
|
||||
_roleManager = new RoleManager<ApplicationRole>(
|
||||
new RoleStore<ApplicationRole, ApplicationDbContext, Guid>(_context),
|
||||
Array.Empty<IRoleValidator<ApplicationRole>>(),
|
||||
new UpperInvariantLookupNormalizer(),
|
||||
new IdentityErrorDescriber(),
|
||||
NullLogger<RoleManager<ApplicationRole>>.Instance);
|
||||
|
||||
_invitations.GetAllPendingInvitationsAsync().Returns(new List<PendingInvitationInfo>());
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
_userManager.Dispose();
|
||||
_roleManager.Dispose();
|
||||
_context.Dispose();
|
||||
}
|
||||
|
||||
private async Task<ApplicationUser> Add(string email, string role)
|
||||
{
|
||||
if (!await _roleManager.RoleExistsAsync(role))
|
||||
await _roleManager.CreateAsync(new ApplicationRole { Name = role });
|
||||
|
||||
var user = new ApplicationUser
|
||||
{
|
||||
Id = Guid.NewGuid(), Email = email, UserName = email,
|
||||
NormalizedEmail = email.ToUpperInvariant(), NormalizedUserName = email.ToUpperInvariant(),
|
||||
DisplayName = email, IsActive = true, CreatedAt = DateTimeOffset.UtcNow
|
||||
};
|
||||
await _userManager.CreateAsync(user, "Password1!");
|
||||
await _userManager.AddToRoleAsync(user, role);
|
||||
return user;
|
||||
}
|
||||
|
||||
private UsersController As(ApplicationUser caller)
|
||||
{
|
||||
var controller = new UsersController(_invitations, _userManager);
|
||||
controller.ControllerContext = new ControllerContext
|
||||
{
|
||||
HttpContext = new DefaultHttpContext
|
||||
{
|
||||
User = new ClaimsPrincipal(new ClaimsIdentity([new Claim(ClaimTypes.Name, caller.UserName!)], "Test"))
|
||||
}
|
||||
};
|
||||
return controller;
|
||||
}
|
||||
|
||||
private void OpenInvitation(Guid id, string role) =>
|
||||
_invitations.GetAllPendingInvitationsAsync().Returns(new List<PendingInvitationInfo>
|
||||
{
|
||||
new(id, "invited@test.com", role, "tok", DateTimeOffset.UtcNow)
|
||||
});
|
||||
|
||||
// --- rules ---
|
||||
|
||||
[Theory]
|
||||
[InlineData("Owner", "Owner", true)]
|
||||
[InlineData("Owner", "Administrator", true)]
|
||||
[InlineData("Owner", "User", true)]
|
||||
[InlineData("Administrator", "User", true)]
|
||||
[InlineData("Administrator", "Administrator", false)]
|
||||
[InlineData("Administrator", "Owner", false)]
|
||||
[InlineData("User", "User", false)]
|
||||
public void CanManage_FollowsTheHierarchy(string requester, string target, bool expected) =>
|
||||
UserManagementRules.CanManage(requester, target).Should().Be(expected);
|
||||
|
||||
[Theory]
|
||||
[InlineData("Owner", "Owner", true)]
|
||||
[InlineData("Administrator", "Administrator", true)]
|
||||
[InlineData("Administrator", "User", true)]
|
||||
[InlineData("Administrator", "Owner", false)]
|
||||
public void CanAssign_AdministratorNeverHandsOutOwner(string requester, string role, bool expected) =>
|
||||
UserManagementRules.CanAssign(requester, role).Should().Be(expected);
|
||||
|
||||
// --- delete ---
|
||||
|
||||
[Theory]
|
||||
[InlineData("Owner")]
|
||||
[InlineData("Administrator")]
|
||||
public async Task Administrator_CannotDelete_OwnerOrAdministrator(string targetRole)
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var target = await Add("target@test.com", targetRole);
|
||||
|
||||
(await As(admin).DeleteUser(target.Id)).Should().BeOfType<ForbidResult>();
|
||||
|
||||
(await _userManager.FindByIdAsync(target.Id.ToString())).Should().NotBeNull();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CanDelete_PlainUser()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var target = await Add("target@test.com", "User");
|
||||
|
||||
(await As(admin).DeleteUser(target.Id)).Should().BeOfType<NoContentResult>();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("Administrator")]
|
||||
[InlineData("User")]
|
||||
public async Task Owner_CanDelete_AdministratorAndUser(string targetRole)
|
||||
{
|
||||
var owner = await Add("owner@test.com", "Owner");
|
||||
var target = await Add("target@test.com", targetRole);
|
||||
|
||||
(await As(owner).DeleteUser(target.Id)).Should().BeOfType<NoContentResult>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CannotWithdraw_AnInvitationForAnAdministrator_ButCanForAUser()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var id = Guid.NewGuid();
|
||||
|
||||
OpenInvitation(id, "Administrator");
|
||||
(await As(admin).DeleteUser(id)).Should().BeOfType<ForbidResult>();
|
||||
await _invitations.DidNotReceive().DeleteInvitationByIdAsync(Arg.Any<Guid>());
|
||||
|
||||
OpenInvitation(id, "User");
|
||||
_invitations.DeleteInvitationByIdAsync(id).Returns(true);
|
||||
(await As(admin).DeleteUser(id)).Should().BeOfType<NoContentResult>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Owner_CanWithdraw_AnyInvitation()
|
||||
{
|
||||
var owner = await Add("owner@test.com", "Owner");
|
||||
var id = Guid.NewGuid();
|
||||
OpenInvitation(id, "Administrator");
|
||||
_invitations.DeleteInvitationByIdAsync(id).Returns(true);
|
||||
|
||||
(await As(owner).DeleteUser(id)).Should().BeOfType<NoContentResult>();
|
||||
}
|
||||
|
||||
// --- deactivate ---
|
||||
|
||||
[Theory]
|
||||
[InlineData("Owner")]
|
||||
[InlineData("Administrator")]
|
||||
public async Task Administrator_CannotDeactivate_OwnerOrAdministrator(string targetRole)
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var target = await Add("target@test.com", targetRole);
|
||||
|
||||
(await As(admin).SetUserActive(target.Id, new SetUserActiveRequest(false))).Should().BeOfType<ForbidResult>();
|
||||
|
||||
(await _userManager.FindByIdAsync(target.Id.ToString()))!.IsActive.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CanDeactivate_PlainUser()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var target = await Add("target@test.com", "User");
|
||||
|
||||
(await As(admin).SetUserActive(target.Id, new SetUserActiveRequest(false))).Should().BeOfType<OkResult>();
|
||||
|
||||
(await _userManager.FindByIdAsync(target.Id.ToString()))!.IsActive.Should().BeFalse();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Owner_CanDeactivate_Administrator()
|
||||
{
|
||||
var owner = await Add("owner@test.com", "Owner");
|
||||
var target = await Add("target@test.com", "Administrator");
|
||||
|
||||
(await As(owner).SetUserActive(target.Id, new SetUserActiveRequest(false))).Should().BeOfType<OkResult>();
|
||||
}
|
||||
|
||||
// --- change role ---
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CannotChangeTheRole_OfAnotherAdministratorOrOwner()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var otherAdmin = await Add("other@test.com", "Administrator");
|
||||
var owner = await Add("owner@test.com", "Owner");
|
||||
|
||||
(await As(admin).ChangeRole(otherAdmin.Id, new ChangeRoleRequest("User"))).Should().BeOfType<ForbidResult>();
|
||||
(await As(admin).ChangeRole(owner.Id, new ChangeRoleRequest("User"))).Should().BeOfType<ForbidResult>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CannotMakeAnyoneOwner_NotEvenAPlainUser()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var user = await Add("user@test.com", "User");
|
||||
|
||||
(await As(admin).ChangeRole(user.Id, new ChangeRoleRequest("Owner"))).Should().BeOfType<ForbidResult>();
|
||||
|
||||
(await _userManager.GetRolesAsync(user)).Should().ContainSingle().Which.Should().Be("User");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CanPromoteAUserToAdministrator_AndStepDownThemselves()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var user = await Add("user@test.com", "User");
|
||||
|
||||
(await As(admin).ChangeRole(user.Id, new ChangeRoleRequest("Administrator"))).Should().BeOfType<OkResult>();
|
||||
(await As(admin).ChangeRole(admin.Id, new ChangeRoleRequest("User"))).Should().BeOfType<OkResult>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CannotChangeTheRole_OfAnInvitationForAnAdministrator()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var id = Guid.NewGuid();
|
||||
OpenInvitation(id, "Administrator");
|
||||
|
||||
(await As(admin).ChangeRole(id, new ChangeRoleRequest("User"))).Should().BeOfType<ForbidResult>();
|
||||
await _invitations.DidNotReceive().UpdateInvitationRoleAsync(Arg.Any<Guid>(), Arg.Any<string>());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task TheLastOwner_CannotBeDemoted_EvenByThemselves()
|
||||
{
|
||||
var owner = await Add("owner@test.com", "Owner");
|
||||
|
||||
var result = await As(owner).ChangeRole(owner.Id, new ChangeRoleRequest("User"));
|
||||
|
||||
result.Should().BeOfType<BadRequestObjectResult>();
|
||||
(await _userManager.GetRolesAsync(owner)).Should().ContainSingle().Which.Should().Be("Owner");
|
||||
}
|
||||
|
||||
// --- invite ---
|
||||
|
||||
[Fact]
|
||||
public async Task Administrator_CannotInviteAnOwner_ButCanInviteAUser()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
_invitations.CreateInvitationAsync("new@test.com", "User").Returns("tok");
|
||||
|
||||
(await As(admin).Invite(new InviteUserRequest("new@test.com", "Owner"))).Should().BeOfType<ForbidResult>();
|
||||
await _invitations.DidNotReceive().CreateInvitationAsync("new@test.com", "Owner");
|
||||
|
||||
(await As(admin).Invite(new InviteUserRequest("new@test.com", "User"))).Should().BeOfType<OkObjectResult>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Owner_CanInviteAnOwner()
|
||||
{
|
||||
var owner = await Add("owner@test.com", "Owner");
|
||||
_invitations.CreateInvitationAsync("new@test.com", "Owner").Returns("tok");
|
||||
|
||||
(await As(owner).Invite(new InviteUserRequest("new@test.com", "Owner"))).Should().BeOfType<OkObjectResult>();
|
||||
}
|
||||
|
||||
// --- regenerate ---
|
||||
|
||||
[Fact]
|
||||
public async Task RegenerateInvite_ReturnsANewLink_ForAnOpenOrExpiredInvitation()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var id = Guid.NewGuid();
|
||||
OpenInvitation(id, "User");
|
||||
_invitations.RegenerateInvitationAsync(id).Returns("new-token");
|
||||
|
||||
var result = await As(admin).RegenerateInvite(id);
|
||||
|
||||
result.Should().BeOfType<OkObjectResult>().Which.Value
|
||||
.Should().BeEquivalentTo(new { inviteLink = "/invite/complete?token=new-token" });
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RegenerateInvite_IsNotFound_ForAnUnknownInvitation()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
|
||||
(await As(admin).RegenerateInvite(Guid.NewGuid())).Should().BeOfType<NotFoundResult>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RegenerateInvite_FollowsTheSameHierarchy()
|
||||
{
|
||||
var admin = await Add("admin@test.com", "Administrator");
|
||||
var owner = await Add("owner@test.com", "Owner");
|
||||
var id = Guid.NewGuid();
|
||||
OpenInvitation(id, "Administrator");
|
||||
_invitations.RegenerateInvitationAsync(id).Returns("new-token");
|
||||
|
||||
(await As(admin).RegenerateInvite(id)).Should().BeOfType<ForbidResult>();
|
||||
(await As(owner).RegenerateInvite(id)).Should().BeOfType<OkObjectResult>();
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user