Continuous Integration / config (pull_request) Successful in 17s
Continuous Integration / prepare (pull_request) Successful in 2m13s
Continuous Integration / build-production (pull_request) Skipped
Continuous Integration / test (pull_request) Successful in 3m14s
Continuous Integration / build (pull_request) Successful in 4m14s
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / lighthouse (pull_request) Successful in 3m19s
Continuous Integration / deploy-production (pull_request) Skipped
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3.1 KiB
3.1 KiB
Hero module, SLS side: assumptions and open points
Written 2026-11-17 while the owner was away; to be checked by the owner. The CMS side has its own list (aidlc-docs/features/hero-module/assumptions-and-open-questions.md in the CMS repository, 30 items) and ASF has one too.
| # | Question | Assumption made | If the owner chooses differently | Where |
|---|---|---|---|---|
| 1 | Screen-reader and search-engine heading | "SLP Software: Websites, apps & meer." (brand prefix + title lines joined by spaces; capital W and final full stop come from the seed title). The owner accepted this on 2026-11-16. | Another seed title, or a separate heading field in the CMS (model change). |
src/cms-client/hero/ (headingFromLines), home.hero.headingPrefix in nl.json, host setting Hero:TitlePrefix |
| 2 | Eyebrow ("Web & .NET development") and the code line | Fixed text in the language file, not from the CMS (decided 2026-11-16). | Make them CMS fields (tagline exists in the module). | src/i18n/nl.json (home.hero) |
| 3 | The text-only region for SLS needs host settings | Hero:TextOnlyRegion and Hero:TitlePrefix are set in the committed appsettings.json of the SLP host (Api.SlpSoftware); another host (master Api, local) needs Hero__TextOnlyRegion=true. |
A per-site flag in the CMS or a separate marker. | CMS repo: Api.SlpSoftware/appsettings.json |
| 4 | Look of the injected hero before the app loads | The cms-hero-* classes in src/index.css approximate the React hero. The measured shift was caused by something else (the static packages list); CLS is 0.00 on test. |
Rebuild the hero structure so the injected markup and the React hero are identical. | src/index.css, docs/hero-integration.md |
| 5 | The static packages list for crawlers | It stays in the HTML but is visually hidden (absolute, 1 px, clipped) so removing it at start-up no longer shifts the page. | Move the list elsewhere or inject it inside #root. |
index.html, src/test/layoutStability.test.ts |
| 6 | Largest Contentful Paint | About 5 s on mobile Lighthouse (score 0.71). It is the lead paragraph and is dominated by the app bundle (CSS/JS under throttling), not by the hero. No fix is part of this feature. | A separate performance feature (smaller bundle, critical CSS, prerendered lead without JS). | docs/hero-integration.md |
| 7 | Hero without usable data | The baked hero stays (the host writes nothing); the site reads only the data block, not GET /api/v1/hero (decided with the CMS session). |
Add a fetch fallback like ASF has. | src/cms-client/hero/ |
| 8 | Production | SLS production is not touched. The production job only runs from a release/* branch (same rule as ASF). Before a production release the hero must be seeded in the production CMS (scripts/Seed-Hero.ps1, SLS seed hero-sls.json) and the production host needs the hero module and the settings from item 3. |
n/a | docs/hero-integration.md, aidlc-docs/_shared/joint-release-checklist.md |
| 9 | Button targets | Only #anchor, /path or https://…, at most 2 buttons; others are skipped. |
Allow mailto: or tel: (agree with the CMS side). |
src/cms-client/hero/ (isSafeTarget) |