From d980cc72f83c2a21d8ec7ed74ade27355ff498eb Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Tue, 17 Nov 2026 09:02:35 +0100 Subject: [PATCH] Hero (SLS): feature afgesloten voor test, aannamelijst en overzicht van aannames om te controleren Co-Authored-By: Claude Sonnet 5.5 --- aidlc-docs/_shared/assumptions-to-check.md | 16 ++++++++++++++++ aidlc-docs/features/hero-module/aidlc-state.md | 2 +- .../assumptions-and-open-questions.md | 15 +++++++++++++++ 3 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 aidlc-docs/_shared/assumptions-to-check.md create mode 100644 aidlc-docs/features/hero-module/assumptions-and-open-questions.md diff --git a/aidlc-docs/_shared/assumptions-to-check.md b/aidlc-docs/_shared/assumptions-to-check.md new file mode 100644 index 0000000..e1664c0 --- /dev/null +++ b/aidlc-docs/_shared/assumptions-to-check.md @@ -0,0 +1,16 @@ +# Assumptions to check (coordination, SLS session) + +Kept while the owner was away (2026-11-17). Each item: what I decided or assumed, why, what changes otherwise. The feature-specific lists live in each feature folder (CMS hero: 30 items, ASF hero: 10+, SLS hero: 9, media library: to follow). + +| # | Assumption or decision | Why | If the owner decides differently | +|---|---|---|---| +| 1 | Blanket go (owner, 2026-11-17): when everything is ready, PRs are made and merged to master, and pushes and deploys go to TEST. No production deploys, no `release/*` branches, no branch-protection changes except what is needed to merge. | Explicit message from the owner. | Stop merging; the branches stay as they are. | +| 2 | Merge order: CMS first (hero-module, then messages-badge, then admin-form-controls), then ASF hero, then SLS hero. A merge needs green PR checks. | The sites need the CMS host; the hero module is the largest change. | Another order only matters for conflicts. | +| 3 | The nightly ASF test build is removed (PR #20 merged, efd2aee). No periodic dependency audit replaces it ("niet nodig nu", owner). | The host injects CMS data per request (NFR-10); the nightly build overwrote test with master. | Add a small weekly audit workflow, or Dependabot/Renovate. | +| 4 | After a merge to master, the master run deploys to test only. I redeploy test from the feature branches only as long as they are not in master. | Production is manual and, for ASF and SLS, only from `release/*`. | n/a | +| 5 | The CMS test deploys of both sites go in ONE run (owner, 2026-11-17). | Fewer duplicate pipeline runs. | Split them again if a health check fails because of simultaneous restarts. | +| 6 | Sub-agents: the CMS session works serially because its own rule says sub-agents need the owner's direct request in its session. I use Sonnet sub-agents for my own SLS work. | Working agreement per session. | The owner tells the CMS session to use sub-agents for parallel streams. | +| 7 | The LCP of about 5 s on SLS (mobile) is not part of the hero feature. | Dominated by the app bundle; the hero is not the cause. | A separate performance feature. | +| 8 | Media library: starts after the merges, requirements and design only; nothing that moves data or changes public media addresses is built without the owner. | The owner chose "first the hero, then level 3"; data migrations and public addresses are risky. | Allow building up front. | +| 9 | Privacy statements (SLS concept, ASF page) are not touched; they keep their [OPEN] items (Sentry retention and DPA, Umami, EU transfer, processing agreement with MijnHostingPartner, captcha paragraph). | Owner kept them aside to review himself. | n/a | +| 10 | The CMS session briefly used a stale local master; the Contact module is on master (PR #15, b2cacfe). | Verified on origin/master. | n/a | diff --git a/aidlc-docs/features/hero-module/aidlc-state.md b/aidlc-docs/features/hero-module/aidlc-state.md index 60d7fb5..a3d09a4 100644 --- a/aidlc-docs/features/hero-module/aidlc-state.md +++ b/aidlc-docs/features/hero-module/aidlc-state.md @@ -5,7 +5,7 @@ - **Feature Slug**: hero-module - **Project Type**: Brownfield - **Start Date**: 2026-11-16 -- **Current Stage**: Construction, built for the TEST environment only (no production deploy, no merge to master without the user's go) +- **Current Stage**: COMPLETE for the test environment (2026-11-17). Hero from the CMS on test.slpsoftware.nl, CLS 0.00 and score 0.71 measured by the CMS session (Lighthouse mobile). Merge to master with the owner's blanket go (2026-11-17); no production release. Assumptions to check: `assumptions-and-open-questions.md`. - **Branch**: feature/hero-module ## Workspace State diff --git a/aidlc-docs/features/hero-module/assumptions-and-open-questions.md b/aidlc-docs/features/hero-module/assumptions-and-open-questions.md new file mode 100644 index 0000000..a0bb6f3 --- /dev/null +++ b/aidlc-docs/features/hero-module/assumptions-and-open-questions.md @@ -0,0 +1,15 @@ +# Hero module, SLS side: assumptions and open points + +Written 2026-11-17 while the owner was away; to be checked by the owner. The CMS side has its own list (`aidlc-docs/features/hero-module/assumptions-and-open-questions.md` in the CMS repository, 30 items) and ASF has one too. + +| # | Question | Assumption made | If the owner chooses differently | Where | +|---|---|---|---|---| +| 1 | Screen-reader and search-engine heading | "SLP Software: Websites, apps & meer." (brand prefix + title lines joined by spaces; capital W and final full stop come from the seed title). The owner accepted this on 2026-11-16. | Another seed title, or a separate `heading` field in the CMS (model change). | `src/cms-client/hero/` (`headingFromLines`), `home.hero.headingPrefix` in `nl.json`, host setting `Hero:TitlePrefix` | +| 2 | Eyebrow ("Web & .NET development") and the code line | Fixed text in the language file, not from the CMS (decided 2026-11-16). | Make them CMS fields (tagline exists in the module). | `src/i18n/nl.json` (`home.hero`) | +| 3 | The text-only region for SLS needs host settings | `Hero:TextOnlyRegion` and `Hero:TitlePrefix` are set in the committed `appsettings.json` of the SLP host (`Api.SlpSoftware`); another host (master `Api`, local) needs `Hero__TextOnlyRegion=true`. | A per-site flag in the CMS or a separate marker. | CMS repo: `Api.SlpSoftware/appsettings.json` | +| 4 | Look of the injected hero before the app loads | The `cms-hero-*` classes in `src/index.css` approximate the React hero. The measured shift was caused by something else (the static packages list); CLS is 0.00 on test. | Rebuild the hero structure so the injected markup and the React hero are identical. | `src/index.css`, `docs/hero-integration.md` | +| 5 | The static packages list for crawlers | It stays in the HTML but is visually hidden (absolute, 1 px, clipped) so removing it at start-up no longer shifts the page. | Move the list elsewhere or inject it inside `#root`. | `index.html`, `src/test/layoutStability.test.ts` | +| 6 | Largest Contentful Paint | About 5 s on mobile Lighthouse (score 0.71). It is the lead paragraph and is dominated by the app bundle (CSS/JS under throttling), not by the hero. No fix is part of this feature. | A separate performance feature (smaller bundle, critical CSS, prerendered lead without JS). | `docs/hero-integration.md` | +| 7 | Hero without usable data | The baked hero stays (the host writes nothing); the site reads only the data block, not `GET /api/v1/hero` (decided with the CMS session). | Add a fetch fallback like ASF has. | `src/cms-client/hero/` | +| 8 | Production | SLS production is not touched. The production job only runs from a `release/*` branch (same rule as ASF). Before a production release the hero must be seeded in the production CMS (`scripts/Seed-Hero.ps1`, SLS seed `hero-sls.json`) and the production host needs the hero module and the settings from item 3. | n/a | `docs/hero-integration.md`, `aidlc-docs/_shared/joint-release-checklist.md` | +| 9 | Button targets | Only `#anchor`, `/path` or `https://…`, at most 2 buttons; others are skipped. | Allow `mailto:` or `tel:` (agree with the CMS side). | `src/cms-client/hero/` (`isSafeTarget`) |