Contactformulier stuurt het leesbare onderwerp (met hoofdletter) i.p.v. de slug
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -95,7 +95,7 @@ async function openForm(s: ReturnType<typeof setup>) {
|
||||
function fillValid() {
|
||||
fireEvent.change(screen.getByLabelText('Naam'), { target: { value: 'Jan Jansen' } });
|
||||
fireEvent.change(screen.getByLabelText('E-mail'), { target: { value: 'jan@example.nl' } });
|
||||
fireEvent.change(screen.getByLabelText('Onderwerp'), { target: { value: 'website' } });
|
||||
fireEvent.change(screen.getByLabelText('Onderwerp'), { target: { value: 'Website' } });
|
||||
fireEvent.change(screen.getByLabelText('Bericht'), {
|
||||
target: { value: 'Ik wil graag een offerte.' },
|
||||
});
|
||||
@@ -208,7 +208,7 @@ describe('contact form (BR-U4-4 .. BR-U4-15)', () => {
|
||||
expect(JSON.parse(call.init?.body as string)).toEqual({
|
||||
name: 'Jan Jansen',
|
||||
email: 'jan@example.nl',
|
||||
subject: 'website',
|
||||
subject: 'Website',
|
||||
message: 'Ik wil graag een offerte.',
|
||||
hpCheck: '',
|
||||
token: 'tok-1',
|
||||
@@ -404,11 +404,11 @@ describe('contact form (BR-U4-4 .. BR-U4-15)', () => {
|
||||
await openForm(s);
|
||||
const subject = screen.getByLabelText('Onderwerp') as HTMLSelectElement;
|
||||
fireEvent.click(screen.getByText('kies website'));
|
||||
await waitFor(() => expect(subject.value).toBe('website'));
|
||||
fireEvent.change(subject, { target: { value: 'other' } });
|
||||
expect(subject.value).toBe('other');
|
||||
await waitFor(() => expect(subject.value).toBe('Website'));
|
||||
fireEvent.change(subject, { target: { value: 'Overig' } });
|
||||
expect(subject.value).toBe('Overig');
|
||||
fireEvent.click(screen.getByText('kies website'));
|
||||
await waitFor(() => expect(subject.value).toBe('website'));
|
||||
await waitFor(() => expect(subject.value).toBe('Website'));
|
||||
});
|
||||
|
||||
it('never writes form data to the console, Sentry-style globals or analytics events', async () => {
|
||||
|
||||
@@ -9,6 +9,7 @@ import {
|
||||
} from '../../../cms-client/contact';
|
||||
import { trackEvent } from '../../../shared/analytics/trackEvent';
|
||||
import { useContactPreselect } from '../../../shared/contact/useContactPreselect';
|
||||
import { buildSubjectOptions, subjectForSlug } from '../../../shared/contact/subjects';
|
||||
import { contactForm, contactInfo } from '../data/content';
|
||||
import { usePackagesQuery } from '../hooks/usePackagesQuery';
|
||||
|
||||
@@ -52,17 +53,14 @@ export function ContactFormView({ client, token, refreshToken }: ContactFormView
|
||||
const { data: packages } = usePackagesQuery();
|
||||
const preselect = useContactPreselect();
|
||||
const subjectOptions = useMemo<SubjectOption[]>(
|
||||
() => [
|
||||
...(packages ?? []).map((pkg) => ({ value: pkg.slug, label: pkg.title })),
|
||||
{ value: 'other', label: contactForm.otherSubjectLabel },
|
||||
],
|
||||
() => buildSubjectOptions(packages, contactForm.otherSubjectLabel),
|
||||
[packages],
|
||||
);
|
||||
|
||||
const form = useContactForm({
|
||||
idPrefix: 'contact',
|
||||
subjectOptions,
|
||||
preselect: { subject: preselect.subject, key: preselect.key },
|
||||
preselect: { subject: subjectForSlug(packages, preselect.subject), key: preselect.key },
|
||||
client,
|
||||
token,
|
||||
refreshToken,
|
||||
|
||||
Reference in New Issue
Block a user