Build, unit, integration and performance test instructions and the summary, the corrected scroll rule and the review on test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2.6 KiB
2.6 KiB
Build and Test Summary — contact-page
Tested on branch feature/contact-page (units 1–3 on master a58bc1c, plus the review changes), locally on Windows, 2026-10-25.
Build
- Tool: pnpm + Vite (
tsc && vite build) - Status: ✅ Success (0.8 s locally). CI: run 573 failed (runner process terminated after
pnpm install) and 574 failed (router DNS) — both infrastructure; run 575 (workflow_dispatch, deploy_test,9c2601d):check,deploy-test,lighthouse✅ - Main bundle: 149.3 kB gzip (was 169.6 kB: Rolldown moved shared modules into a separate chunk; homepage performance measured identical, see performance)
Unit tests
- Total: 367 in 71 files. Passed: 367. Failed: 0. Coverage thresholds met; 92.7% of statements overall
- Status: ✅ Pass
Integration (browser, production build)
16 checks across the scenarios in integration-test-instructions.md, all ✅ after one fix:
- Found in this stage: on a phone, "Stuur een berichtje" on Soorten fotoshoots opened
/contactat the previous scroll position (scrollY 652) instead of the top. Cause: the contact route removes?pakket=with a second navigation that usedresetScroll: false(copied from the homepage, where it serves the#contactjump); it replaced the incoming navigation before the router had reset the scroll. Fix: keep the default scroll reset on that navigation (BR-CP-12 corrected). Rechecked at 1440 and 390 px: top of the page. - Network check: no photo request below 1024 px, priority High from 1024 px.
Performance
See performance-test-instructions.md: desktop all ≥ 0.99; mobile /contact 0.88–0.90 (budget 0.9, kept by the owner) and / 0.78–0.80 (pre-existing, owner: separately). Accessibility 1.0 everywhere after the accent-button contrast fix.
Additional
- Security:
pnpm audit --prod --audit-level highclean. No new dependencies, external resources or CSP changes (data:images were already allowed). No e-mail address in served HTML or JSON-LD.?pakket=validated against the package ids and never rendered (property-tested). - Contract / E2E suite: N/A (static front end without an API); the browser checks cover the user flows.
Review changes after the test deploy
- Submit button of the contact form right-aligned (homepage and contact page), the privacy line below it aligned with it.
Overall
- Build: ✅ Tests: ✅ Integration: ✅ Performance: desktop ✅, mobile per the owner's decisions
- Operations phase: declined at Requirements Analysis. Next: PR to master (merging also deploys to test).