Continuous Integration / check (pull_request) Successful in 2m25s
Continuous Integration / build-test (pull_request) Skipped
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / lighthouse (pull_request) Successful in 9m2s
Continuous Integration / deploy-production (pull_request) Skipped
The form is closed unless the build sets VITE_CONTACT_FORM_ENABLED=true (only
the test build does), so d449e76 no longer has to be undone before the merge.
Status files of contact-form-cms, asf-packages-cms, asf-cms-host-injection and
asf-translation-files are closed; Build and Test summary added.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3.6 KiB
3.6 KiB
Requirements and design: packages and banner from the CMS
Decided by Bryan via SLP Software - SLS - Main, 2026-11-12. Source of truth: the CMS API GET /api/v1/offerings (fields: id, slug, title, description, price as free text, priceNote, features[], ctaLabel, featured, displayOrder, categoryId, category, layout card|banner; at most one banner per site).
Requirements
- FR-PK-01 The build asks the CMS for the offerings and bakes them into the pages (prices in the HTML and in the structured data). The browser never calls the offerings API.
- FR-PK-02 Fallback: with no address, an unreachable CMS or an answer without a valid package the committed snapshot (
src/content/offerings.snapshot.json, the three packages) is used. The build never fails because of the CMS and never shows an empty or wrong price. The log names the source. - FR-PK-03 One source: the price cards, the "welke shoot" choices of the contact form and the
?pakket=check use the same list (content/packages.ts). - FR-PK-04 Mapping:
slugis the package id (keptzwangerschap,newborn,gezin: they appear in?pakket=and the form),titlethe name, the price text is read as whole euros ("€ 175", "€ 1.250", "175,-"); a card with an unreadable price, no features or a bad slug is skipped; order bydisplayOrder. - FR-PK-05 Banner: the first usable offering with
layout=bannerbecomes an optional dark band under the cards (own block, price as free text). It is not a package: not in the form choices, not in the package count, no booking link with a package. - FR-PK-07 Last row of cards (desktop): rows of three, an incomplete last row is centred, for any number of cards, with no styling per number. Phone and tablet stay one column. Done with a wrapping flex and card width
calc((100% - 2 * gap) / 3). - FR-PK-08 Slim top bar (2026-11-14, Bryan via SLS-Main): a second banner ABOVE the cards, next to the one under them; both may show at once. One line (title and text on one line, optional small text link), a slim bar in the ASF style that matches the white bottom banner. Contract:
GET /api/v1/offerings/banner?position=top|bottom(no parameter is bottom), 204 is none, fields title/text/linkLabel/linkUrl, the title may be empty for top (title or text required). Built in like the bottom banner: baked in the HTML, replaced live after hydration, 204 hides it, errors keep what was baked, empty fields hidden. - FR-PK-06 The rebuild trigger (CMS change leads to a new build) is separate from the build; decision for Bryan (webhook to workflow_dispatch or a nightly build). Until then a change shows after the next build.
- NFR-PK-01 Tests use the snapshot only (no dependence on a build or network).
Design
web/config/offerings.tspure mapping and validation (unit and property tests).web/config/fetchOfferings.tsbuild step (pnpm buildruns it first):OFFERINGS_URL(the site's own address serving the API), 10 s timeout, 2 attempts, writes the gitignoredsrc/content/offerings.generated.json.web/src/content/packages.tspicks generated data (build) or the snapshot (tests, missing file).- CI: the Build step gets
OFFERINGS_URLfrom the repo variableASF_OFFERINGS_URL. The artifact built there is also what goes to production, so the variable must point to the CMS holding the real data. PriceBannercomponent insidePricing.
Open
- Offerings module on the ASF-test host and the three packages in the ASF-test CMS (asked of the CMS session; 2026-11-12 the endpoint answered 404 on test.andreaslop.nl).
- Repo variable
ASF_OFFERINGS_URL(who sets it: Bryan or SLS). - Rebuild trigger.
- ASF production CMS address does not exist yet.