Files
AndreaSlopFotografie/aidlc-docs/features/hero-module/assumptions-and-open-questions.md
T
SluijsensandClaude Sonnet 5.5 3d7bb2d4a6 Hero: keep the plain HTML region after hydration, add the slider around it
Replacing the region at hydration made new nodes (a late LCP candidate). The first photo, the title and the buttons now stay; the other slides, arrows and controls are added on top.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-16 17:39:06 +01:00

2.4 KiB

Hero module: assumptions and deferred questions (ASF side)

Written while Bryan was away; he decides later. Each point: question, assumption, what changes with another answer, where in the code.

# Question Assumption If the answer differs Where
1 Focus points of the 8 photos Estimates from the seed (e.g. hero-8 0.50/0.55) Change x/y in the seed (CMS) and in the baked values web/src/content/heroContent.ts, web/contract/host-injection/hero/seed.json
2 Is the baked hero cropped around the focus point too? Yes: object-position from the estimates, so baked and live look the same Pass focus: null for the baked slides to get plain centre crop heroContent.ts
3 Button target #anchor and https: plain link, /path: router link As said Make all plain links web/src/components/Hero/HeroButton.tsx
4 Single display (one photo) or slideshow with one slide No arrows, pause or progress bar for one slide Show controls anyway Hero.tsx (shown.length > 1)
5 Title with a new line <br> in the plain HTML, pre-line in the slider One line only heroHtml.ts, Hero.tsx
6 Where does the head preload marker come from Build step adds it to the finished HTML (React cannot write a head comment) Host adds the head region itself web/config/heroPreload.ts
7 Hero texts (aria, baked title, alts) In nl.json, block hero Other wording: edit the file web/src/i18n/nl.json
8 Without a host block the site asks /api/v1/hero (8 s time-out) Yes, like packages and banners Remove the call: baked only web/src/components/Hero/useHero.ts
9 Style of the plain hero before hydration Matches the slider's first frame (checked by screenshot at 1280 and 390 px) Adjust CSS .cms-hero-* in web/src/theme.ts
10 AVIF for slides 2..n only As agreed with the CMS session Add AVIF to the first photo and its preload (then two fetches) Hero.tsx (SlidePicture)
11 The first photo, title and buttons stay the plain HTML after hydration (never replaced); the slider adds the other photos on top Yes: replacing the nodes at hydration risks a late LCP. Side effect: the first photo has no slow zoom and is not in a role=group slide Go back to a full slider render (one component), accepting the DOM replacement Hero.tsx (HeroFrame), useHero.ts (regionHero)