Full pnpm check at d12665c passed (325 tests, Lighthouse within budget)
and 19 browser checks against the production build passed. Adds the
build and test instructions and summary, marks the feature complete
and logs the session in the audit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3.2 KiB
3.2 KiB
Build and Test Summary — soorten-fotoshoots-page
Tested commit: d12665c (unit 1 shared blocks and content + unit 2 Soorten fotoshoots page, incl. the review changes), locally on Windows, 2026-10-25.
Build
- Tool: pnpm + Vite (
tsc && vite build) - Status: ✅ Success (0.9 s locally). CI run 568 (
workflow_dispatch, deploy_test) once2cb92:check,deploy-testandlighthouse✅; PR run 569 once2cb92✅; PR run 570 ond12665cin progress at the time of writing - Artifacts:
web/dist/ - Main bundle: 169.6 kB gzip (+0.3 kB against master)
Unit tests
- Total: 325 in 65 files. Passed: 325. Failed: 0.
- Coverage: thresholds met; 92.4% of statements overall
- Status: ✅ Pass
Integration (browser, production build)
19 checks across the 12 scenarios in integration-test-instructions.md, all ✅:
| Scenario | Result |
|---|---|
| Newborn contact link → package preselected, Contact below the header (1440 / 390) | ✅ 68 / 66 px |
| Loveshoot contact link, "de pakketten", "Boek je shoot" (1440 / 390) | ✅ all land below the header |
Anchor #gezin (1440 / 390) |
✅ |
| Main menu → page at the top, h1 and title | ✅ |
| Outline and article names | ✅ |
| JSON-LD (5 services, anchors, provider, area, no prices) and head tags | ✅ |
| No e-mail in served HTML or JSON-LD | ✅ |
| Layout shift while scrolling, 10 photos loaded (1440 / 390) | ✅ CLS 0.0000 |
| No horizontal overflow, 3 pages × 5 widths | ✅ |
| Keyboard order, focus ring, touch targets | ✅ contact links 44 px, button 53 px |
Found in this stage
- The Newborn contact-link check first failed, but the check was wrong, not the page. It expected
?pakket=newbornin the final URL. The homepage's ContactSection takes?pakket=over into the form and then removes it from the address bar on purpose (as with the price cards). The check now reads the link'shrefand confirms the preselected package; it passes.
Performance (Lighthouse CI, production build)
| Page | Mobile (budget) | Desktop |
|---|---|---|
| Homepage | 0.80 (0.8) | 0.99 |
| Over mij | 0.91 (0.85) | 1.0 |
| Soorten fotoshoots | 0.89 (0.85) | 1.0 |
| Other pages | 0.94–0.95 (0.9) | 1.0 |
Accessibility and best practices are 1.0 on every page; SEO 1.0 on the indexed pages. Why the photo pages have a mobile budget of 0.85: see performance-test-instructions.md.
Additional
- Security:
pnpm audit --prod --audit-level highclean. The fullpnpm auditreports 17 findings in development tools only (same as master, NFR-SEC-05). No new dependencies, no new external resources, CSP unchanged. Query parameters on outgoing links only come from our own package and shoot ids (PBT). - Contract / E2E suite: N/A (static front end without an API). The browser checks above cover the user flows.
Overall
- Build: ✅ Tests: ✅ Performance budgets: ✅
- Owner review: texts approved; layout changed on review (smaller photos with detail photos, alternating bands, narrower text) and approved locally; no second deploy to test at the owner's request
- Operations phase: declined at Requirements Analysis. The next step is merging PR #8 (also deploys to test; announce it to the parallel feature sessions first).