Files
SluijsensandClaude Sonnet 5.5 d8847d8c3b Documents build and test, operations and the approved privacy wording
Adds the build and test summary and instructions, the deployment and
monitoring plans, the production readiness checklist with the go-live
conditions, and the approved privacy draft (retention, controller).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 23:40:11 +01:00

2.6 KiB

Build and test summary: contact-form-cms

Date: 2026-11-10. Branch feature/contact-form-cms (a1444b7 plus later commits). Unit: contact-form (web only).

Check Result
tsc (typecheck in pnpm build) clean
pnpm lint (ESLint incl. cms-client import boundary) clean
pnpm format:check clean
pnpm test (Vitest, 100% thresholds for pure functions) 134 files, 1473 tests passed
cms-client package tests (copied) 62 passed (boundary test included)
pnpm build + prerender ok, 12 pages
E2E contactForm.e2e.ts + hydration.e2e.ts (real Chrome, built site, mocked /api) 49 passed, 2 skipped with the switch off; the 2 "switch on" tests pass in a build with the switch on
pnpm audit --prod no known vulnerabilities
Lighthouse mobile all pages pass, except / performance 0.84 (threshold 0.85); same chance result as on master earlier (0.84); not a regression of this feature
Lighthouse desktop all 12 pages pass
Real widget in real Chrome against the local ASF host (CMS 192.168.1.2:5291, captcha on, global endpoint) form opens, widget loads and solves, POST 202, thank-you shown, no CSP violation, no console message

Requirement coverage

FR-CF-01..12 and NFR-CF-01..05 are covered by the unit/component tests (ContactForm, ContactPanel, useContactAvailability through the panel, securityHeaders, shootOptions), the e2e and the real-browser run. PBT (partial): label length 1-100 and uniqueness, JSON round trip with special characters, and the package's own property tests.

Findings and decisions

  • CSP: only frame-src with the exact hosts global, global0, global1 is needed; the real-browser run showed no violation without connect-src, script-src or worker-src additions (the widget's own fetches run inside its iframe).
  • With the switch on, a 404 on the token route (form closed) logs a console message in the browser; the hydration e2e tests therefore run with the switch off and the switch-on behaviour has its own e2e with a mocked API.
  • The package needed two small changes for ASF's stricter rules (explicit field instead of a constructor parameter property; a loop instead of a recursive useCallback); SLS-Main made them upstream (93fa729), so the copy is unchanged.
  • Dev (StrictMode) asks for the token twice; the production build asks once.

Not done / needs others

  • Test of the form against a deployed ASF test host (needs the CMS branch merged and deployed; not requested yet).
  • EU endpoint (eu, eu0, eu1 in frame-src) is not tested; it needs a paid plan.
  • Screen reader check by a person.