# Code Quality Assessment ## Test Coverage - **Overall**: Good. Vitest with v8 coverage; 100% threshold enforced for `src/lib/**`, `src/seo.ts`, `src/sitemap.ts`; other files reported - **Unit Tests**: Pure helpers, SEO, sitemap, monitoring config, security headers, server config (incl. drift check against `deploy/`) - **Component Tests**: AppShell, NavigationBar, Footer, Hero (+ slider hook), BackToTop, PageIntro, StatusPage, Umami, all home sections, PageSection, MediaText, Eyebrow, SectionHeading, FramedImage, DeferredImage, Reveal, NoScript CSS and menu links, first-row grid (display fallbacks; also `displayHydration`, `displayPrerender` and the e2e files `displayHtml`, `noJs`, `noJsMenu`, `reveal`, `images`), ContactForm(+Gate) — with axe accessibility checks; `app.test.tsx` renders whole routes - **Property-based Tests**: fast-check, shared arbitraries in `src/test/arbitraries.ts`, seed logged in CI - **Integration / E2E**: Browser tests on `dist/client` (`pnpm e2e`); unit 3 of prerendering adds a real nginx test in CI (the generated block against the preview server, the `lighthouse` job installs nginx and lftp and fails when nginx is missing); Lighthouse CI covers built pages (accessibility, best practices, SEO, performance), the not-found page through `/__audit/404` ## Code Quality Indicators - **Linting**: ESLint (typescript-eslint, react-hooks, jsx-a11y), enforced in CI - **Code Style**: Consistent, Prettier-enforced in CI - **Documentation**: Short Dutch comments explaining *why*, often referencing requirement IDs (FR-xx, BR-xx, NFR-xx, Mx) from earlier AI-DLC features ## Technical Debt - Mobile Lighthouse performance exceptions (owner decision 2026-11-01, after the final measurement of prerendering): floor 0.85 for `/` (measured 0.85, raised from 0.8), gezin (0.89) and loveshoot (0.88) until responsive photos exist, and for zwangerschap and portret (both ~0.90, unreliable as a target with one run); all other pages must reach 0.9. Desktop is 0.9 everywhere - IIS rules are generated but unverified until a host exists; the nginx proof runs on nginx 1.24 in CI, the Pi runs 1.30 - Four routes are placeholders (`noindex`); `lighthouserc.cjs` keeps its own list of indexed/noindex paths, guarded by a test against `sitePages.ts` - No responsive image pipeline (srcset/sizes); photos are single JPEGs - Comment language is mixed: older code is commented in Dutch, homepage-sections code in English ## Patterns and Anti-patterns - **Good Patterns**: API-shaped content; pure, property-tested helpers; tokens and recipes as single source of truth; configuration as code for headers; strong accessibility baseline (axe in tests, Lighthouse accessibility 1.0) - **Anti-patterns**: None significant found